Skip to content

Add assessment repo

Kristina Mazurrequested to merge
feature/add_assessment_repo into main

Description

This MR adds the assessment repo into the unicado-package and changes the installer so that these tools are included as well. It is linked to the MR in rce-workflow - otherwise you can not run the changes in the workflow and only test the installer process.

Summary of changes:

  • add submodule assessment
  • replace assessment_manager with cost_estimation in installer/python_module_list
  • include nested folder assessment (see install_unicado.py)

Related Issue(s)

Other Changes

  • updated lines with phabricator repo links (see browse_folder.py, install_unicado.py etc)
  • fix tool integration for pep8 regex (see check_tool.py)
  • Add tool_name.py as tool option (see browse_folder.py)
  • Update error_handling_string for correct tool name (see write_json_file.py)
  • Update string for needed installation size (to 500MB)

Testing Instructions

  • Checkout this branch feature/add_assessment_repo
  • Run git submodule update --init --recursive
  • Check for the assessment folder. Make sure that the libs folder is not empty as well otherwise update the submodule here again
  • Create an installer with cmake --workflow --preset x64-windows-release
  • install the installer
  • open the UNICADOworkflow folder and find assessment/ with the new tools
  • open rce and check if the tools cost_estimation and ecological_assessment are replaced by the assessment_manager
  • copy this file into UNICADO-SMR-180-TF assessment.xml
  • let the workflow run with the default settings (no assessment tools will be executed)
  • open the assessment_manager config and enable assessment tools
  • let the workflow run again and see that you will get some assessment results

Developer Checklist

  • Code has been tested locally and/or in pipeline.
  • (if applicable) documentation updated.
  • (if applicable) impact of new dependencies reviewed and included in project.
  • Merge conflicts resolved with the target branch.

Additional Notes

As soon as rce-worklfow and aircraft-references are merged, I will update their submodule here so that the installer has the right workflow and projects files.

And for reference: the installer I created with this branch, is uploaded in the rce MR

Merge request reports