Feat: clean up interface methods that are not implemented
This MR removes the interface methods for
- geometry meshes,
- acoustic materials,
- sound portals,
- scenes.
All of these are not implemented in the core library and raise exceptions. In order to clean up the interface, we decided to remove them.
Since gRPC is forwards compatible with regards to adding functions, this was considered a good choice.
For future features like this, it could also make sense to use some of the existing methods like call_module (e.g. call the geometry module) or setting a geometry for a certain renderer via SetRenderingModuleParameters.
Things to discuss:
- Remove:
-
CreateSignalSourceTextToSpeechetc..? AddSignalSourceSequencerSampleAddSignalSourceSequencerPlayback
-
- Streamline the interface? I.e. with
SetSoundSourcePose,SetSoundSourcePositionandSetSoundSourceOrientationare redundant.- Also note:
SetSoundReceiverRealWorldPositionOrientationVU
- Also note:
- The signal source type has different option on the interface and the core.
Additional changes:
- Remove:
-
parameterfromModuleInfo-> The modules in the VACore do not have any parameters to set. -
directivity_id,auralization_mode,position,view,up,orientation,parametersfromSoundSourceInfo-> These cannot be set easily from aCVASoundSourceDescand are redundant. - a lot of fields from
SoundReceiverInfo-> Same as forSoundSourceInfo
-
- Fixes:
-
classandnum_referencesfromDirectivityInfo-> Always set to -1; now correct in VACore -
signal_source_idinSoundSourceInfo-> now correct in VACore -
bOutputRecordingEnabledinAudioRendererInfo-> was not set by Core -
bOutputRecordingEnabledandbInputRecordingEnabledinAudioReproductionInfo-> was not set by Core
-
- Added:
-
explicit_renderer_idtoSoundSourceInfo -
explicit_renderer_idtoSoundReceiverInfo -
idtoModuleInfo
-
Edited by Pascal Palenda