Feat: clean up interface methods that are not implemented
This MR removes the interface methods for
- geometry meshes,
- acoustic materials,
- sound portals,
- scenes.
All of these are not implemented in the core library and raise exceptions. In order to clean up the interface, we decided to remove them.
Since gRPC is forwards compatible with regards to adding functions, this was considered a good choice.
For future features like this, it could also make sense to use some of the existing methods like call_module
(e.g. call the geometry module) or setting a geometry for a certain renderer via SetRenderingModuleParameters
.
Things to discuss:
- Remove:
-
CreateSignalSourceTextToSpeech
etc..? AddSignalSourceSequencerSample
AddSignalSourceSequencerPlayback
-
- Streamline the interface? I.e. with
SetSoundSourcePose
,SetSoundSourcePosition
andSetSoundSourceOrientation
are redundant.- Also note:
SetSoundReceiverRealWorldPositionOrientationVU
- Also note:
- The signal source type has different option on the interface and the core.
Additional changes:
- Remove:
-
parameter
fromModuleInfo
-> The modules in the VACore do not have any parameters to set. -
directivity_id
,auralization_mode
,position
,view
,up
,orientation
,parameters
fromSoundSourceInfo
-> These cannot be set easily from aCVASoundSourceDesc
and are redundant. - a lot of fields from
SoundReceiverInfo
-> Same as forSoundSourceInfo
-
- Fixes:
-
class
andnum_references
fromDirectivityInfo
-> Always set to -1; now correct in VACore -
signal_source_id
inSoundSourceInfo
-> now correct in VACore -
bOutputRecordingEnabled
inAudioRendererInfo
-> was not set by Core -
bOutputRecordingEnabled
andbInputRecordingEnabled
inAudioReproductionInfo
-> was not set by Core
-
- Added:
-
explicit_renderer_id
toSoundSourceInfo
-
explicit_renderer_id
toSoundReceiverInfo
-
id
toModuleInfo
-