Skip to content
Snippets Groups Projects

Merge request for new application profile: 7-achsige Knickarmroboter-Trajektorendaten

Merged Ghost User requested to merge Request/3bda8abb-f6bc-4649-987e-db56d1853a15 into master

Merge request created by Leon Gorißen, leon.gorissen@llt.rwth-aachen.de, created at 16.05.2024 16:15:51

Note: the Review can be carried out either by checking the index.ttl file under the changes tab or by copy-and-pasting the content of the file into the AIMS Frontend

  • Copy and paste code into AIMS Frontend. Check the form using under the metadata-form button. Does everything render correctly and do all the fields work?
  • Do the title and description match
  • Is there an English and German version of the title and description? (English is OK, but bi-lingual is preferred.)
  • Are various datatypes used? (If applicable, in some cases, only using string is entirely appropriate.)
  • Does each field have a description?
  • If pre-defined terms are used, do they make sense? (broadly speaking, e.g., dcterms:author is not used for a field named "Device".)
  • Does sh:targetClass URL match the base URL? (Applies in most but not all cases.)
  • If the base URL (line one in index.ttl) contains the GUID such as https://purl.org/coscine/ap/{GUID}/, modify this to contain the name of the profile and, if required, the grouping: https://purl.org/coscine/ap/{profileName}/ or https://purl.org/coscine/ap/{group}/{profileName}/
    • Change any other instances of the base URL to match.
  • Deploy on DSP-10 by clicking the arrows in the pipeline box at the top of the merge request–just under the the reactions. (add label accordingly when done)
  • Test on DSP-10 by creating a resource with the application profile and adding a file/linked data to the resource on the web interface (add label accordingly when done). Does everything render correctly and do all the fields work?
  • If applicable, contact submitter via service desk ticket (check box here and add "waiting" label to request).
  • Once review is complete, comment and tag Petar and Benedikt to approve and merge

For more details, see the documentation.

Edited by Kseniia Dukkart

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kseniia Dukkart marked the checklist item Do the title and description match as completed

    marked the checklist item Do the title and description match as completed

  • Kseniia Dukkart marked the checklist item Is there an English and German version of the title and description? (English is OK, but bi-lingual is preferred.) as completed

    marked the checklist item Is there an English and German version of the title and description? (English is OK, but bi-lingual is preferred.) as completed

  • Kseniia Dukkart marked the checklist item Are various datatypes used? (If applicable, in some cases, only using string is entirely appropriate.) as completed

    marked the checklist item Are various datatypes used? (If applicable, in some cases, only using string is entirely appropriate.) as completed

  • Kseniia Dukkart marked the checklist item Does each field have a description? as completed

    marked the checklist item Does each field have a description? as completed

  • Kseniia Dukkart marked the checklist item Does sh:targetClass URL match the base URL? (Applies in most but not all cases.) as completed

    marked the checklist item Does sh:targetClass URL match the base URL? (Applies in most but not all cases.) as completed

  • Dear @leon.gorissen, thank you for submitting the application profile. I have addressed the duplicate fields, but it appears that there is still one remaining issue. You have inadvertently entered the URL of the "Datatype" metadata field in place of the URLs for other fields.

    Could you please provide the correct URLs for the following metadata fields: "Velocity scaling factor," "Acceleration scaling factor," "Robot UUID," and "Robot description"?

    Thank you for your attention to this matter.

  • Kseniia Dukkart marked the checklist item Change any other instances of the base URL to match. as completed

    marked the checklist item Change any other instances of the base URL to match. as completed

  • Hi @kseniia.dukkart,

    thanks for your feedback. As i can't edit the underlying merge request myself, you can find the adapted app profile file raw contents here. In addition to my mix up with the paths, I did git commit hash as well.

    index.ttl

    Edited by Leon Michel Gorißen
  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Kseniia Dukkart marked the checklist item Copy and paste code into AIMS Frontend. Check the form using under the metadata-form button. Does everything render correctly and do all the fields work? as completed

    marked the checklist item Copy and paste code into AIMS Frontend. Check the form using under the metadata-form button. Does everything render correctly and do all the fields work? as completed

  • Kseniia Dukkart marked the checklist item If the base URL (line one in index.ttl) contains the GUID such as https://purl.org/coscine/ap/{GUID}/, modify this to contain the name of the profile and, if required, the grouping: https://purl.org/coscine/ap/{profileName}/ or https://purl.org/coscine/ap/{group}/{profileName}/ as completed

    marked the checklist item If the base URL (line one in index.ttl) contains the GUID such as https://purl.org/coscine/ap/{GUID}/, modify this to contain the name of the profile and, if required, the grouping: https://purl.org/coscine/ap/{profileName}/ or https://purl.org/coscine/ap/{group}/{profileName}/ as completed

  • Kseniia Dukkart marked the checklist item If pre-defined terms are used, do they make sense? (broadly speaking, e.g., dcterms:author is not used for a field named "Device".) as completed

    marked the checklist item If pre-defined terms are used, do they make sense? (broadly speaking, e.g., dcterms:author is not used for a field named "Device".) as completed

  • Kseniia Dukkart marked the checklist item Deploy on DSP-10 by clicking the arrows in the pipeline box at the top of the merge request–just under the the reactions. (add label accordingly when done) as completed

    marked the checklist item Deploy on DSP-10 by clicking the arrows in the pipeline box at the top of the merge request–just under the the reactions. (add label accordingly when done) as completed

  • Benedikt Heinrichs approved this merge request

    approved this merge request

  • mentioned in commit 97ed5ec1

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading