Skip to content
Snippets Groups Projects

Features/json adapter

Merged Michael Thies requested to merge features/json_adapter into master

First draft of JSON serialization and deserialization according to DotAAS, section 5.5 (see #21 (closed)). Basic implementation is finished, but some things are left to do:

  • Add thorough testing (current simple test reaches only 40% coverage)
  • Further improve testing:
    • Add fail tests for deserialization
    • Add example with None-Values
  • Verify license of JSON Schema file (If it is not guaranteed to be provided under a free license, we need to rebase the branch to remove it from the history.)
  • Merge master and adapt serialization/deserialization for changes on master branch:
    • Reference vs. AASReference,
    • base classes of View,
    • add license header
    • use model.KEY_ELEMENTS_CLASSES instead of copy in aas.adapter.json.json_deserialization.
  • Fix insertion of modelType for non-Referable classes in JSON serialization
Edited by Michael Thies

Merge request reports

Pipeline #221118 passed

Pipeline passed for fd6a5209 on features/json_adapter

Test coverage 91.00% (15.00%) from 1 job
Test summary results are being parsed

Merged by Michael ThiesMichael Thies 5 years ago (Dec 19, 2019 4:08pm UTC)

Loading

Pipeline #221126 passed

Pipeline passed for 5fbe8ed2 on master

Test coverage 89.00% (15.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading