Skip to content
Snippets Groups Projects

Minor rework of python modularization documentation

Merged s-roscher requested to merge feature/update_python_modularization into develop
All threads resolved!

Minor rework of python modularization documentation

Description

Some bugs were fixed:

  • Pictures uploaded
  • Links updated
  • Python example file uploaded and link provided

Some improvements were made:

  • Formatting issues fixed

Related Issue(s)

N/A

Other Changes

N/A

Screenshots/Logs

N/A

Testing Instructions

  1. run medics serve and have a look at the website

Developer Checklist

  • Code has been tested locally and/or in pipeline.
  • (if applicable) documentation updated.
  • (if applicable) impact of new dependencies reviewed and included in project.
  • Merge conflicts resolved with the target branch.

Additional Notes

N/A

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • s-roscher requested review from @kristina.mazur

    requested review from @kristina.mazur

  • assigned to @s-roscher

    • Resolved by s-roscher

      Thanks for the update! When I try to clone it I get this error:

      git checkout feature/update_python_modularization                                                                                 in cmd at 10:38:11error: invalid path 'docs/get-involved/modularization/python-template/AircraftDesign/cost_estimation/Icon?'
      error: invalid path 'docs/get-involved/modularization/python-template/AircraftDesign/cost_estimation/src/Icon?'
      error: invalid path 'docs/get-involved/modularization/python-template/AircraftDesign/cost_estimation/src/blended_wing_body/Icon?'
      error: invalid path 'docs/get-involved/modularization/python-template/AircraftDesign/cost_estimation/src/tube_and_wing/Icon?'
      error: invalid path 'docs/get-involved/modularization/python-template/AircraftDesign/cost_estimation/src/tube_and_wing/empirical/Icon?'
      error: invalid path 'docs/get-involved/modularization/python-template/AircraftDesign/cost_estimation/src/tube_and_wing/empirical/operating_cost_estimation_tu_berlin/Icon?'
      error: invalid path 'docs/get-involved/modularization/python-template/AircraftDesign/cost_estimation/src/tube_and_wing/empirical/operating_cost_estimation_tu_berlin/general/Icon?'
      error: invalid path 'docs/get-involved/modularization/python-template/AircraftDesign/cost_estimation/src/tube_and_wing/empirical/operating_cost_estimation_tu_berlin/kerosene/Icon?'
      error: invalid path 'docs/get-involved/modularization/python-template/AircraftDesign/cost_estimation/src/tube_and_wing/empirical/operating_cost_estimation_tu_berlin/liquid_hydrogen/Icon?'

      So acc to this blog: https://dev.to/jumbo02/how-to-fix-error-invalid-path-when-working-with-git-on-windows-16kf windows does not like to checkout these icon files you uploaded. Are they important or can they be deleted?

    • Resolved by s-roscher

      Also I would delete the following:

      • pycache and .pyc files
      • is the doc folder necessary? Because we dont (or at least should not anymore :D ) have it in the aicraft-design repo
      • the log file

      Also I think the main.py needs to be replace with cost_estimation.py right?

  • s-roscher added 1 commit

    added 1 commit

    Compare with previous version

  • s-roscher resolved all threads

    resolved all threads

  • Kristina Mazur approved this merge request

    approved this merge request

  • Kristina Mazur mentioned in commit 278d4351

    mentioned in commit 278d4351

Please register or sign in to reply
Loading