Implemented changes to enable wing without kink.

• Added some checks to distinct between low and high mounted wing
• Deleted some dead code

added moduletank_design label

requested review from @AndiGob and @kkos05

assigned to @s-roscher

assigned to @AndiGob

I'm on it

I first tested the "standard" configuration. With your new implementation the CG of the tanks differs now. Is that intended? This is the XML before:CSMR-2020.xml and this after:CSMR-2020.xml

I will now test the high wing configuration

I saw you mentioning that in an earlier issue. Honestly, I don't know where this is coming from since I don't remember changing something that affects the CGs. But I'll check that!

Maybe something with the additional tanks? I still have them activated...

It seems to be something in the trim tank calculation, yep. Give me a second.

I forgot that I changed something in the trim tank calculation. But by changing that I actually fixed some hard-coded stuff that I must have missed earlier. So I think the values are better now. So yes, this was intended.

If I change the wing_definition to high and undercarriage_definition to fuselage_mounted I get the error: 2024-12-05 - 16:28:59,942: TOOL_ERROR - Exit information: Invalid tank definition in aircraft exchange file. (tank_design@UNICADOworkflow_2024-12-05_16:28:29_06)

I guess I need to change the tank definitions. I deleted now trim tank, additional tank, and outer wing tanks - now I got a new one: 2024-12-05 - 16:38:27,413: TOOL_OUT - 2024-12-05 16:38:26,768 - CRITICAL - Error:The value of the parameter z = 17.62689411 exceeds the given upper boundary of 5. Program aborted! (tank_design@UNICADOworkflow_2024-12-05_16:37:57_08) CSMR-2020.xml

If I change the wing_definition to high and undercarriage_definition to fuselage_mounted I get the error: 2024-12-05 - 16:28:59,942: TOOL_ERROR - Exit information: Invalid tank definition in aircraft exchange file. (tank_design@UNICADOworkflow_2024-12-05_16:28:29_06)

Damn - sorry, forgot to mention that... If the wing mounting is set to 'high', the user has to use the following tank configuration:

                <tank_definition description="Energy tanks information">
                    <tank ID="0" description="Inner left tank">
                        <energy_carrier_ID description="see energy carrier specification node">
                            <value>0</value>
                            <unit>1</unit>
                            <lower_boundary>0</lower_boundary>
                            <upper_boundary>5</upper_boundary>
                        </energy_carrier_ID>
                        <location description="Component where the tank is located: fuselage, wing, horizontal_stabilizer">
                            <value>wing</value>
                        </location>
                        <position description="Position of tank in location: tailcone, rear, front, top, bottom, center, inner_left, outer_left, inner_right, outer_right, total">
                            <value>inner_left</value>
                        </position>
                        <energy_share description="Share of this tanks energy in relation to required mission energy (of same energy carrier). Only relevant for liquid hydrogen tanks. Equals 0.0 for kerosene tanks.">
                            <value>0.0</value>
                            <unit>1</unit>
                            <lower_boundary>0.0</lower_boundary>
                            <upper_boundary>1.0</upper_boundary>
                        </energy_share>
                    </tank>
                    <tank ID="1" description="Inner right tank">
                        <energy_carrier_ID description="see energy carrier specification node">
                            <value>0</value>
                            <unit>1</unit>
                            <lower_boundary>0</lower_boundary>
                            <upper_boundary>5</upper_boundary>
                        </energy_carrier_ID>
                        <location description="Component where the tank is located: fuselage, wing, horizontal_stabilizer">
                            <value>wing</value>
                        </location>
                        <position description="Position of tank in location: tailcone, rear, front, top, bottom, center, inner_left, outer_left, inner_right, outer_right, total">
                            <value>inner_right</value>
                        </position>
                        <energy_share description="Share of this tanks energy in relation to required mission energy (of same energy carrier). Only relevant for liquid hydrogen tanks. Equals 0.0 for kerosene tanks.">
                            <value>0.0</value>
                            <unit>1</unit>
                            <lower_boundary>0.0</lower_boundary>
                            <upper_boundary>1.0</upper_boundary>
                        </energy_share>
                    </tank>
                    <tank ID="2" description="Center wing tank">
                        <energy_carrier_ID description="see energy carrier specification node">
                            <value>0</value>
                            <unit>1</unit>
                            <lower_boundary>0</lower_boundary>
                            <upper_boundary>5</upper_boundary>
                        </energy_carrier_ID>
                        <location description="Component where the tank is located: fuselage, wing, horizontal_stabilizer">
                            <value>wing</value>
                        </location>
                        <position description="Position of tank in location: tailcone, rear, front, top, bottom, center, inner_left, outer_left, inner_right, outer_right, total">
                            <value>center</value>
                        </position>
                        <energy_share description="Share of this tanks energy in relation to required mission energy (of same energy carrier). Only relevant for liquid hydrogen tanks. Equals 0.0 for kerosene tanks.">
                            <value>0.0</value>
                            <unit>1</unit>
                            <lower_boundary>0.0</lower_boundary>
                            <upper_boundary>1.0</upper_boundary>
                        </energy_share>
                    </tank>
                    <tank ID="3" description="Additional center tank">
                        <energy_carrier_ID description="see energy carrier specification node">
                            <value>0</value>
                            <unit>1</unit>
                            <lower_boundary>0</lower_boundary>
                            <upper_boundary>5</upper_boundary>
                        </energy_carrier_ID>
                        <location description="Component where the tank is located: fuselage, wing, horizontal_stabilizer">
                            <value>fuselage</value>
                        </location>
                        <position description="Position of tank in location: tailcone, rear, front, top, bottom, center, inner_left, outer_left, inner_right, outer_right, total">
                            <value>center</value>
                        </position>
                        <energy_share description="Share of this tanks energy in relation to required mission energy (of same energy carrier). Only relevant for liquid hydrogen tanks. Equals 0.0 for kerosene tanks.">
                            <value>0.0</value>
                            <unit>1</unit>
                            <lower_boundary>0.0</lower_boundary>
                            <upper_boundary>1.0</upper_boundary>
                        </energy_share>
                    </tank>
                    <tank ID="4" description="Trim tank">
                        <energy_carrier_ID description="see energy carrier specification node">
                            <value>0</value>
                            <unit>1</unit>
                            <lower_boundary>0</lower_boundary>
                            <upper_boundary>5</upper_boundary>
                        </energy_carrier_ID>
                        <location description="Component where the tank is located: fuselage, wing, horizontal_stabilizer">
                            <value>horizontal_stabilizer</value>
                        </location>
                        <position description="Position of tank in location: tailcone, rear, front, top, bottom, center, inner_left, outer_left, inner_right, outer_right, total">
                            <value>total</value>
                        </position>
                        <energy_share description="Share of this tanks energy in relation to required mission energy (of same energy carrier). Only relevant for liquid hydrogen tanks. Equals 0.0 for kerosene tanks.">
                            <value>0.0</value>
                            <unit>1</unit>
                            <lower_boundary>0.0</lower_boundary>
                            <upper_boundary>1.0</upper_boundary>
                        </energy_share>
                    </tank>
                </tank_definition>

Background: We made the assumption that if the wing has no kink, there are only three tanks in the wing (inner_left, inner_right, and center).

However, it is interesting that it seems to work with your configuration where you have only deleted the additional tanks.

I guess I need to change the tank definitions. I deleted now trim tank, additional tank, and outer wing tanks - now I got a new one: 2024-12-05 - 16:38:27,413: TOOL_OUT - 2024-12-05 16:38:26,768 - CRITICAL - Error:The value of the parameter z = 17.62689411 exceeds the given upper boundary of 5. Program aborted! (tank_design@UNICADOworkflow_2024-12-05_16:37:57_08) CSMR-2020.xml

This is kind of a "Folgefehler" since the wing z position is way too high.

Ah, I need to pull the new wing design then due to the changes in !54 (merged). Will test it tomorrow morning and let you now then

Yep, okay. Thanks!

I tested and approved

added 2 commits

• ea8562a4 - - Deleted unnecessary code
• 4f84d262 - - Deleted some unnecessary code

Compare with previous version

approved this merge request

merged

mentioned in commit 3b28881f