Skip to content
Snippets Groups Projects

Fix/system issues from parameter studies

Merged Ellen Seabrooke requested to merge fix/system_issues_from_parameter_studies into main

Fix issues discovered in systems_design through parameter studies

Description

Fixes several small issues discovered through the parameter studies:

  1. systems_design uses the landing gear mass from the acxml to calculate the power requirement of the landing gear actuation. When this mass is not available, systems design estimates a landing gear mass but that is not written to any output. Thus, the scaling factor in the config was unnecessary. It is removed and comments are added to the code to clarify this.
  2. the variable hydraulic pressure and a related function are removed since these are not used. Thus, changing the hydraulic pressure had no effect.
  3. corrects the switch for using a default actuator in the flight control systems. It is now read correctly and can be used.
  4. boundaries are added in the config for efficiency factors and the parameters of relative maximum power since these only work in certain ranges.
  5. remove unused parameter "heat_per_light_length"
  6. "off_on_takeoff" switch of the ECS was not doing anything because the corresponding mission step names were incorrect in the code. These are now corrected.
  7. Avionics bay location was not set/changed correctly according to config settings because the payload tube reference point was wrong. Reading of this point is now fixed.
  8. The wrong wing reference point was used to calculate the system center of gravity (for those systems that reference their CoG to the wing). Because of that the CoG of the systems was too forward. Fixing this issue moves the system CoG considerably backward. @Moritz.barnert @Florian.Schueltke we should discuss if this is correct now.

Related Issue(s)

  • Fixes issues discovered in parameter studies of systems_design (Issue#130)

Screenshots/Logs

N.A.

Testing Instructions

  1. Change the following config settings and check if you get the expected result:
Setting Expected Result
/module_configuration_file/program_settings/systems_constants/environmental_control_system/off_on_take_off/value If set to true, the bleed air power requirement during the take-off segments of the mission (segment one) should be 0. Check in this file: ../reporting/plots/csv_files/systems_design_design_mission_power_ATA-21_plot.csv
/module_configuration_file/program_settings/systems_constants/flight_controls/ailerons/default_actuator_architecture_switch/value If set to true, changing values in /module_configuration_file/program_settings/systems_constants/flight_controls/ailerons/default_actuator_architecture will affect the mass of ATA27 (flight control system: /aircraft_exchange_file/component_design/systems/specific/geometry/mass_properties/flight_controls/value) in the acxml. If it is set to false, changes in the default actuator architecture will have no effect.
/module_configuration_file/program_settings/systems_constants/avionics/location_of_aviationics_bay/value Changing the avionics bay location will move the systems center of gravity slightly (systems CoG moves forward with setting 0->2->1).
  1. Check if the systems CoG now behaves as expected in the workflow.

Developer Checklist

  • Code has been tested locally and/or in pipeline.
  • Merge conflicts resolved with the target branch.
Edited by Ellen Seabrooke

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading