Fix fuel factors and adapt convergence criteria for m0 calculation
Fix fuel factors and adapt convergence criteria for m0 calculation
Description
The fuel factor for kerosene and hydrogen in the mass calculation where switched. In combination with high fuel fractions this led to the iteration not converging. The higher fuel factor should not be a problem for hydrogn aircraft since the mass fraction calculation is also different for hydrogen and will lead to lower fuel fractions.
Testing Instructions
- Test fix in workflow for LR aircraft
- Initial sizing should now finish instead of being stuck
Developer Checklist
-
Code has been tested locally and/or in pipeline. -
(if applicable) documentation updated. -
(if applicable) impact of new dependencies reviewed and included in project. -
Merge conflicts resolved with the target branch.
Merge request reports
Activity
added moduleinitial_sizing typebug labels
requested review from @johannes.schneider and @AndiGob
assigned to @ellen.seabrooke
enabled an automatic merge when all merge checks for 914a5933 pass
mentioned in merge request !242 (merged)
removed review request for @johannes.schneider
requested review from @johannes.schneider
mentioned in commit cd219fb4
Please register or sign in to reply