Skip to content
Snippets Groups Projects

Fix fuel factors and adapt convergence criteria for m0 calculation

Merged Ellen Seabrooke requested to merge fix/initial_sizing_m0_estimation into main

Fix fuel factors and adapt convergence criteria for m0 calculation

Description

The fuel factor for kerosene and hydrogen in the mass calculation where switched. In combination with high fuel fractions this led to the iteration not converging. The higher fuel factor should not be a problem for hydrogn aircraft since the mass fraction calculation is also different for hydrogen and will lead to lower fuel fractions.

Testing Instructions

  1. Test fix in workflow for LR aircraft
  2. Initial sizing should now finish instead of being stuck

Developer Checklist

  • Code has been tested locally and/or in pipeline.
  • (if applicable) documentation updated.
  • (if applicable) impact of new dependencies reviewed and included in project.
  • Merge conflicts resolved with the target branch.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading