Validate parameters, when sending reply messages
The routine, that answers GetValueRequests with a GetValueReply closes the pika connection with this message:
Channel is closed: Stream connection lost: AssertionError('A non-string value was supplied for self.routing_key')
if the GetValueRequest doesn't specifiy replyToEndpoint
. For me, this message is rather cryptic. It would be better to check the message for this value and in case it is not available, return a proper error message and not publish the message.
Anyway, why is replyToEndpoint
optional for GetValueRequests in the first place? Without this information, the target is unknown. I think, ServiceRequests will have the problems.