- enabled evaluation of multiple dataframes

c845f434 · Hafiz Emin Kosar · 65ecf91f · c845f434 · c845f434
Commit c845f434 authored 4 years ago by Hafiz Emin Kosar
--- a/docs/source/examples/RWTH Evaluation.ipynb
+++ b/docs/source/examples/RWTH Evaluation.ipynb
@@ -15,11 +15,11 @@
   "source": [
    "from rwth_nb.misc.feedback import RWTHFeedbackCollector\n",
    "\n",
-    "path_to_folder = './Feedbacks' # path to folder with feedback json files\n",
+    "path_to_folder = './Feedbacks/FeedbackV6' # path to folder with feedback json files\n",
    "\n",
-    "collector = RWTHFeedbackCollector(path_to_folder)\n",
-    "data = collector.get_all() # get feedback for all notebooks\n",
-    "data"
+    "collector = RWTHFeedbackCollector()\n",
+    "data_v6 = collector.get_all('./Feedbacks/FeedbackV6') # get feedback for all notebooks\n",
+    "data_v7 = collector.get_all('./Feedbacks/FeedbackV7')"
   ]
  },
  {

 %% Cell type:markdown id: tags:

 # Collection

 %% Cell type:code id: tags:

 ``` python
 from rwth_nb.misc.feedback import RWTHFeedbackCollector

-path_to_folder = './Feedbacks' # path to folder with feedback json files
+path_to_folder = './Feedbacks/FeedbackV6' # path to folder with feedback json files

-collector = RWTHFeedbackCollector(path_to_folder)
-data = collector.get_all() # get feedback for all notebooks
-data
+collector = RWTHFeedbackCollector()
+data_v6 = collector.get_all('./Feedbacks/FeedbackV6') # get feedback for all notebooks
+data_v7 = collector.get_all('./Feedbacks/FeedbackV7')
 ```

 %% Cell type:markdown id: tags:

 # Evaluation

 %% Cell type:code id: tags:

 ``` python
 %matplotlib widget

 from rwth_nb.misc.feedback import RWTHFeedbackEvaluator

 eva = RWTHFeedbackEvaluator(data)  # collect feedback data using rwth_nb.misc.feedback.RWTHFeedbackCollector first
 eva.evaluate(lang='de')
 ```

--- a/rwth_nb/misc/feedback.py
+++ b/rwth_nb/misc/feedback.py
@@ -507,6 +507,8 @@ class RWTHFeedbackEvaluator:
            list of ids of the free text option answers in the dataframe
            answers identified by those ids are inserted into a list
        """
+        self.data = pd.concat(data, axis=1) if isinstance(data, list) else data
+
        likert_scale = getattr(RWTHFeedback, f'feedback_scale_options_{lang}')

        scale_options = scale_options