Skip to content
Snippets Groups Projects

Merge request for new application profile: HPC CFD Simulation

Merge request created by Angel Sosa Rodriguez, angelsr42@outlook.com, created at 26.07.2024 17:13:19

Note: the Review can be carried out either by checking the index.ttl file under the changes tab or by copy-and-pasting the content of the file into the AIMS Frontend

  • Copy and paste code into AIMS Frontend. Check the form using under the metadata-form button. Does everything render correctly and do all the fields work?
  • Do the title and description match
  • Is there an English and German version of the title and description? (English is OK, but bi-lingual is preferred.)
  • Are various datatypes used? (If applicable, in some cases, only using string is entirely appropriate.)
  • Does each field have a description?
  • If pre-defined terms are used, do they make sense? (broadly speaking, e.g., dcterms:author is not used for a field named "Device".)
  • Does sh:targetClass URL match the base URL? (Applies in most but not all cases.)
  • If the base URL (line one in index.ttl) contains the GUID such as https://purl.org/coscine/ap/{GUID}/, modify this to contain the name of the profile and, if required, the grouping: https://purl.org/coscine/ap/{profileName}/ or https://purl.org/coscine/ap/{group}/{profileName}/
    • Change any other instances of the base URL to match.
  • Deploy on DSP-10 by clicking the arrows in the pipeline box at the top of the merge request–just under the the reactions. (add label accordingly when done)
  • Test on DSP-10 by creating a resource with the application profile and adding a file/linked data to the resource on the web interface (add label accordingly when done). Does everything render correctly and do all the fields work?
  • If applicable, contact submitter via service desk ticket (check box here and add "waiting" label to request).
  • Once review is complete, comment and tag Petar and Benedikt to approve and merge

For more details, see the documentation.

Edited by Nicole Parks

Merge request reports

Pipeline #1410434 passed

Pipeline passed for a5abb9b0 on Request/3e48954c-9a3c-4139-a097-700ae54cd495

Merged by Nicole ParksNicole Parks 5 months ago (Jul 31, 2024 1:08pm UTC)

Loading

Pipeline #1410533 skipped

Pipeline skipped for cee937f1 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicole Parks marked the checklist item Copy and paste code into AIMS Frontend. Check the form using under the metadata-form button. Does everything render correctly and do all the fields work? as completed

    marked the checklist item Copy and paste code into AIMS Frontend. Check the form using under the metadata-form button. Does everything render correctly and do all the fields work? as completed

  • Nicole Parks marked the checklist item Do the title and description match as completed

    marked the checklist item Do the title and description match as completed

  • Nicole Parks marked the checklist item Is there an English and German version of the title and description? (English is OK, but bi-lingual is preferred.) as completed

    marked the checklist item Is there an English and German version of the title and description? (English is OK, but bi-lingual is preferred.) as completed

  • Nicole Parks marked the checklist item Are various datatypes used? (If applicable, in some cases, only using string is entirely appropriate.) as completed

    marked the checklist item Are various datatypes used? (If applicable, in some cases, only using string is entirely appropriate.) as completed

  • Nicole Parks marked the checklist item Does each field have a description? as completed

    marked the checklist item Does each field have a description? as completed

  • Nicole Parks marked the checklist item If pre-defined terms are used, do they make sense? (broadly speaking, e.g., dcterms:author is not used for a field named "Device".) as completed

    marked the checklist item If pre-defined terms are used, do they make sense? (broadly speaking, e.g., dcterms:author is not used for a field named "Device".) as completed

  • Nicole Parks marked the checklist item Does sh:targetClass URL match the base URL? (Applies in most but not all cases.) as completed

    marked the checklist item Does sh:targetClass URL match the base URL? (Applies in most but not all cases.) as completed

  • Nicole Parks marked the checklist item If the base URL (line one in index.ttl) contains the GUID such as https://purl.org/coscine/ap/{GUID}/, modify this to contain the name of the profile and, if required, the grouping: https://purl.org/coscine/ap/{profileName}/ or https://purl.org/coscine/ap/{group}/{profileName}/ as completed

    marked the checklist item If the base URL (line one in index.ttl) contains the GUID such as https://purl.org/coscine/ap/{GUID}/, modify this to contain the name of the profile and, if required, the grouping: https://purl.org/coscine/ap/{profileName}/ or https://purl.org/coscine/ap/{group}/{profileName}/ as completed

  • Nicole Parks marked the checklist item Does sh:targetClass URL match the base URL? (Applies in most but not all cases.) as incomplete

    marked the checklist item Does sh:targetClass URL match the base URL? (Applies in most but not all cases.) as incomplete

  • Nicole Parks added 1 commit

    added 1 commit

    Compare with previous version

  • Nicole Parks marked the checklist item Deploy on DSP-10 by clicking the arrows in the pipeline box at the top of the merge request–just under the the reactions. (add label accordingly when done) as completed

    marked the checklist item Deploy on DSP-10 by clicking the arrows in the pipeline box at the top of the merge request–just under the the reactions. (add label accordingly when done) as completed

  • Nicole Parks marked the checklist item Test on DSP-10 by creating a resource with the application profile and adding a file/linked data to the resource on the web interface (add label accordingly when done). Does everything render correctly and do all the fields work? as completed

    marked the checklist item Test on DSP-10 by creating a resource with the application profile and adding a file/linked data to the resource on the web interface (add label accordingly when done). Does everything render correctly and do all the fields work? as completed

  • @petar.hristov this profile looks good to me, it also deployed to D-SP10, but I am getting warnings on the pipeline. Can you check before we merge?

  • added Waiting label

  • Notified submitter for possible delay via service desk ticket.

  • Nicole Parks marked the checklist item If applicable, contact submitter via service desk ticket (check box here and add "waiting" label to request). as completed

    marked the checklist item If applicable, contact submitter via service desk ticket (check box here and add "waiting" label to request). as completed

  • removed Waiting label

  • All good, merging.

  • Nicole Parks approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading