Skip to content
Snippets Groups Projects

Fix metadata loading upon `Resource.objects()`

Closed Niklas Siemer requested to merge dev_nsiemer_res_objcs_meta into master
1 unresolved thread

Since !12 (closed) is most probably not enough, I now simply allow for the new pattern to match.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I think this is superfluous now - the metadata duplicates seem to have vanished and I just added your f"/{path}/@type=metadata" in key to the method, with a minor adjustment of quoting the path, because certain symbols outside of ascii range needed to be escaped.

    • Yes, I saw your changes on the master :) and I just did not stop to close this PR xD Thanks for fixing the issue! One thing - I would like to see also your changes go through a PR, i.e. to come from an development branch and to be merged in. This way, I am 1) alerted before changes are merged and later released and 2) it is easier to follow what has changed. (The last diff looks like a full rewrite of the resource.py file)

    • I hope the last commits weren't a full rewrite of the resource.py file, because I just changed a few lines or so, but I think I can manage the additional work with the dev branch stuff (given that I don't forget about it). :sweat_smile: Time to follow "industry best practices" I guess... xD

    • No, I figured what lines actually had changes pretty fast (since I expected these lines to change :thumbsup:) I do not know why they all got marked here in the diff... Thanks a lot for considering :) One big advantage: on your private dev branch force push is not a problem :innocent:

    • Finally! Force pushing to master without consequences! My dreams have come true!
      Me
      :clown: :clown: :clown: :clown: :clown: :clown: :clown: :clown:

      Edited by Romin
    • Please register or sign in to reply
  • closed

Please register or sign in to reply
Loading