Skip to content
Snippets Groups Projects

Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Select target project
No results found
Select Git revision
  • Fix/xxxx-indexOutOfRange
  • Fix/xxxx-minorFixes
  • Fix/xxxx-organization
  • Fix/xxxx-wrap
  • Hotfix/2332-userInstitutesInReporting
  • Hotfix/2388-sensitive
  • Hotfix/3115-userReportingEmpty
  • Hotfix/3115-userReportingEmpty2
  • Hotfix/xxxx-rors
  • Issue/2181-kpiGeneratorBase
  • Issue/2182-kpiGeneratorUser
  • Issue/2183-kpiGeneratorResource
  • Issue/2184-kpiGeneratorProject
  • Issue/2185-kpiGeneratorAP
  • Issue/2186-systemStatusReporting
  • Issue/2283-activityFix
  • Issue/2304-virtuosoRoars
  • Issue/2330-fixNaNQuotainAdmin
  • Issue/2432-publicationKpi
  • Issue/2492-respOrg
  • Issue/2518-docs
  • Issue/2568-betterLogging
  • Issue/2666-adminCronjobs
  • Issue/2666-adminCronjobs-theSequal
  • Issue/2847-reporting
  • Issue/2850-removeGrantId
  • Issue/2982-kpiDataPub
  • Issue/3005-kpiReportingBroken
  • Issue/3073-kpi
  • Issue/3142-kpiGenerator
  • dev
  • gitkeep
  • main
  • v0.1.0
  • v0.1.1
  • v0.1.10
  • v0.1.11
  • v0.1.12
  • v0.1.13
  • v0.1.14
  • v0.1.15
  • v0.1.16
  • v0.1.17
  • v0.1.18
  • v0.1.19
  • v0.1.2
  • v0.1.20
  • v0.1.21
  • v0.1.22
  • v0.1.23
  • v0.1.3
  • v0.1.4
  • v0.1.5
  • v0.1.6
  • v0.1.7
  • v0.1.8
  • v0.1.9
  • v1.0.1
  • v1.0.2
  • v1.0.3
  • v1.0.4
  • v1.0.5
  • v1.0.6
  • v1.0.7
  • v1.0.8
  • v1.0.9
  • v1.1.0
  • v1.1.1
  • v1.2.0
  • v1.2.1
  • v1.2.10
  • v1.2.2
  • v1.2.3
  • v1.2.4
  • v1.2.5
  • v1.2.6
  • v1.2.7
  • v1.2.8
  • v1.2.9
79 results

Target

Select target project
  • coscine/backend/scripts/kpi-generator
1 result
Select Git revision
  • Fix/xxxx-indexOutOfRange
  • Fix/xxxx-minorFixes
  • Fix/xxxx-organization
  • Fix/xxxx-wrap
  • Hotfix/2332-userInstitutesInReporting
  • Hotfix/2388-sensitive
  • Hotfix/3115-userReportingEmpty
  • Hotfix/3115-userReportingEmpty2
  • Hotfix/xxxx-rors
  • Issue/2181-kpiGeneratorBase
  • Issue/2182-kpiGeneratorUser
  • Issue/2183-kpiGeneratorResource
  • Issue/2184-kpiGeneratorProject
  • Issue/2185-kpiGeneratorAP
  • Issue/2186-systemStatusReporting
  • Issue/2283-activityFix
  • Issue/2304-virtuosoRoars
  • Issue/2330-fixNaNQuotainAdmin
  • Issue/2432-publicationKpi
  • Issue/2492-respOrg
  • Issue/2518-docs
  • Issue/2568-betterLogging
  • Issue/2666-adminCronjobs
  • Issue/2666-adminCronjobs-theSequal
  • Issue/2847-reporting
  • Issue/2850-removeGrantId
  • Issue/2982-kpiDataPub
  • Issue/3005-kpiReportingBroken
  • Issue/3073-kpi
  • Issue/3142-kpiGenerator
  • dev
  • gitkeep
  • main
  • v0.1.0
  • v0.1.1
  • v0.1.10
  • v0.1.11
  • v0.1.12
  • v0.1.13
  • v0.1.14
  • v0.1.15
  • v0.1.16
  • v0.1.17
  • v0.1.18
  • v0.1.19
  • v0.1.2
  • v0.1.20
  • v0.1.21
  • v0.1.22
  • v0.1.23
  • v0.1.3
  • v0.1.4
  • v0.1.5
  • v0.1.6
  • v0.1.7
  • v0.1.8
  • v0.1.9
  • v1.0.1
  • v1.0.2
  • v1.0.3
  • v1.0.4
  • v1.0.5
  • v1.0.6
  • v1.0.7
  • v1.0.8
  • v1.0.9
  • v1.1.0
  • v1.1.1
  • v1.2.0
  • v1.2.1
  • v1.2.10
  • v1.2.2
  • v1.2.3
  • v1.2.4
  • v1.2.5
  • v1.2.6
  • v1.2.7
  • v1.2.8
  • v1.2.9
79 results
Show changes
Commits on Source (2)
......@@ -7,7 +7,7 @@
<AssemblyName>Coscine.KpiGenerator</AssemblyName>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<Version>0.1.11</Version>
<Version>0.1.12</Version>
</PropertyGroup>
<PropertyGroup>
......
......@@ -15,7 +15,7 @@ namespace Coscine.KpiGenerator;
public class Program
{
private static ILogger _logger = null!;
private static ILogger<Program> _logger = null!;
public static int Main(string[] args)
{
......@@ -34,12 +34,12 @@ public class Program
SystemReportingOptions
>(args)
.MapResult(
(CompleteReportingOptions options) => new CompleteReporting(SanitizeOptions(options), _logger).Run(),
(ProjectReportingOptions options) => new ProjectReporting(SanitizeOptions(options), _logger).Run(),
(ResourceReportingOptions options) => new ResourceReporting(SanitizeOptions(options), _logger).Run(),
(UserReportingOptions options) => new UserReporting(SanitizeOptions(options), _logger).Run(),
(ApplicationProfileReportingOptions options) => new ApplicationProfileReporting(SanitizeOptions(options), _logger).Run(),
(SystemReportingOptions options) => new SystemReporting(SanitizeOptions(options), _logger).Run(),
(CompleteReportingOptions options) => new CompleteReporting(SanitizeOptions(options)).Run(),
(ProjectReportingOptions options) => new ProjectReporting(SanitizeOptions(options)).Run(),
(ResourceReportingOptions options) => new ResourceReporting(SanitizeOptions(options)).Run(),
(UserReportingOptions options) => new UserReporting(SanitizeOptions(options)).Run(),
(ApplicationProfileReportingOptions options) => new ApplicationProfileReporting(SanitizeOptions(options)).Run(),
(SystemReportingOptions options) => new SystemReporting(SanitizeOptions(options)).Run(),
_ => false);
if (result)
{
......
......@@ -5,10 +5,10 @@ using GitLabApiClient;
using GitLabApiClient.Models.Branches.Requests;
using GitLabApiClient.Models.Commits.Requests.CreateCommitRequest;
using Microsoft.Extensions.Logging;
using NLog.Extensions.Logging;
using Polly;
using System.Text;
using System.Web;
using VDS.RDF.Query;
using static KPIGenerator.Utils.CommandLineOptions;
namespace Coscine.KpiGenerator;
......@@ -30,7 +30,7 @@ public abstract class Reporting<O> where O : class
private string ReportingBranch { get; init; }
public string RwthRor { get; init; }
public readonly ILogger _logger = null!;
private readonly ILogger<Reporting<O>> _logger;
public readonly Organization _otherOrganization = new()
{
......@@ -38,7 +38,7 @@ public abstract class Reporting<O> where O : class
RorUrl = "https://ror.org/_other",
};
public Reporting(O options, ILogger logger)
public Reporting(O options)
{
InstanceName = GetType().Name;
Options = options;
......@@ -53,7 +53,7 @@ public abstract class Reporting<O> where O : class
ReportingBranch = Configuration.GetStringAndWait("coscine/local/reporting/branch");
RwthRor = Configuration.GetStringAndWait("coscine/global/organizations/rwth/ror_url");
_logger = logger;
_logger = LoggerFactory.Create(builder => builder.AddNLog()).CreateLogger<Reporting<O>>();
}
public abstract IEnumerable<ReportingFileObject> GenerateReporting();
......@@ -173,7 +173,7 @@ public abstract class Reporting<O> where O : class
else
{
var organizationTriples = WrapRequest(() => RdfStoreConnector.GetLabelForSubject(new Uri(Uri.UnescapeDataString(rorUrl))).ToList());
if (organizationTriples.Any())
if (organizationTriples is not null && organizationTriples.Any())
{
result = new Organization
{
......
using Coscine.KpiGenerator.Utils;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json;
using NLog.Extensions.Logging;
using VDS.RDF.Query;
using static KPIGenerator.Utils.CommandLineOptions;
......@@ -8,9 +9,12 @@ namespace Coscine.KpiGenerator.Reportings.ApplicationProfile;
public class ApplicationProfileReporting : Reporting<ApplicationProfileReportingOptions>
{
public ApplicationProfileReporting(ApplicationProfileReportingOptions options, ILogger _logger) : base(options, _logger)
private readonly ILogger<ApplicationProfileReporting> _logger;
public ApplicationProfileReporting(ApplicationProfileReportingOptions options) : base(options)
{
ReportingFileName = "application_profiles.json";
_logger = LoggerFactory.Create(builder => builder.AddNLog()).CreateLogger<ApplicationProfileReporting>();
}
public override IEnumerable<ReportingFileObject> GenerateReporting()
......
......@@ -5,14 +5,19 @@ using Coscine.KpiGenerator.Reportings.System;
using Coscine.KpiGenerator.Reportings.User;
using Coscine.KpiGenerator.Utils;
using Microsoft.Extensions.Logging;
using NLog.Extensions.Logging;
using static KPIGenerator.Utils.CommandLineOptions;
namespace Coscine.KpiGenerator.Reportings.Complete;
public class CompleteReporting : Reporting<CompleteReportingOptions>
{
public CompleteReporting(CompleteReportingOptions options, ILogger _logger) : base(options, _logger)
{ }
private readonly ILogger<CompleteReporting> _logger;
public CompleteReporting(CompleteReportingOptions options) : base(options)
{
_logger = LoggerFactory.Create(builder => builder.AddNLog()).CreateLogger<CompleteReporting>();
}
public override IEnumerable<ReportingFileObject> GenerateReporting()
{
......@@ -24,7 +29,7 @@ public class CompleteReporting : Reporting<CompleteReportingOptions>
result.AddRange(new ProjectReporting(new ProjectReportingOptions
{
DummyMode = Options.DummyMode
}, _logger).GenerateReporting());
}).GenerateReporting());
}
catch (Exception e)
{
......@@ -38,7 +43,7 @@ public class CompleteReporting : Reporting<CompleteReportingOptions>
result.AddRange(new ResourceReporting(new ResourceReportingOptions
{
DummyMode = Options.DummyMode
}, _logger).GenerateReporting());
}).GenerateReporting());
}
catch (Exception e)
{
......@@ -52,7 +57,7 @@ public class CompleteReporting : Reporting<CompleteReportingOptions>
result.AddRange(new UserReporting(new UserReportingOptions
{
DummyMode = Options.DummyMode
}, _logger).GenerateReporting());
}).GenerateReporting());
}
catch (Exception e)
{
......@@ -66,7 +71,7 @@ public class CompleteReporting : Reporting<CompleteReportingOptions>
result.AddRange(new ApplicationProfileReporting(new ApplicationProfileReportingOptions
{
DummyMode = Options.DummyMode
}, _logger).GenerateReporting());
}).GenerateReporting());
}
catch (Exception e)
{
......@@ -80,7 +85,7 @@ public class CompleteReporting : Reporting<CompleteReportingOptions>
result.AddRange(new SystemReporting(new SystemReportingOptions
{
DummyMode = Options.DummyMode
}, _logger).GenerateReporting());
}).GenerateReporting());
}
catch (Exception e)
{
......
......@@ -5,19 +5,22 @@ using Coscine.KpiGenerator.Utils;
using Coscine.ResourceTypes;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json;
using NLog.Extensions.Logging;
using static KPIGenerator.Utils.CommandLineOptions;
namespace Coscine.KpiGenerator.Reportings.Project;
public class ProjectReporting : Reporting<ProjectReportingOptions>
{
private readonly ILogger<ProjectReporting> _logger;
private readonly ProjectModel _projectModel;
private readonly ResourceModel _resourceModel;
private readonly ProjectRoleModel _projectRoleModel;
private readonly ProjectQuotaModel _projectQuotaModel;
private readonly ResourceTypeModel _resourceTypeModel;
public ProjectReporting(ProjectReportingOptions options, ILogger _logger) : base(options, _logger)
public ProjectReporting(ProjectReportingOptions options) : base(options)
{
ReportingFileName = "projects.json";
_projectModel = new ProjectModel();
......@@ -25,6 +28,7 @@ public class ProjectReporting : Reporting<ProjectReportingOptions>
_projectQuotaModel = new ProjectQuotaModel();
_resourceModel = new ResourceModel();
_resourceTypeModel = new ResourceTypeModel();
_logger = LoggerFactory.Create(builder => builder.AddNLog()).CreateLogger<ProjectReporting>();
}
public override IEnumerable<ReportingFileObject> GenerateReporting()
......
......@@ -5,22 +5,26 @@ using Coscine.ResourceTypes;
using Coscine.ResourceTypes.Base;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json;
using NLog.Extensions.Logging;
using static KPIGenerator.Utils.CommandLineOptions;
namespace Coscine.KpiGenerator.Reportings.Resource;
public class ResourceReporting : Reporting<ResourceReportingOptions>
{
private readonly ILogger<ResourceReporting> _logger;
private readonly ResourceModel _resourceModel;
private readonly ProjectModel _projectModel;
private readonly ProjectResourceModel _projectResourceModel;
public ResourceReporting(ResourceReportingOptions options, ILogger _logger) : base(options, _logger)
public ResourceReporting(ResourceReportingOptions options) : base(options)
{
ReportingFileName = "resources.json";
_resourceModel = new ResourceModel();
_projectModel = new ProjectModel();
_projectResourceModel = new ProjectResourceModel();
_logger = LoggerFactory.Create(builder => builder.AddNLog()).CreateLogger<ResourceReporting>();
}
public override IEnumerable<ReportingFileObject> GenerateReporting()
......
......@@ -2,6 +2,7 @@
using Coscine.KpiGenerator.Utils;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json;
using NLog.Extensions.Logging;
using System.Net.Http.Headers;
using System.Text;
using static KPIGenerator.Utils.CommandLineOptions;
......@@ -10,12 +11,15 @@ namespace Coscine.KpiGenerator.Reportings.System;
public class SystemReporting : Reporting<SystemReportingOptions>
{
private readonly ILogger<SystemReporting> _logger;
private readonly ConsulConfiguration _configuration;
public SystemReporting(SystemReportingOptions options, ILogger _logger) : base(options, _logger)
public SystemReporting(SystemReportingOptions options) : base(options)
{
ReportingFileName = "system_status.json";
_configuration = new ConsulConfiguration();
_logger = LoggerFactory.Create(builder => builder.AddNLog()).CreateLogger<SystemReporting>();
}
public override IEnumerable<ReportingFileObject> GenerateReporting()
......
......@@ -4,6 +4,7 @@ using Coscine.KpiGenerator.Utils;
using Coscine.Metadata;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json;
using NLog.Extensions.Logging;
using VDS.RDF.Query;
using static KPIGenerator.Utils.CommandLineOptions;
......@@ -11,6 +12,8 @@ namespace Coscine.KpiGenerator.Reportings.User;
public class UserReporting : Reporting<UserReportingOptions>
{
private readonly ILogger<UserReporting> _logger;
private readonly ExternalAuthenticatorModel _externalAuthenticatorModel;
private readonly ExternalIdModel _externalIdModel;
private readonly ProjectRoleModel _projectRoleModel;
......@@ -20,7 +23,7 @@ public class UserReporting : Reporting<UserReportingOptions>
private readonly LogModel _logModel;
private readonly IEnumerable<ExternalAuthenticator> _loginProviders;
public UserReporting(UserReportingOptions options, ILogger _logger) : base(options, _logger)
public UserReporting(UserReportingOptions options) : base(options)
{
ReportingFileName = "users.json";
_externalAuthenticatorModel = new ExternalAuthenticatorModel();
......@@ -32,6 +35,7 @@ public class UserReporting : Reporting<UserReportingOptions>
_logModel = new LogModel();
_loginProviders = _externalAuthenticatorModel.GetAll();
_logger = LoggerFactory.Create(builder => builder.AddNLog()).CreateLogger<UserReporting>();
}
public override IEnumerable<ReportingFileObject> GenerateReporting()
......