Topic/180 sub pages

coscine/issues#180

src/Project/Controllers/ProjectController.cs

@@ -7,7 +7,6 @@ using Coscine.ApiCommons;
 using Coscine.ApiCommons.Exceptions;
 using Coscine.ApiCommons.Factories;
 using Microsoft.AspNetCore.Mvc;
-using Microsoft.SharePoint;
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -17,16 +16,18 @@ namespace Coscine.Api.Project.Controllers
     public class ProjectController : Controller
     {
         private readonly Authenticator _authenticator;
-        private readonly List<IProjectAction> projectActions;
+        private readonly List<IProjectAction> _projectActions;
+        private readonly ProjectModel _projectModel;
 
         public ProjectController()
         {
             _authenticator = new Authenticator(this, Program.Configuration);
-            projectActions = new List<IProjectAction>()
+            _projectActions = new List<IProjectAction>()
             {
                 new PIDAction(),
                 new SharePointSiteAction()
             };
+            _projectModel = new ProjectModel();
         }
 
         [Route("[controller]")]
@@ -34,8 +35,7 @@ namespace Coscine.Api.Project.Controllers
         {
             return Ok(_authenticator.ValidateAndExecute((user) =>
             {
-                ProjectModel projectModel = new ProjectModel();
-                return projectModel.GetAllWhere((project) =>                
+                return _projectModel.GetAllWhere((project) =>                
                     (from projectRole in project.ProjectRolesProjectIdIds
                             where projectRole.User == user
                             && projectRole.Role.DisplayName == "Owner"
@@ -49,9 +49,15 @@ namespace Coscine.Api.Project.Controllers
         {
             return Ok(_authenticator.ValidateAndExecute((user) =>
             {
-                ProjectModel projectModel = new ProjectModel();
-                var project = projectModel.GetById(Guid.Parse(id));
-                return new ProjectObject(project.Id, project.Description, project.DisplayName, project.Organization, project.StartDate, project.EndDate, project.Keywords);
+                var project = _projectModel.GetById(Guid.Parse(id));
+                if (_projectModel.CanSeeProject(user, project))
+                {
+                    return new ProjectObject(project.Id, project.Description, project.DisplayName, project.Organization, project.StartDate, project.EndDate, project.Keywords);
+                }
+                else
+                {
+                    throw new UnauthorizedAccessException("User is not allowed to see given project Id!");
+                }
             }));
         }
 
@@ -61,11 +67,10 @@ namespace Coscine.Api.Project.Controllers
             return Ok(_authenticator.ValidateAndExecute((user) =>
             {
                 ProjectObject projectObject = ObjectFactory<ProjectObject>.DeserializeFromStream(Request.Body);
-                ProjectModel projectModel = new ProjectModel();
-                var project = projectModel.GetById(Guid.Parse(id));
-                if(projectModel.OwnsProject(user, project))
+                var project = _projectModel.GetById(Guid.Parse(id));
+                if(_projectModel.OwnsProject(user, project))
                 {
-                    return projectModel.UpdateByObject(project, projectObject);
+                    return _projectModel.UpdateByObject(project, projectObject);
                 }
                 else
                 {
@@ -80,8 +85,15 @@ namespace Coscine.Api.Project.Controllers
             return base.Ok(_authenticator.ValidateAndExecute((user) =>
             {
                 ProjectObject projectObject = ObjectFactory<ProjectObject>.DeserializeFromStream(Request.Body);
-                ProjectModel projectModel = new ProjectModel();
-                var project = projectModel.StoreFromObject(projectObject, user);
+                var project = _projectModel.StoreFromObject(projectObject, user);
+
+                if (projectObject.ParentId != null 
+                    && projectObject.ParentId != new Guid()
+                    && _projectModel.OwnsProject(user, _projectModel.GetById(projectObject.ParentId))) // for now, only an owner can add subprojects to projects
+                {
+                    SubProjectModel subProjectModel = new SubProjectModel();
+                    subProjectModel.LinkSubProject(projectObject.ParentId, project.Id);
+                }
 
                 FireEvents((projectAction, projectEventArgs) => projectAction.OnProjectCreate(project, projectEventArgs));
 
@@ -91,24 +103,10 @@ namespace Coscine.Api.Project.Controllers
 
         private void FireEvents(Action<IProjectAction, ProjectEventArgs> eventAction)
         {
-            var sharePointSite = Request.Headers["Referer"];
-
-            SPUserToken systemAccount = SPUserToken.SystemAccount;
-            using (SPSite site = new SPSite(sharePointSite, systemAccount))
+            ProjectEventArgs projectEventArgs = new ProjectEventArgs(Program.Configuration, new object[0]);
+            foreach (var projectAction in _projectActions)
             {
-                using (SPWeb web = site.OpenWeb())
-                {
-                    SPContext context = SPContext.GetContext(web);
-                    object[] args = new object[]
-                    {
-                        context
-                    };
-                    ProjectEventArgs projectEventArgs = new ProjectEventArgs(Program.Configuration, args);
-                    foreach (var projectAction in projectActions)
-                    {
-                        eventAction(projectAction, projectEventArgs);
-                    }
-                }
+                eventAction(projectAction, projectEventArgs);
             }
         }
     }