Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
P
Project
Manage
Activity
Members
Labels
Plan
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
Coscine
backend
apis
Project
Commits
31e8310c
Commit
31e8310c
authored
5 years ago
by
Benedikt Heinrichs
Browse files
Options
Downloads
Patches
Plain Diff
Fix: Last Owner is not able to be deleted (coscine/issues#251)
parent
c44d1dc2
No related branches found
No related tags found
1 merge request
!15
Fix: Last Owner is not able to be deleted (coscine/issues#251)
Changes
2
Pipelines
1
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/Project/Controllers/ProjectRoleController.cs
+2
-0
2 additions, 0 deletions
src/Project/Controllers/ProjectRoleController.cs
src/Project/Models/ProjectRoleModel.cs
+23
-2
23 additions, 2 deletions
src/Project/Models/ProjectRoleModel.cs
with
25 additions
and
2 deletions
src/Project/Controllers/ProjectRoleController.cs
+
2
−
0
View file @
31e8310c
...
@@ -85,6 +85,8 @@ namespace Coscine.Api.Project.Controllers
...
@@ -85,6 +85,8 @@ namespace Coscine.Api.Project.Controllers
ProjectModel
projectModel
=
new
ProjectModel
();
ProjectModel
projectModel
=
new
ProjectModel
();
if
(
projectModel
.
OwnsProject
(
user
,
projectModel
.
GetById
(
projectId
)))
if
(
projectModel
.
OwnsProject
(
user
,
projectModel
.
GetById
(
projectId
)))
{
{
_projectRoleModel
.
CheckIfLastOwnerWillBeRemoved
(
roleId
,
projectId
);
return
_projectRoleModel
.
Delete
(
_projectRoleModel
.
GetWhere
((
projectRole
)
=>
return
_projectRoleModel
.
Delete
(
_projectRoleModel
.
GetWhere
((
projectRole
)
=>
projectRole
.
ProjectId
==
projectId
projectRole
.
ProjectId
==
projectId
&&
projectRole
.
UserId
==
userId
&&
projectRole
.
UserId
==
userId
...
...
This diff is collapsed.
Click to expand it.
src/Project/Models/ProjectRoleModel.cs
+
23
−
2
View file @
31e8310c
using
Coscine.Api.Project.ReturnObjects
;
using
Coscine.Api.Project.ReturnObjects
;
using
Coscine.ApiCommons.Exceptions
;
using
Coscine.ApiCommons.Models
;
using
Coscine.ApiCommons.Models
;
using
Coscine.Database.Model
;
using
Coscine.Database.Model
;
using
LinqToDB
;
using
LinqToDB
;
...
@@ -19,10 +20,12 @@ namespace Coscine.Api.Project.Models
...
@@ -19,10 +20,12 @@ namespace Coscine.Api.Project.Models
{
{
// Remove existing roles if they exist
// Remove existing roles if they exist
var
existingRoles
=
GetAllWhere
((
dbProjectRole
)
=>
dbProjectRole
.
ProjectId
==
projectRoleObject
.
ProjectId
&&
dbProjectRole
.
UserId
==
projectRoleObject
.
User
.
Id
);
var
existingRoles
=
GetAllWhere
((
dbProjectRole
)
=>
dbProjectRole
.
ProjectId
==
projectRoleObject
.
ProjectId
&&
dbProjectRole
.
UserId
==
projectRoleObject
.
User
.
Id
);
if
(
existingRoles
.
Count
()
>
0
)
if
(
existingRoles
.
Count
()
>
0
)
{
{
foreach
(
var
role
in
existingRoles
)
foreach
(
var
role
in
existingRoles
)
{
{
CheckIfLastOwnerWillBeRemoved
(
role
.
RoleId
,
projectRoleObject
.
ProjectId
);
Delete
(
role
);
Delete
(
role
);
}
}
}
}
...
@@ -36,6 +39,24 @@ namespace Coscine.Api.Project.Models
...
@@ -36,6 +39,24 @@ namespace Coscine.Api.Project.Models
return
projectRole
;
return
projectRole
;
}
}
public
void
CheckIfLastOwnerWillBeRemoved
(
Guid
roleId
,
Guid
projectId
)
{
RoleModel
roleModel
=
new
RoleModel
();
var
ownerRole
=
roleModel
.
GetOwnerRole
();
if
(
roleId
==
ownerRole
.
Id
)
{
var
moreThanOneOwnerExists
=
GetAllWhere
((
projectRole
)
=>
projectRole
.
ProjectId
==
projectId
&&
projectRole
.
RoleId
==
ownerRole
.
Id
).
Count
()
>
1
;
if
(!
moreThanOneOwnerExists
)
{
throw
new
NotAuthorizedException
(
"The last owner cannot be removed!"
);
}
}
}
public
override
Expression
<
Func
<
ProjectRole
,
Guid
>>
GetIdFromObject
()
public
override
Expression
<
Func
<
ProjectRole
,
Guid
>>
GetIdFromObject
()
{
{
return
databaseObject
=>
databaseObject
.
RelationId
;
return
databaseObject
=>
databaseObject
.
RelationId
;
...
...
This diff is collapsed.
Click to expand it.
Ghost User
@ghost
mentioned in commit
522d7ce9
·
5 years ago
mentioned in commit
522d7ce9
mentioned in commit 522d7ce9a2bd27e3b7f41dea8f9a2fb78e9e09d3
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment