Fix: Removed role id from log call (coscine/issues#2001)

src/Admin/Controllers/AdminController.cs

@@ -34,7 +34,6 @@ namespace Coscine.Api.Admin.Controllers
         private readonly string _adminRole;
         private readonly ResourceModel _resourceModel;
         private readonly ProjectModel _projectModel;
-        private readonly ProjectRoleModel _projectRoleModel;
         private readonly ProjectQuotaModel _projectQuotaModel;
         private readonly ResourceTypeModel _resourceTypeModel;
         private readonly Emitter _emitter;
@@ -56,7 +55,6 @@ namespace Coscine.Api.Admin.Controllers
             _adminRole = "supportAdmin";
             _resourceModel = new ResourceModel();
             _projectModel = new ProjectModel();
-            _projectRoleModel = new ProjectRoleModel();
             _projectQuotaModel = new ProjectQuotaModel();
             _resourceTypeModel = new ResourceTypeModel();
             _emitter = new Emitter(Program.Configuration);
@@ -205,16 +203,17 @@ namespace Coscine.Api.Admin.Controllers
 
             if (Request.Query != null && Request.Query["noanalyticslog"] != "true")
             {
-                var project = _projectModel.GetById(projectQuota.ProjectId);
-                LogAnalyticsAdminProjectQuotaChange(project, user);
+                LogAnalyticsAdminProjectQuotaChange(projectQuota.ProjectId, user);
             }
 
             return NoContent();
         }
 
-        private void LogAnalyticsAdminProjectQuotaChange(Project project, User user)
+        private void LogAnalyticsAdminProjectQuotaChange(Guid projectId, User user)
         {
-            var quotas = _projectQuotaModel.GetAllWhere(x => x.ProjectId == project.Id);
+            try
+            {
+                var quotas = _projectQuotaModel.GetAllWhere(x => x.ProjectId == projectId);
                 var quotaObjects = quotas.Select(x => new ProjectQuotaObject
                 {
                     QuotaId = x.RelationId,
@@ -222,7 +221,7 @@ namespace Coscine.Api.Admin.Controllers
                     Quota = x.Quota,
                     MaxQuota = x.MaxQuota,
                     Used = x.Quota,
-                Allocated = CalculateAllocatedForAll(_resourceTypeModel.GetById(x.ResourceTypeId), project.Id)
+                    Allocated = CalculateAllocatedForAll(_resourceTypeModel.GetById(x.ResourceTypeId), projectId)
                 }).ToList();
 
                 _coscineLogger.AnalyticsLog(
@@ -230,11 +229,16 @@ namespace Coscine.Api.Admin.Controllers
                     {
                         Type = "Action",
                         Operation = "Admin Project Quota Change",
-                    RoleId = _projectRoleModel.GetGetUserRoleForProject(project.Id, user.Id).ToString(),
                         UserId = user.Id.ToString(),
-                    ProjectId = project.Id.ToString(),
+                        ProjectId = projectId.ToString(),
                         QuotaSize = quotaObjects.ConvertAll(x => $"{x.ResourceType}: {x.Allocated}/{x.Used}")
                     });
             }
+#pragma warning disable RCS1075 // Avoid empty catch clause that catches System.Exception.
+            catch (Exception)
+#pragma warning restore RCS1075 // Avoid empty catch clause that catches System.Exception.
+            {
+            }
+        }
     }
 }
\ No newline at end of file