Skip to content

Removed N1s above 100% to adhere to the limits without checking it in every step

Tobias Weckenmannrequested to merge
feature/remove_all_limits into main

Description

When checking the limits from the engine lib in the decks it is visible that we are very close to the 100% N1 setting. With the limits integrated we are never above N1 100%. So, to make the tool more robust, easyer to use and to use less parameters, the N1s above 100% were deleted. THe following advantages will result:

  • The library is usefull for no combustion engines
  • THe tool is faster by a lot (Especially mission and constraints as well as perfromance assessment)
  • The tool is way less complex
  • The library is more robust
  • The library as well as data has a smaller size

Related Issue(s)

  • Resolves #[any other issues]

Other Changes

  • The engine library is adapted for this MR! The limits are no longer in. The two work only with each other

Screenshots/Logs

grafik In the picture you can see the limits of the current engine lib. When comparing the limits themself you can see that we are only slightly above the limits at each point. This was the PW engine.

Same for V2527 grafik grafik

Testing Instructions

  1. Check out the new engine library
  2. checkout the new engines
  3. Compare to the old results (Expected outcome: Slightly lighter engine, not much else)

Developer Checklist

  • Code has been tested locally and/or in pipeline.
  • (if applicable) documentation updated.
  • (if applicable) impact of new dependencies reviewed and included in project.
  • Merge conflicts resolved with the target branch.

Merge request reports