Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • P PI2 View
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PI2
  • PI2 View
  • Issues
  • #3
Closed
Open
Issue created Jan 31, 2019 by Martin Kröning@mkroening🦀Owner

Copy construction of `MapAppAPIWrapper`

When copying a MapAppAPIWrapper, we work on the same instance of MapApp since we copy the pointer.

Instead a new MapApp should be created using the copy constructor, which we have to expose in pi2-view.h. Copy assignment and move construction and assignment should be implemented in a consistent manner.

At the same time we should rename MapAppAPIWrapper to MapAppWrapper since we do not wrap the API itself but the MapApp struct of the API.

Also documentation of the wrapper is missing it should be coherent with the documentation of pi2-view.h.

Edited Jan 31, 2019 by Martin Kröning
Assignee
Assign to
Time tracking