PI2 View issueshttps://git.rwth-aachen.de/pi2/pi2-view/-/issues2021-10-01T11:09:17+02:00https://git.rwth-aachen.de/pi2/pi2-view/-/issues/1Undo Ubuntu 18.04 compatibility changes2021-10-01T11:09:17+02:00Martin Kröningmartin.kroening@eonerc.rwth-aachen.deUndo Ubuntu 18.04 compatibility changesOnce Ubuntu 20.04 is released, we should undo https://git.rwth-aachen.de/pi2/pi2-view/commit/5525f77d9e0ab2ba693828971e79d74013aab9aa as Ubuntu will then include dependencies recent enough to support the features we had to stop using to ...Once Ubuntu 20.04 is released, we should undo https://git.rwth-aachen.de/pi2/pi2-view/commit/5525f77d9e0ab2ba693828971e79d74013aab9aa as Ubuntu will then include dependencies recent enough to support the features we had to stop using to be compatible.2020-06-01https://git.rwth-aachen.de/pi2/pi2-view/-/issues/3Copy construction of `MapAppAPIWrapper`2019-02-04T11:46:52+01:00Martin Kröningmartin.kroening@eonerc.rwth-aachen.deCopy construction of `MapAppAPIWrapper`When copying a `MapAppAPIWrapper`, we work on the same instance of `MapApp` since we copy the pointer.
Instead a new MapApp should be created using the copy constructor, which we have to expose in `pi2-view.h`.
Copy assignment and move ...When copying a `MapAppAPIWrapper`, we work on the same instance of `MapApp` since we copy the pointer.
Instead a new MapApp should be created using the copy constructor, which we have to expose in `pi2-view.h`.
Copy assignment and move construction and assignment should be implemented in a consistent manner.
At the same time we should rename `MapAppAPIWrapper` to `MapAppWrapper` since we do not wrap the API itself but the `MapApp` struct of the API.
Also documentation of the wrapper is missing it should be coherent with the documentation of `pi2-view.h`.https://git.rwth-aachen.de/pi2/pi2-view/-/issues/2Label Name "Duration" might be misleading2019-02-01T13:40:45+01:00David Christian MeierLabel Name "Duration" might be misleadingWhen I was using the API, I was first confused as to what the function setDurationLabel() actually does.
From pi2-demo I concluded it sets the label which shows the passed time, however the name "duration" for this is misleading, as it d...When I was using the API, I was first confused as to what the function setDurationLabel() actually does.
From pi2-demo I concluded it sets the label which shows the passed time, however the name "duration" for this is misleading, as it describes the time the simulation is supposed to run for, when launching pi2-demo from the CL.
I would therefore suggest changing it to "time", or "time passed", to clearly differentiate between the passed simulation time and the total duration of the simulation.