Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
L
load_leveller
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
0
Merge Requests
0
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Test Cases
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Lukas Weber
load_leveller
Commits
816de0ac
Commit
816de0ac
authored
Dec 19, 2019
by
Lukas Weber
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
reenable checking for illegal observable names (containing / and .)
parent
3e3ecf0c
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
3 deletions
+17
-3
src/measurements.h
src/measurements.h
+2
-1
test/meson.build
test/meson.build
+2
-2
test/observable_names.cpp
test/observable_names.cpp
+13
-0
No files found.
src/measurements.h
View file @
816de0ac
...
...
@@ -54,8 +54,9 @@ private:
template
<
class
T
>
void
measurements
::
add
(
const
std
::
string
name
,
T
value
)
{
if
(
observables_
.
count
(
name
)
==
0
)
{
observables_
.
emplace
(
name
,
observable
{
name
,
default_bin_size_
,
value_length
(
value
)}
);
register_observable
(
name
,
default_bin_size_
);
}
observables_
.
at
(
name
).
add
(
value
);
}
}
test/meson.build
View file @
816de0ac
t1 = executable('tests',
['duration_parser.cpp', 'monotone_interpolator.cpp'],
['duration_parser.cpp', 'monotone_interpolator.cpp'
, 'observable_names.cpp'
],
dependencies : loadleveller_dep,
include_directories : include_directories('../src')
)
test('tests', t1)
subdir('silly_mc')
subdir('silly_mc')
test/observable_names.cpp
0 → 100644
View file @
816de0ac
#include "catch.hpp"
#include "measurements.h"
using
namespace
loadl
;
TEST_CASE
(
"illegal observable names"
)
{
measurements
meas
(
1
);
CHECK_THROWS
(
meas
.
add
(
"A/B."
,
1
));
CHECK_THROWS
(
meas
.
add
(
"A/B"
,
1
));
CHECK_THROWS
(
meas
.
add
(
".AB"
,
1
));
CHECK_NOTHROW
(
meas
.
add
(
"AB"
,
1
));
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment