fml40-reference-implementation issueshttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues2022-11-17T11:10:34+01:00https://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/18add Querys for Timber Trading Organisation2022-11-17T11:10:34+01:00Sebastian-Bloemeke-RIF-evadd Querys for Timber Trading OrganisationSebastian-Bloemeke-RIF-evSebastian-Bloemeke-RIF-evhttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/17add Handling of Timber Lists2022-11-17T11:10:13+01:00Sebastian-Bloemeke-RIF-evadd Handling of Timber ListsSebastian-Bloemeke-RIF-evSebastian-Bloemeke-RIF-evhttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/16add Classes from DigiKomForst project2022-11-17T11:09:41+01:00Sebastian-Bloemeke-RIF-evadd Classes from DigiKomForst projectadd Values and Functionalities from DigiKomForst projectadd Values and Functionalities from DigiKomForst projectSebastian-Bloemeke-RIF-evSebastian-Bloemeke-RIF-evhttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/15Revise readme up to date2022-10-05T09:55:28+02:00Jiahang ChenRevise readme up to datePeng ChenPeng Chenhttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/14Add test stage/job to ci/cd pipeline2022-07-19T17:38:55+02:00GromeTTAdd test stage/job to ci/cd pipeline0.2.5GromeTTGromeTThttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/13Fix ABC import2022-07-19T12:48:28+02:00GromeTTFix ABC importPytest shows the following error, that should be fixed
```
/home/r2d2m-lapi/.pyenv/versions/3.7.0/envs/fml49/lib/python3.7/site-packages/jwt/api_jwt.py:4: DeprecationWarning: Using or importing the ABCs from 'collections' instead of fr...Pytest shows the following error, that should be fixed
```
/home/r2d2m-lapi/.pyenv/versions/3.7.0/envs/fml49/lib/python3.7/site-packages/jwt/api_jwt.py:4: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Iterable, Mapping
```0.2.5GromeTTGromeTThttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/12Emitting named events crashes application2022-07-19T17:40:32+02:00GromeTTEmitting named events crashes applicationfml40-reference-implementation version: 0.2.4.6
s3i version: 0.6.1.4
I created a thing, added a named event to it and try to call event_manager.emit_named_event. This crashes my application, because "emit_named_event" passes wrong (msg_...fml40-reference-implementation version: 0.2.4.6
s3i version: 0.6.1.4
I created a thing, added a named event to it and try to call event_manager.emit_named_event. This crashes my application, because "emit_named_event" passes wrong (msg_id has to be message_id) and insufficient parameters (receivers missing completely) to event_obj.generate_event_msg. Afterwards (event_system.py:43) python complains that EventMessage does not have an attribute called msg.0.2.5Jiahang ChenJiahang Chenhttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/10Upload package to gitlab registry2022-07-19T17:54:49+02:00GromeTTUpload package to gitlab registryCreate a job, that uploads this python package to the gitlab registry. Pipeline is triggered by a semantic versioning tag.Create a job, that uploads this python package to the gitlab registry. Pipeline is triggered by a semantic versioning tag.0.2.5GromeTTGromeTThttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/9Upload package to pypi2022-07-19T18:02:50+02:00GromeTTUpload package to pypiCreate a ci/cd job, that uploads this python package to pypi. Pipeline is triggered by semantic versioning tag.Create a ci/cd job, that uploads this python package to pypi. Pipeline is triggered by semantic versioning tag.0.2.5GromeTTGromeTThttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/8Validate parameters, when sending reply messages2022-07-12T09:18:56+02:00GromeTTValidate parameters, when sending reply messagesThe routine, that answers GetValueRequests with a GetValueReply closes the pika connection with this message:
```Channel is closed: Stream connection lost: AssertionError('A non-string value was supplied for self.routing_key')```
if th...The routine, that answers GetValueRequests with a GetValueReply closes the pika connection with this message:
```Channel is closed: Stream connection lost: AssertionError('A non-string value was supplied for self.routing_key')```
if the GetValueRequest doesn't specifiy `replyToEndpoint`. For me, this message is rather cryptic. It would be better to check the message for this value and in case it is not available, return a proper error message and not publish the message.
Anyway, why is `replyToEndpoint` optional for GetValueRequests in the first place? Without this information, the target is unknown. I think, ServiceRequests will have the problems.0.2.5Jiahang ChenJiahang Chenhttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/7Thing crashes, when using REST Broker2022-07-12T09:19:14+02:00GromeTTThing crashes, when using REST BrokerCreating a Thing like this:
```
root_thing = create_thing(
model_json=config,
oauth2_secret=os.getenv("DT_SECRET"),
username=os.getenv("S3I_USERNAME"),
password=os.getenv("S3I_PASSWORD"),
is_b...Creating a Thing like this:
```
root_thing = create_thing(
model_json=config,
oauth2_secret=os.getenv("DT_SECRET"),
username=os.getenv("S3I_USERNAME"),
password=os.getenv("S3I_PASSWORD"),
is_broker=True,
is_broker_rest=True,
```
causes a crash:
```
2022-07-11 16:27:37,114 - INFO - Awesome sender: Build digital twin Awesome sender with id s3i:63c317a5-8c79-47cd-93fb-7aad5a1c74f0
2022-07-11 16:27:37,115 - INFO - Awesome sender: Adding roles: ml40::HMI
2022-07-11 16:27:37,116 - INFO - Awesome sender: [S3I]: Start the thing
2022-07-11 16:27:37,116 - INFO - Awesome sender: [S3I]: Connect to IdentityProvider
2022-07-11 16:27:37,213 - INFO - Awesome sender: [S3I]: Access Token granted
2022-07-11 16:27:37,214 - INFO - Awesome sender: [S3I]: Connect to Directory
2022-07-11 16:27:37,506 - INFO - Awesome sender: [S3I]: Connecting to Broker
Traceback (most recent call last):
File "main.py", line 88, in <module>
main()
File "main.py", line 84, in main
root_thing.run_forever()
File "/home/r2d2/.pyenv/versions/awesome-sender/lib/python3.7/site-packages/ml/thing.py", line 91, in run_forever
self.connect_to_s3i()
File "/home/r2d2/.pyenv/versions/awesome-sender/lib/python3.7/site-packages/ml/thing.py", line 196, in connect_to_s3i
self.__setup__broker()
File "/home/r2d2/.pyenv/versions/awesome-sender/lib/python3.7/site-packages/ml/thing.py", line 276, in __setup__broker
self.callbacks.process(self._ON_BROKER_START_OK, self.loop)
File "/home/r2d2/.pyenv/versions/awesome-sender/lib/python3.7/site-packages/ml/callback.py", line 78, in process
method(*args, **kwargs)
File "/home/r2d2/.pyenv/versions/awesome-sender/lib/python3.7/site-packages/ml/thing.py", line 142, in _add_on_channel_open_callback
_thing.broker.add_on_channel_open_callback(
AttributeError: 'BrokerREST' object has no attribute 'add_on_channel_open_callback'```
Is this a bug, or am I using it wrong?0.2.5Jiahang ChenJiahang Chenhttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/4Adjust AbstractInventory class inheritence2021-12-15T15:21:53+01:00GromeTTAdjust AbstractInventory class inheritenceAtm AbstractInventory inherits from ABC, this is wrong.Atm AbstractInventory inherits from ABC, this is wrong.GromeTTGromeTThttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/2Fix function tools.remove_namespace2021-09-10T23:46:17+02:00GromeTTFix function tools.remove_namespaceAtm. this function only works for the following prefixes: mml40, fml40 and ml40
It won't return correct results for other prefixes and for nested namespaces (if allowed) like fml40::dilatect::MyValue.
Maybe it also makes sense to valida...Atm. this function only works for the following prefixes: mml40, fml40 and ml40
It won't return correct results for other prefixes and for nested namespaces (if allowed) like fml40::dilatect::MyValue.
Maybe it also makes sense to validate the input of the function to allow only valid class names. I.e. `remove_namespace("fml40::123")` returns "123" which is not a valid python class name.Jiahang ChenGromeTTJiahang Chenhttps://git.rwth-aachen.de/kwh40/fml40-reference-implementation/-/issues/1Create namespace decorators2021-09-10T22:36:37+02:00GromeTTCreate namespace decoratorsI'm not sure if it is possible, but it would be very nice if we could add the namespace to a class with a decorator like so:
```python
@add_namespace("fml40")
class Moisture(Value):
...
```
If this works, we can also invent a decorator t...I'm not sure if it is possible, but it would be very nice if we could add the namespace to a class with a decorator like so:
```python
@add_namespace("fml40")
class Moisture(Value):
...
```
If this works, we can also invent a decorator that adds a class to the dt_factory.
https://rifrt-jira.rif-ev.de/browse/KWH-1340?filter=-2Jiahang ChenGromeTTJiahang Chen