From 9a5942680bd89bc5afb7e25d6118dc910f4eec40 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Sch=C3=A4fer?=
<pschaefer@ITA.AKUSTIK.RWTH-AACHEN.DE>
Date: Wed, 20 Nov 2024 09:19:08 +0100
Subject: [PATCH 1/3] python VAServer.exe selection: bring UI to the front and
print respective hint
---
src/vapython/_helper.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/vapython/_helper.py b/src/vapython/_helper.py
index 06f09ec..3dcf2ab 100644
--- a/src/vapython/_helper.py
+++ b/src/vapython/_helper.py
@@ -204,7 +204,9 @@ def find_server_executable() -> Optional[Path]:
root = tk.Tk()
root.withdraw()
+ root.attributes('-topmost', 1)
+ print("NOTE: A window has opened for specifying the path to the 'VAServer.exe'. This should be located in the `bin` subfolder of the respective VA directory.")
executable_raw = filedialog.askopenfilename(
title="Select VAServer executable",
filetypes=[("VAServer executable", "*.exe")],
--
GitLab
From 3f9dfea2bf931a454c72a46a816e19b8cdd1482a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Sch=C3=A4fer?=
<pschaefer@ITA.AKUSTIK.RWTH-AACHEN.DE>
Date: Wed, 20 Nov 2024 09:52:04 +0100
Subject: [PATCH 2/3] fixed code format
---
src/vapython/_helper.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/vapython/_helper.py b/src/vapython/_helper.py
index 3dcf2ab..61967c0 100644
--- a/src/vapython/_helper.py
+++ b/src/vapython/_helper.py
@@ -204,9 +204,11 @@ def find_server_executable() -> Optional[Path]:
root = tk.Tk()
root.withdraw()
- root.attributes('-topmost', 1)
+ root.attributes("-topmost", 1)
- print("NOTE: A window has opened for specifying the path to the 'VAServer.exe'. This should be located in the `bin` subfolder of the respective VA directory.")
+ print(
+ "NOTE: A window has opened for specifying the path to the 'VAServer.exe'. This should be located in the `bin` subfolder of the respective VA directory."
+ )
executable_raw = filedialog.askopenfilename(
title="Select VAServer executable",
filetypes=[("VAServer executable", "*.exe")],
--
GitLab
From 8046624ff1760d83c8951829b31a74ddbb8d220d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Sch=C3=A4fer?=
<pschaefer@ITA.AKUSTIK.RWTH-AACHEN.DE>
Date: Wed, 20 Nov 2024 11:28:40 +0100
Subject: [PATCH 3/3] VAServer.exe finder: Disable linter error for print
---
src/vapython/_helper.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vapython/_helper.py b/src/vapython/_helper.py
index 61967c0..83aeaf1 100644
--- a/src/vapython/_helper.py
+++ b/src/vapython/_helper.py
@@ -206,7 +206,7 @@ def find_server_executable() -> Optional[Path]:
root.withdraw()
root.attributes("-topmost", 1)
- print(
+ print( # noqa: T201
"NOTE: A window has opened for specifying the path to the 'VAServer.exe'. This should be located in the `bin` subfolder of the respective VA directory."
)
executable_raw = filedialog.askopenfilename(
--
GitLab