VACore merge requestshttps://git.rwth-aachen.de/ita/VACore/-/merge_requests2024-01-24T09:24:59+01:00https://git.rwth-aachen.de/ita/VACore/-/merge_requests/14Draft: SoundPathBasedRenderers: Allow changing default reflection factor in i...2024-01-24T09:24:59+01:00Philipp SchäferDraft: SoundPathBasedRenderers: Allow changing default reflection factor in ini-fileCurrently, ground reflection factor for, e.g. ATNRenderer can only be applied during run-time.
This feature allows changing the default reflection factor (which is sound hard) in the VACore.ini. The option is available for all sound-path...Currently, ground reflection factor for, e.g. ATNRenderer can only be applied during run-time.
This feature allows changing the default reflection factor (which is sound hard) in the VACore.ini. The option is available for all sound-path-based renderers.
In the future, this could be also used the OutdoorNoiseRenderer.Philipp SchäferPhilipp Schäferhttps://git.rwth-aachen.de/ita/VACore/-/merge_requests/13Enable configuration of data history interpolation method2023-10-27T17:00:16+02:00Philipp SchäferEnable configuration of data history interpolation methodBefore, the utlized interpolation methods for the data histories in the AirtrafficNoise renderer were hard coded. Now they can be set through VACore.ini. Configuration is defined in SoundPathBaseRenderer so that it could also be applied ...Before, the utlized interpolation methods for the data histories in the AirtrafficNoise renderer were hard coded. Now they can be set through VACore.ini. Configuration is defined in SoundPathBaseRenderer so that it could also be applied to other renderers if required in future.Philipp SchäferPhilipp Schäferhttps://git.rwth-aachen.de/ita/VACore/-/merge_requests/12Changes to VACore made to pass directivity-change-event to RoomAcousticsRende...2023-11-16T14:38:37+01:00Rouben RehmanChanges to VACore made to pass directivity-change-event to RoomAcousticsRenderer and include path to directivity in the event.The changes include among others:
- making `GetFilename( )` a virtual function in directivity interface (Was already implemented for all derived classes)
- Moving pointer to VACore from private to protected in BaseRenderer to be able to...The changes include among others:
- making `GetFilename( )` a virtual function in directivity interface (Was already implemented for all derived classes)
- Moving pointer to VACore from private to protected in BaseRenderer to be able to:
- Register RoomAcousticsRenderer as event handler to fetch ChangeDirectivity event
- Emit ChangeDirectivity event now with path to set directivity.https://git.rwth-aachen.de/ita/VACore/-/merge_requests/11Removed non-utf8 characters from VADirectivity child classes' GetDesc( ) func...2023-10-13T14:34:16+02:00Rouben RehmanRemoved non-utf8 characters from VADirectivity child classes' GetDesc( ) functionRemoved non-utf8 characters from VADirectivity child classes GetDesc( ) functions that prevented gRPC from correctly serializing the data.
Closes #35Removed non-utf8 characters from VADirectivity child classes GetDesc( ) functions that prevented gRPC from correctly serializing the data.
Closes #35https://git.rwth-aachen.de/ita/VACore/-/merge_requests/10Moving fix of related issue to the correct branch2023-10-12T18:51:06+02:00Rouben RehmanMoving fix of related issue to the correct branchThis moves the fix of the related issue #35 to the associated branch.This moves the fix of the related issue #35 to the associated branch.https://git.rwth-aachen.de/ita/VACore/-/merge_requests/9VAAudioRendererBase: moving core part of the process stream into protected...2023-09-29T14:06:04+02:00Marco WegenerVAAudioRendererBase: moving core part of the process stream into protected...## Work done until now on AmbisonicsRotationRenderer:
- Added function vCreateRotationMatrix to assemble 3x3 rotation matrix from view-up vectors
- Added function vFCreateSphericalHarmonicsRotationMatrix to calculate SH matrix using SAFs...## Work done until now on AmbisonicsRotationRenderer:
- Added function vCreateRotationMatrix to assemble 3x3 rotation matrix from view-up vectors
- Added function vFCreateSphericalHarmonicsRotationMatrix to calculate SH matrix using SAFs [getSHrotMtxReal function](https://leomccormack.github.io/Spatial_Audio_Framework/group___s_h.html#gabb0681d04a190b7e1fe3d362f301f63e)
- Added function vApplySphericalHarmonicsRotation to apply rotation to signal
All functions are stored in Utils/VASphericalHarmonicsRotation.h.
## Unit tests:
- Test for vCreateRotationMatrix compares matrices to reference values calculated by hand
- Test for vfCreateSphericalHarmonicsRotationMatrix compares matrices to reference values calculated by Matlabs [getSHrotMtx function](https://de.mathworks.com/matlabcentral/fileexchange/43856-real-complex-spherical-harmonic-transform-gaunt-coefficients-and-rotations)
##To-Do:
- Finish vApplySphericalHarmonicsRotation and create test. **Idea:** apply dirac-impulse as input signal and compare output channels
- Fix compile errors caused by SAF implementationhttps://git.rwth-aachen.de/ita/VACore/-/merge_requests/8Fixing several bugs regarding air attenuation2023-09-25T09:12:43+02:00Philipp SchäferFixing several bugs regarding air attenuation- added missing a conversion of static pressure from Pa to kPa
- adapted to new ITABase functions (no 1-alpha conversion required anymore)
- moved air attenuation calculation to subroutine so that it can be unit-tested
Related merge req...- added missing a conversion of static pressure from Pa to kPa
- adapted to new ITABase functions (no 1-alpha conversion required anymore)
- moved air attenuation calculation to subroutine so that it can be unit-tested
Related merge request:
https://git.rwth-aachen.de/ita/ITABase/-/merge_requests/2Philipp SchäferPascal PalendaPhilipp Schäferhttps://git.rwth-aachen.de/ita/VACore/-/merge_requests/7Config: now allows considering additional search paths while loading ini file2023-08-09T13:37:12+02:00Philipp SchäferConfig: now allows considering additional search paths while loading ini filePhilipp SchäferPhilipp Schäferhttps://git.rwth-aachen.de/ita/VACore/-/merge_requests/6Core-locking: scene locking is not thread bound anymore2023-08-07T14:49:54+02:00Philipp SchäferCore-locking: scene locking is not thread bound anymore- Now uses a bool instead of thread ID during locking/unlocking
- Multi-locking is not possible anymore => instead sends warning
- removed member variables
- m_csSyncModLock
- m_lSyncModSpinCount- Now uses a bool instead of thread ID during locking/unlocking
- Multi-locking is not possible anymore => instead sends warning
- removed member variables
- m_csSyncModLock
- m_lSyncModSpinCounthttps://git.rwth-aachen.de/ita/VACore/-/merge_requests/5Adapt to `IHTAInstrumentation` changes2023-06-09T11:36:26+02:00Pascal PalendaAdapt to `IHTAInstrumentation` changesThe use of `IHTAInstrumentation` caused some issues in `VACore`.
These changes fix these issues.The use of `IHTAInstrumentation` caused some issues in `VACore`.
These changes fix these issues.https://git.rwth-aachen.de/ita/VACore/-/merge_requests/4Enhance/room acoustic renderer config2022-11-14T16:09:45+01:00Pascal PalendaEnhance/room acoustic renderer configCloses #27Closes #27https://git.rwth-aachen.de/ita/VACore/-/merge_requests/3Master2018-08-14T14:20:19+02:00Lucas MöschMasterhttps://git.rwth-aachen.de/ita/VACore/-/merge_requests/2WIP on HATO processing2018-05-15T14:19:49+02:00Dipl.-Ing. Jonas StienenWIP on HATO processingDipl.-Ing. Jonas StienenDipl.-Ing. Jonas Stienenhttps://git.rwth-aachen.de/ita/VACore/-/merge_requests/1WIP: features/subwoofer reproduction2016-10-13T13:37:21+02:00Dipl.-Ing. Jonas StienenWIP: features/subwoofer reproductionSubwoofer (single or array) reproduction using lightweight input channel mixing (sample copying).Subwoofer (single or array) reproduction using lightweight input channel mixing (sample copying).aixCAVE integrated subwoofer audioDipl.-Ing. Jonas StienenDipl.-Ing. Jonas Stienen