EmbeddedMontiArc issueshttps://git.rwth-aachen.de/groups/monticore/EmbeddedMontiArc/-/issues2021-12-07T12:58:19+01:00https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/issues/13Use an image input as addition2021-12-07T12:58:19+01:00Evgeny KusmenkoUse an image input as additionFor now the model adds the input numbers. In a future version we would like to provide the input as an image as well (*, /, +, -).
Please create a training database for MNIST operators (or use an existing one) and adapt the model accor...For now the model adds the input numbers. In a future version we would like to provide the input as an image as well (*, /, +, -).
Please create a training database for MNIST operators (or use an existing one) and adapt the model accordingly. The operator detector should only recognize operators, i.e. the operator dataset and the mnist dataset should not be mixed.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/issues/12Most pipelines don't check the result of the MNISTCalc2021-12-07T12:55:25+01:00Evgeny KusmenkoMost pipelines don't check the result of the MNISTCalcPlease add result checks similar to [this one](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/blob/master/.gitlab-ci.yml#L34) to all CI pipelines which don't have itPlease add result checks similar to [this one](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/blob/master/.gitlab-ci.yml#L34) to all CI pipelines which don't have ithttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/33Generation of execute code fails for similar component names2021-12-07T12:45:51+01:00Evgeny KusmenkoGeneration of execute code fails for similar component namesSometimes the generator confuses similar component names, e.g. `number1_ones` and `number1` in
[this model](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/blob/1718997f3019e4efe3da4fa853f1df460406400...Sometimes the generator confuses similar component names, e.g. `number1_ones` and `number1` in
[this model](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/blob/1718997f3019e4efe3da4fa853f1df4604064009/gluon-cpp/src/emadl/models/cNNCalculator/Calculator.emadl)
here the `number1 ` component gets executed instead of `number1_ones`, `number1_tens`, `number1_hundreds`. Same happens for `number2` and the respective ArgMax components.
Please fix this and rename the Argmax components back to `number1_ones`, `number1_tens`, `number1_hundreds`, etc. in the master branch.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/38Physical Collisions2021-11-26T14:28:38+01:00Evgeny KusmenkoPhysical CollisionsAt the moment collisions are detected, but there is no physical response.
Physical collision handling needs to be added.At the moment collisions are detected, but there is no physical response.
Physical collision handling needs to be added.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/32Failing tests2021-11-22T12:08:50+01:00Ghost UserFailing testsThe following test cases were not executed by the pipeline due to a process termination caused by a wrong initializing of the global logger. After fixing the issue, the following tests are now failing and must be fixed.
- CMakeGeneratio...The following test cases were not executed by the pipeline due to a process termination caused by a wrong initializing of the global logger. After fixing the issue, the following tests are now failing and must be fixed.
- CMakeGenerationTest.testModelWithIpopt()
- IntegrationGluonTest.testEpisodicMemorySimple()
- IntegrationGluonTest.testGluonPreprocessingWithSupervised()
- IntegrationGluonTest.testGluonPreprocessingWithGAN()https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/31Order of input port names2021-12-07T16:21:14+01:00Evgeny KusmenkoOrder of input port namesthere is a bug concerning usage of input port names / layer names. order seems to override namesthere is a bug concerning usage of input port names / layer names. order seems to override namesNils BaumannNils Baumannhttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/30LoadNetwork: Input output names are fixed2021-11-19T14:57:50+01:00Evgeny KusmenkoLoadNetwork: Input output names are fixedinput and output must be named data and softmax , this should be changed to allow arbitrary namesinput and output must be named data and softmax , this should be changed to allow arbitrary namesDmytro SemenchenkoDmytro Semenchenkohttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/issues/11add test for emadl-maven-plugin2021-11-16T16:18:54+01:00Jonas Ritzadd test for emadl-maven-pluginThis project can be build with maven, but the resulting library is neither tested with a streamtest (e.g. matrices for the mnist images, as only numericals and bools are supported but not images) nor tested with an explicit c++ file (e.g...This project can be build with maven, but the resulting library is neither tested with a streamtest (e.g. matrices for the mnist images, as only numericals and bools are supported but not images) nor tested with an explicit c++ file (e.g. mnistcalculator/mnist-calculator/src/main/ema/cpp/DigitCalculator.cpp)https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/29link to docker files not working2021-11-10T11:07:13+01:00Jonas Ritzlink to docker files not workinglink to docker files from the README.md file does not see to work (first section of Prerequisites)link to docker files from the README.md file does not see to work (first section of Prerequisites)https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/28link to docker files not working2021-11-10T11:05:51+01:00Jonas Ritzlink to docker files not workingThe link to the docker files in the first line of subsection Prerequisites in readme.md does not seem to work properly. (404)The link to the docker files in the first line of subsection Prerequisites in readme.md does not seem to work properly. (404)https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/37Simulate then Vizualize2021-11-05T13:55:40+01:00Evgeny KusmenkoSimulate then VizualizeIt is important to be aable to run the simulation first and vizualize the results later, e.g. for analysis purposesIt is important to be aable to run the simulation first and vizualize the results later, e.g. for analysis purposeshttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/36Descriptive Task results2021-10-24T16:00:12+02:00Jean MeuriceDescriptive Task resultsRight now, simulations only return `SUCCESS` or `FAILURE`. While the reason for failure can be better seen when using a GUI (like in the basic-simulator), this makes it hard to understand problems in a CI/CLI setting.
## Task
- Return ...Right now, simulations only return `SUCCESS` or `FAILURE`. While the reason for failure can be better seen when using a GUI (like in the basic-simulator), this makes it hard to understand problems in a CI/CLI setting.
## Task
- Return descriptive reasons when `Tasks` fail. (Ex: "Collided with ...", "Timeout", ...)https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/35Merge SpeedLimit and Navigation components2021-10-20T18:49:31+02:00Jean MeuriceMerge SpeedLimit and Navigation componentsThe SpeedLimit component performs very redundant computations compared to the Navigation component.
The Navigation component can send the `upper_speed_limit` message alongside the trajectory arrays.
This would be a "zero-cost abstractio...The SpeedLimit component performs very redundant computations compared to the Navigation component.
The Navigation component can send the `upper_speed_limit` message alongside the trajectory arrays.
This would be a "zero-cost abstraction" from the communication modelling perspective: a message that is not used by any other ee-component is automatically not routed and sent (by the EE-system).https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/343D World2021-10-20T18:44:20+02:00Jean Meurice3D WorldRight now, the world is 100% flat (at `z=0`) except the buildings which have height.
The rigidbody physics do not model the wheel-ground interaction properly.
Missing is proper collision-detection and collision-resolution with road/grou...Right now, the world is 100% flat (at `z=0`) except the buildings which have height.
The rigidbody physics do not model the wheel-ground interaction properly.
Missing is proper collision-detection and collision-resolution with road/ground geometry. (Requires #33)
There were previous ideas on how to make the world 3D. These can be found in `simulation/old-code/environment/.../geometry/height`
## Tasks
- Correct ground collision-responses in `RigidbodyPhysics`
- Ground and road height based on a noise function, OSM information (if any), image or other height information source (SRTM, ...)https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/33Detailed Road Geometry2021-10-20T18:44:21+02:00Jean MeuriceDetailed Road Geometry## Idea
Bring back the "detailed" road geometry: curves for the boundaries, lanes, proper intersection geometry, side-walks, traffic signs, ...
## Tasks
- Generate proper geometry from the abstract OSM road information
- Handle adja...## Idea
Bring back the "detailed" road geometry: curves for the boundaries, lanes, proper intersection geometry, side-walks, traffic signs, ...
## Tasks
- Generate proper geometry from the abstract OSM road information
- Handle adjacent road segments, handle intersections
- Handle number of lanes, transitions from different lane numbers, ...
- Register individual geometry-chunks as "static-objects" in the simulator
- Handle the collision response in the vehicle
- Add "stay on road" checks, ...
- Add proper rigidbody physics for the road-vehicle interactions
- Road markings ("vectorial"/spline representation) + type
- Sidewalks
- Traffic signs, lights, ...
## Notes
- Some old code that did this can be found in `simulation/old-code/environment`.
- *If old code is adapted, it should use the proper [Vector Math](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/wikis/dev-docs/commons/Vectors,-Matrices-and-Math)*
- This can be built up progressively:
- Generate simple rectangular chunks for the road
- Test the junction between segments
- Test detecting overlaps
- Intersections: simple polygons
- More detailed road geometry
- ...https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/32Scenario Folders2021-10-20T17:57:21+02:00Jean MeuriceScenario Folders- Handle sub-folders in the scenario-view
- Give the basic-simulator a [list] of scenario folders via command line to be shown in the "browser"- Handle sub-folders in the scenario-view
- Give the basic-simulator a [list] of scenario folders via command line to be shown in the "browser"https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/commons/-/issues/3Please add Issues for the commons project in the simulation project (with the...2021-10-20T17:49:08+02:00Jean MeuricePlease add Issues for the commons project in the simulation project (with the 'commons' label) for better overviewhttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/hardware_emulator/-/issues/5Please add Issues for the hardware-emulator in the simulation project (with t...2021-10-20T17:48:37+02:00Jean MeuricePlease add Issues for the hardware-emulator in the simulation project (with the 'hardware-emulator' label) for better overviewhttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/basic-simulator/-/issues/6Please add Issues for the basic-simulator in the simulation project (with the...2021-10-20T17:45:03+02:00Jean MeuricePlease add Issues for the basic-simulator in the simulation project (with the 'basic-simulator' label) for better overviewhttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/31Async Simulation and Visualization + Data-Export system2021-10-20T17:46:50+02:00Jean MeuriceAsync Simulation and Visualization + Data-Export systemIdea: Run the simulations in another thread.
Advantages:
- Some performance improvement since one thread can run the simulation full speed, the other render the visualization.
- (Re-)develop the simulation data exporting. The relevant s...Idea: Run the simulations in another thread.
Advantages:
- Some performance improvement since one thread can run the simulation full speed, the other render the visualization.
- (Re-)develop the simulation data exporting. The relevant simulation data-points are saved per frame (can be a different rate then the simulation rate). The simulation "client" would register which data-points should be exported (to save bandwidth).
- The basic-sim can store the frames for a simulation. This allows to watch a simulation as it is simulated, but also to watch back/navigate the simulation using a timeline.
- This simplifies the time control logic between visualization and simulation.
- The data-export system can also directly be used to save simulation results.
- The data-export system could also be used to watch simulations remotely (would update the *visualization* project)
- A solid data-export system would make exporting any data (also inspection data for plotting, ...) cleaner and more generic.