EmbeddedMontiArc issueshttps://git.rwth-aachen.de/groups/monticore/EmbeddedMontiArc/-/issues2022-07-15T17:00:09+02:00https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/issues/17Add a cpp unittest2022-07-15T17:00:09+02:00Yuyuan LiuAdd a cpp unittestInstead of calling a executable with the images as parameters, implement a cpp file to run the unittests.Instead of calling a executable with the images as parameters, implement a cpp file to run the unittests.Yuyuan LiuYuyuan Liuhttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/CNNArch2Caffe2/-/issues/7move train routine to a dedicated trainer2022-05-04T14:01:28+02:00Jonas Ritzmove train routine to a dedicated trainerin the other backends, the train(...) routine is implemented in specific trainers, e.g. CNNSupervisedTrainer, while here, it is implemented in the CNNCreator, but does not really belong therein the other backends, the train(...) routine is implemented in specific trainers, e.g. CNNSupervisedTrainer, while here, it is implemented in the CNNCreator, but does not really belong therehttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/CNNArch2Caffe2/-/issues/6Data Loading of hdf5 files2022-05-04T13:59:48+02:00Jonas RitzData Loading of hdf5 filesright now, this backend just supports loading lmdb files, there is no such thin as an extra dedicated dataloader compared to the other backends where one could implement cleaningright now, this backend just supports loading lmdb files, there is no such thin as an extra dedicated dataloader compared to the other backends where one could implement cleaninghttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/40Angle Calculation between Vectors Incorrect2022-04-25T17:26:12+02:00Til MohrAngle Calculation between Vectors IncorrectThe calculation for the angle between two vectors (e.g. https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/commons/-/blob/master/src/main/java/de/rwth/montisim/commons/utils/Vec3.java#L89) is implemented incorrectly.
See [...The calculation for the angle between two vectors (e.g. https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/commons/-/blob/master/src/main/java/de/rwth/montisim/commons/utils/Vec3.java#L89) is implemented incorrectly.
See [this](https://www.cuemath.com/geometry/angle-between-vectors/) and [OpenJFX Point3D Implementation](https://github.com/teamfx/openjfx-9-dev-rt/blob/master/modules/javafx.graphics/src/main/java/javafx/geometry/Point3D.java) for references.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/CNNArch2Gluon/-/issues/9Generate Network execution based on Training and Test data2022-02-15T11:16:06+01:00Jonas RitzGenerate Network execution based on Training and Test dataSometimes you want to execute your network with some training or test data examples and e.g. visualize how it performs. Therefore there is yet C++ Code generated which enables an execution of the network.
Unfortunately, the loading of th...Sometimes you want to execute your network with some training or test data examples and e.g. visualize how it performs. Therefore there is yet C++ Code generated which enables an execution of the network.
Unfortunately, the loading of the data has to be done by hand, even if you want to execute the network with training data, for example when loading images or importing hdf5 data.
Therefore, the plan is to let the execution be generated (aditionally in python) and let the user of the framework only insert an index of the training or test data point which he wants to be executed, in order to then receive the prediciton and the label and compare in help of his code. In this context the DataLoader can be reused in the execution, but for that it must be available in the execution.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/36Reference models not copied to generation target path2022-03-31T09:44:03+02:00Ghost UserReference models not copied to generation target pathThe method `EMADLGenerator.copySchemaFilesFromResource` (https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/blob/master/src/main/java/de/monticore/lang/monticar/emadl/generator/EMADLGenerator.java#L1104) copies ...The method `EMADLGenerator.copySchemaFilesFromResource` (https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/blob/master/src/main/java/de/monticore/lang/monticar/emadl/generator/EMADLGenerator.java#L1104) copies the schema files (`*.scm`) to the generation target path, however, it does not copy the reference models (`*.ema`), leading to exceptions when running the generator with the reinforcement learning and GAN pipelines.
This method must be changed such that along with the schema files, also the reference models are copied to the generation target path.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/hardware_emulator/-/issues/7Fix compiling of CPP project on windows2022-01-07T12:45:32+01:00Mattis HoppeFix compiling of CPP project on windowsCompiling of the CPP code does currently not work on Windows.Compiling of the CPP code does currently not work on Windows.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/39ActiveMQ integration2021-12-17T13:39:41+01:00Evgeny KusmenkoActiveMQ integrationSimulator soll von ROS auf ActiveMQ umgestellt werdenSimulator soll von ROS auf ActiveMQ umgestellt werdenMattis HoppeMattis Hoppehttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/issues/15Port name collision2021-12-16T15:13:48+01:00Evgeny KusmenkoPort name collisionNames seem to be generated in a wrong way, e.g. when one model name is a substring of another, cf. [old pipeline](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/jobs/2145115)Names seem to be generated in a wrong way, e.g. when one model name is a substring of another, cf. [old pipeline](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/jobs/2145115)https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/issues/14Use array notation2021-12-07T12:59:14+01:00Evgeny KusmenkoUse array notationrefactor model to component array notation. This might require generator updates.refactor model to component array notation. This might require generator updates.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/issues/13Use an image input as addition2021-12-07T12:58:19+01:00Evgeny KusmenkoUse an image input as additionFor now the model adds the input numbers. In a future version we would like to provide the input as an image as well (*, /, +, -).
Please create a training database for MNIST operators (or use an existing one) and adapt the model accor...For now the model adds the input numbers. In a future version we would like to provide the input as an image as well (*, /, +, -).
Please create a training database for MNIST operators (or use an existing one) and adapt the model accordingly. The operator detector should only recognize operators, i.e. the operator dataset and the mnist dataset should not be mixed.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/issues/12Most pipelines don't check the result of the MNISTCalc2021-12-07T12:55:25+01:00Evgeny KusmenkoMost pipelines don't check the result of the MNISTCalcPlease add result checks similar to [this one](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/blob/master/.gitlab-ci.yml#L34) to all CI pipelines which don't have itPlease add result checks similar to [this one](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/blob/master/.gitlab-ci.yml#L34) to all CI pipelines which don't have ithttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/33Generation of execute code fails for similar component names2021-12-07T12:45:51+01:00Evgeny KusmenkoGeneration of execute code fails for similar component namesSometimes the generator confuses similar component names, e.g. `number1_ones` and `number1` in
[this model](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/blob/1718997f3019e4efe3da4fa853f1df460406400...Sometimes the generator confuses similar component names, e.g. `number1_ones` and `number1` in
[this model](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/blob/1718997f3019e4efe3da4fa853f1df4604064009/gluon-cpp/src/emadl/models/cNNCalculator/Calculator.emadl)
here the `number1 ` component gets executed instead of `number1_ones`, `number1_tens`, `number1_hundreds`. Same happens for `number2` and the respective ArgMax components.
Please fix this and rename the Argmax components back to `number1_ones`, `number1_tens`, `number1_hundreds`, etc. in the master branch.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/38Physical Collisions2021-11-26T14:28:38+01:00Evgeny KusmenkoPhysical CollisionsAt the moment collisions are detected, but there is no physical response.
Physical collision handling needs to be added.At the moment collisions are detected, but there is no physical response.
Physical collision handling needs to be added.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/32Failing tests2021-11-22T12:08:50+01:00Ghost UserFailing testsThe following test cases were not executed by the pipeline due to a process termination caused by a wrong initializing of the global logger. After fixing the issue, the following tests are now failing and must be fixed.
- CMakeGeneratio...The following test cases were not executed by the pipeline due to a process termination caused by a wrong initializing of the global logger. After fixing the issue, the following tests are now failing and must be fixed.
- CMakeGenerationTest.testModelWithIpopt()
- IntegrationGluonTest.testEpisodicMemorySimple()
- IntegrationGluonTest.testGluonPreprocessingWithSupervised()
- IntegrationGluonTest.testGluonPreprocessingWithGAN()https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/31Order of input port names2021-12-07T16:21:14+01:00Evgeny KusmenkoOrder of input port namesthere is a bug concerning usage of input port names / layer names. order seems to override namesthere is a bug concerning usage of input port names / layer names. order seems to override namesNils BaumannNils Baumannhttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/30LoadNetwork: Input output names are fixed2021-11-19T14:57:50+01:00Evgeny KusmenkoLoadNetwork: Input output names are fixedinput and output must be named data and softmax , this should be changed to allow arbitrary namesinput and output must be named data and softmax , this should be changed to allow arbitrary namesDmytro SemenchenkoDmytro Semenchenkohttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/applications/mnistcalculator/-/issues/11add test for emadl-maven-plugin2021-11-16T16:18:54+01:00Jonas Ritzadd test for emadl-maven-pluginThis project can be build with maven, but the resulting library is neither tested with a streamtest (e.g. matrices for the mnist images, as only numericals and bools are supported but not images) nor tested with an explicit c++ file (e.g...This project can be build with maven, but the resulting library is neither tested with a streamtest (e.g. matrices for the mnist images, as only numericals and bools are supported but not images) nor tested with an explicit c++ file (e.g. mnistcalculator/mnist-calculator/src/main/ema/cpp/DigitCalculator.cpp)https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/29link to docker files not working2021-11-10T11:07:13+01:00Jonas Ritzlink to docker files not workinglink to docker files from the README.md file does not see to work (first section of Prerequisites)link to docker files from the README.md file does not see to work (first section of Prerequisites)https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/37Simulate then Vizualize2021-11-05T13:55:40+01:00Evgeny KusmenkoSimulate then VizualizeIt is important to be aable to run the simulation first and vizualize the results later, e.g. for analysis purposesIt is important to be aable to run the simulation first and vizualize the results later, e.g. for analysis purposes