EmbeddedMontiArc issueshttps://git.rwth-aachen.de/groups/monticore/EmbeddedMontiArc/-/issues2019-03-28T18:05:51+01:00https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMAM2Middleware/-/issues/26Eval: Why do we use the cluster numbers we use(min, max, same as auto?)2019-03-28T18:05:51+01:00Alexander David HellwigEval: Why do we use the cluster numbers we use(min, max, same as auto?)2019-03-14https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMAM2Middleware/-/issues/24Different values of heuristic for same (max) number of clusters2019-03-11T14:58:36+01:00Alexander David HellwigDifferent values of heuristic for same (max) number of clustersAlexander David HellwigAlexander David Hellwighttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMAM2Middleware/-/issues/23Independent subsystems in a Component do not work with standard clustering al...2019-03-04T20:43:19+01:00Alexander David HellwigIndependent subsystems in a Component do not work with standard clustering algorithmsConsider the component:
```ema
component A{
[...]
connect in1 -> sub1.subIn;
connect in2 -> sub2.subIn;
connect sub1.subOut -> out1;
connect sub2.subOut -> out2;
//No connections between sub1 and sub2
}
```
The resul...Consider the component:
```ema
component A{
[...]
connect in1 -> sub1.subIn;
connect in2 -> sub2.subIn;
connect sub1.subOut -> out1;
connect sub2.subOut -> out2;
//No connections between sub1 and sub2
}
```
The resulting graph has 2 unconnected vertices. Therefore the clustering algorithms can not create clusters.
This problem prevails even if the unconnected subsystems get bigger.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/visualization/-/issues/4Buildings on Streets2019-04-08T17:36:53+02:00Danilo Lourenco TrottaBuildings on StreetsBuildings are parsed from OSM files and placed corresponding to these coordiantes.
But still in certain Maps some buildings are placed completly or halfway on the street.Buildings are parsed from OSM files and placed corresponding to these coordiantes.
But still in certain Maps some buildings are placed completly or halfway on the street.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/19Lab: Group MR2020-05-25T14:38:31+02:00Evgeny KusmenkoLab: Group MR@b @taeuber.theresa @michael.osetinski @florisa.martins @danilo.trotta @lynchmu @jun.pu
Dear all,
please accumulate all your contributions in a single group branch and create a SINGLE merge request for the simulation repository.@b @taeuber.theresa @michael.osetinski @florisa.martins @danilo.trotta @lynchmu @jun.pu
Dear all,
please accumulate all your contributions in a single group branch and create a SINGLE merge request for the simulation repository.Michael OsetinskiBenjamin StutteYanjiang Heyanjiang.he@rwth-aachen.deFlorisa MartinsDanilo TrottaTheresa TäuberDanilo Lourenco TrottaMichael Osetinski2019-03-05https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/-/issues/9Internal State may prevent multiple sequential executions2019-02-24T20:50:07+01:00Christopher Jan-Steffen BrixInternal State may prevent multiple sequential executionsThere seems to be some internal state which is stored across multiple executions of the `main` in the `EMADLGeneratorCli`.
This causes the following effect: Usually, the unit test `testMultipleInstances` passes without problems. However...There seems to be some internal state which is stored across multiple executions of the `main` in the `EMADLGeneratorCli`.
This causes the following effect: Usually, the unit test `testMultipleInstances` passes without problems. However, adding a [certain new test](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMADL2CPP/blob/oneclick_nn_training/src/test/java/de/monticore/lang/monticar/emadl/GenerationTest.java#L205) (which passes) causes it to fail. It now throws a NullPointerException.Evgeny KusmenkoEvgeny Kusmenkohttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/18Unhandled possibility of division by zero in LinearInterpolator.java2020-07-29T10:27:43+02:00Benjamin StutteUnhandled possibility of division by zero in LinearInterpolator.java[Line 339](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/geometry/splines/LinearInterpolator.java#L339) of LinearInterpolator.java does not take i...[Line 339](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/geometry/splines/LinearInterpolator.java#L339) of LinearInterpolator.java does not take into account the possibility that `tmpDifference` can be equal to zero, thus returning `NaN` should this case occur.
Also, the documentation does not really make clear what this method is actually supposed to do. That the method `computeT()` "[returns t](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/geometry/splines/LinearInterpolator.java#L318)" is pretty self evident without the linked comment but what is that value actually supposed to represent?https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/CNNArch2Gluon/-/issues/2Refactorings required2019-02-25T17:52:25+01:00Evgeny KusmenkoRefactorings requiredPlease make sure most of the code is inherited from the MxNet generator. For instance in the generator class.Please make sure most of the code is inherited from the MxNet generator. For instance in the generator class.Sebastian NickelsNicola GattoSebastian Nickelshttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMAM2Middleware/-/issues/22Armadillo.h contains mingw specific imports2019-03-01T20:52:34+01:00Alexander David HellwigArmadillo.h contains mingw specific importsAlexander David HellwigAlexander David Hellwighttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/17Faulty search for minimal value in SplineDeterminator class2019-03-31T20:30:47+02:00Benjamin StutteFaulty search for minimal value in SplineDeterminator classThe method `getMinimumSplineForSetAndPoints` initializes the variable `minDist` with `Double.MAX_VALUE` but its content is never overwritten when a smaller value is found. Consequently, the comparison in [line 188](https://git.rwth-aache...The method `getMinimumSplineForSetAndPoints` initializes the variable `minDist` with `Double.MAX_VALUE` but its content is never overwritten when a smaller value is found. Consequently, the comparison in [line 188](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/geometry/osmadapter/SplineDeterminator.java#L188) evaluates to `true` with every iteration and the method always returns the last element in the given set and not neccessarily the correct one.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/16Bug in initialization of LinearSplineDeterminator2019-03-31T20:30:54+02:00Benjamin StutteBug in initialization of LinearSplineDeterminatorInside the [initBounds()](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/geometry/osmadapter/LinearSplineDeterminator.java#L66) method we check for...Inside the [initBounds()](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/geometry/osmadapter/LinearSplineDeterminator.java#L66) method we check for a `y` but assign an `x`-coordinate.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMAM2Middleware/-/issues/21ROS2: Message -> C++ generation2019-05-05T11:16:17+02:00Alexander David HellwigROS2: Message -> C++ generation.h files generated from .msg files can lead to compilation errors..h files generated from .msg files can lead to compilation errors.Alexander David HellwigAlexander David Hellwighttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMAM2Middleware/-/issues/20Automatic Clustering parameter search2019-02-16T13:47:12+01:00Alexander David HellwigAutomatic Clustering parameter searchE.g. try different values for sigma while using SpectralClusteringE.g. try different values for sigma while using SpectralClusteringhttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMAM2Middleware/-/issues/19Interactive overview of clustering results/chooser2019-02-03T11:00:54+01:00Alexander David HellwigInteractive overview of clustering results/chooser```
+-------------------------------+---------+
| | algo1 |
| <visualization of cluster> | >algo2 |
| | ... |
| | |
+------------...```
+-------------------------------+---------+
| | algo1 |
| <visualization of cluster> | >algo2 |
| | ... |
| | |
+-------------------------------+---------+
| |continue |
|<extra info for choosen algo> |cancel |
| | |
+-----------------------------------------+
```https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/15WorldModel.java: possibly several bugs in methods used to access wheel positions2019-04-08T10:44:32+02:00Benjamin StutteWorldModel.java: possibly several bugs in methods used to access wheel positionsBoth [`getDistanceLeftFrontToStreetBorder`](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/WorldModel.java#L349) and [`getDistanceRightFrontToStree...Both [`getDistanceLeftFrontToStreetBorder`](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/WorldModel.java#L349) and [`getDistanceRightFrontToStreetBorder`](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/WorldModel.java#L359) call `getBackLeftWheelGeometryPosition()` to determine the wheel position while it should be `getFrontLeftWheelGeometryPosition()` and `getFrontRightWheelGeometryPosition()` respectively.
Furthermore, the methods [`getDistanceFrontRightWheelToRightStreetBorder`](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/WorldModel.java#L377) [`getDistanceBackRightWheelToRightStreetBorder`](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/environment/src/main/java/simulation/environment/WorldModel.java#L387) return `minStreet.getDistanceToLeft` while it seems like it should be `minStreet.getDistanceToRight`.https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/-/issues/14Possible typo in doCalculationStep method of ModelicaPhysicalVehicle2019-03-31T20:31:11+02:00Benjamin StuttePossible typo in doCalculationStep method of ModelicaPhysicalVehicleShouldn't [this line](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/vehicle/src/main/java/simulation/vehicle/ModelicaPhysicalVehicle.java#L568) be
`double brakeAcceleration4 = simulationVehicle....Shouldn't [this line](https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/vehicle/src/main/java/simulation/vehicle/ModelicaPhysicalVehicle.java#L568) be
`double brakeAcceleration4 = simulationVehicle.getVehicleActuator(VEHICLE_ACTUATOR_TYPE_BRAKES_BACK_RIGHT).getActuatorValueCurrent();`?https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMAM2Middleware/-/issues/18Test flatten algorithm with a comparable Component2019-02-16T14:08:23+01:00Philipp GörickTest flatten algorithm with a comparable ComponentDo not just test the algorithm for the right amount of connectors and subcomponents.Do not just test the algorithm for the right amount of connectors and subcomponents.Philipp GörickPhilipp Görickhttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/generators/EMAM2Cpp/-/issues/28Add automatic test execution for cmake build script2019-04-11T18:49:39+02:00Alexander David HellwigAdd automatic test execution for cmake build scriptBasic idea:
Add to CMakeLists.txt
add_custom_target(run_${component.name}_StreamTests ALL
COMMAND ${component.name}_StreamTests
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
)Basic idea:
Add to CMakeLists.txt
add_custom_target(run_${component.name}_StreamTests ALL
COMMAND ${component.name}_StreamTests
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
)Alexander David HellwigAlexander David Hellwighttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/CarLang/-/issues/1Sensor Menagement2019-08-28T10:34:01+02:00Evgeny KusmenkoSensor MenagementCurrently when a vehicle is constructed, all available sensors are added to it. However, in a continuous simulation we will need to test different kinds of vehicles in the same scenario.
1. Please add a possibility to define sensors as ...Currently when a vehicle is constructed, all available sensors are added to it. However, in a continuous simulation we will need to test different kinds of vehicles in the same scenario.
1. Please add a possibility to define sensors as part of the car model.
2. Make sure that only the required sensors are added to a vehicle upon vehicle construction
An overview of the available sensors is available in https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/tree/master/sensors/src/main/java/sensors
have in mind that more and more sensors will be added over time; this should not affect the Car language, i.e. if a new sensor is added, we do not want to have to change the Car language.
Therfore, consider extending the sensor interfacePascal Maurice PortaPascal Maurice Portahttps://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/server/-/issues/14SFS crash with new physics2019-01-18T01:30:35+01:00Michael OsetinskiSFS crash with new physicsFor a collision visualization I corrected the type check in this line: https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/vehicle/src/main/java/simulation/vehicle/PhysicsEngine.java#L77 as described i...For a collision visualization I corrected the type check in this line: https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/blob/master/vehicle/src/main/java/simulation/vehicle/PhysicsEngine.java#L77 as described in https://git.rwth-aachen.de/monticore/EmbeddedMontiArc/simulators/simulation/issues/12 . Then I tried to run a simulation with 2 cars, which collide at an intersection, while having useNewPhysics in `rwth.server.simulation.SimulationController` set to true. This leads to a crash of the SmartFoxServer. I used a custom map, which I appended below. The log of the server console is appended as well.
If I change useNewPhysics to false, the simulation and visualization runs without problems.
[crashLog.txt](/uploads/bd47da5a3ce0bfdfddcbccb4a6c63936/crashLog.txt)
[map.osm](/uploads/a3338003411fce6c9d9cfcb6d2573585/map.osm)