Coscine issueshttps://git.rwth-aachen.de/groups/coscine/-/issues2023-09-26T18:33:25+02:00https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/8[APIv2] Tree Controller2023-09-26T18:33:25+02:00Petar Hristov[APIv2] Tree Controller# Tree Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced...# Tree Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `FileDto`
* :question: also from the Dto it is hard to guess the difference between `path` and `directory`, especially when comparing to the query parameter `?path` that corresponds to the property `directory`.
* :bulb: add `version` and `availableVersions` properties
##### `MetadataDto`
* :bulb: Add `creationDate` and `changeData` properties
* :bulb: Add `name` and `extension` properties (maybe also `parentDirectory`)https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/11[APIv2] Self Controller2023-09-27T09:37:16+02:00Petar Hristov[APIv2] Self Controller# Self Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced...# Self Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `UserDto`:
* :warning:️/:question: instead of extending `OrganizationDto` and `InstituteDto` in this case it might be preferable to add the information to the top level object like `organizationalEmail` or `isOrganizationReadOnly`
##### `UserOrganizationDto`:
* :question:/:warning:️ Why is there an email? See discussion in `UserDto`
* see `OrganizationDto`
##### `UserInstituteDto`:
* :question:/:warning:️ Why is there an email? See discussion in `UserDto`
* see `OrganizationDto`
##### `UserForUpdateDto`
* ~~:question:/:warning:️ I like~~ `ForUpdate` better than `ForManipulation`. I assume `ForManipulation` is mostly used for both `Creation` and `Update`. Check if this applies and consider changing it if/where it does not.
* :warning:️ `organization` and `institute` should follow pattern `{"organization":{"uri":"..."}}` (with rorIds) or `{"organization":{"uri":null, "displayName":"..."}}` for custom entries.https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/15[APIv2] Resource Type Controller2023-09-26T18:37:12+02:00Petar Hristov[APIv2] Resource Type Controller# Resource Type Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be ...# Resource Type Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `ResourceTypeInformationDto`
* :question: Why is this not `ResourceTypeDto`? Probably because it was already taken by `resources` Endpoint. See discussion above on `options`. Likely, the Dto then can be reused.
* :bulb: Add property `displayName`
* :warning:️ "merge" `can*` and `is*` properties to intermediate object `"features": {"canCreate": true, ...}`
* :warning:️ add `resourceContent` as `view` to `features` from above. Alternatively, merge content into `features` (e.g. `resourceContent.metadataView.editableKey` becomes `features.metadata.hasEditableKey`).
* :question: I have the feeling that some `can*` properties are redundant to `resourceContent.*` properties; e.g., `canUpdate` & `canDelete` to `resourceContent.readOnly`. Maybe this needs some cleanup.
* :warning:️/:question: Depending on the discussion above, consider merging some of the `features` by "area" like `storage` (for file storage related e.g. `canRead`), `resource` (for general resource related e.g., `isQuotaAvailable`)
* :warning:️/:question: Is there an alternative for `generalType` and `specificType`? maybe `service` and `region` (or `instance`)?
* :question:/:bulb: Is the `resourceCreation` property used? I did not find it. If not :arrow_right:️ remove.https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/16[APIv2] Resource Controller2023-09-27T09:42:56+02:00Petar Hristov[APIv2] Resource Controller# Resource Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be annou...# Resource Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `ResourceForCreationDto`
* :warning:️ Use `"type": {"id": "..."}` instead of `resourceTypeId`.
* :warning:️ rename `resourceTypeOptions` to `options`
##### `ResourceDto`
* :warning:️ Move `type.options` to `options`, please check that resource type options are consistent in the related Dtos (sometimes found as `type.options`, `options`, `resourceTypeOptions`). `options` would definitely be preferred from my side.
* :warning:️ make `fixedValues` RDF serialized like application profiles instead of JSON (`"fixedValues": {"type":"...", "content":"..."}`). It seems like some form of JSON-LD anyway.
##### `resources/{resourceId}`
* :bulb: Add property `"projects":[{"id":"...", "displayName":"..."}]` to this endpoint to allow a user to navigate to the "real" endpoint.https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/17[APIv2] Project Resource Type Controller2023-09-26T18:37:25+02:00Petar Hristov[APIv2] Project Resource Type Controller# Project Resource Type Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes ...# Project Resource Type Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `ResourceTypeInformationDto`
* :question: Why is this not `ResourceTypeDto`? Probably because it was already taken by `resources` Endpoint. See discussion above on `options`. Likely, the Dto then can be reused.
* :bulb: Add property `displayName`
* :warning:️ "merge" `can*` and `is*` properties to intermediate object `"features": {"canCreate": true, ...}`
* :warning:️ add `resourceContent` as `view` to `features` from above. Alternatively, merge content into `features` (e.g. `resourceContent.metadataView.editableKey` becomes `features.metadata.hasEditableKey`).
* :question: I have the feeling that some `can*` properties are redundant to `resourceContent.*` properties; e.g., `canUpdate` & `canDelete` to `resourceContent.readOnly`. Maybe this needs some cleanup.
* :warning:️/:question: Depending on the discussion above, consider merging some of the `features` by "area" like `storage` (for file storage related e.g. `canRead`), `resource` (for general resource related e.g., `isQuotaAvailable`)
* :warning:️/:question: Is there an alternative for `generalType` and `specificType`? maybe `service` and `region` (or `instance`)?
* :question:/:bulb: Is the `resourceCreation` property used? I did not find it. If not :arrow_right:️ remove.https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/19[APIv2] Project Resource Controller2023-09-27T09:39:26+02:00Petar Hristov[APIv2] Project Resource Controller# Project Resource Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will ...# Project Resource Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `ResourceForCreationDto`
* :warning:️ Use `"type": {"id": "..."}` instead of `resourceTypeId`.
* :warning:️ rename `resourceTypeOptions` to `options`
##### `ResourceDto`
* :warning:️ Move `type.options` to `options`, please check that resource type options are consistent in the related Dtos (sometimes found as `type.options`, `options`, `resourceTypeOptions`). `options` would definitely be preferred from my side.
* :warning:️ make `fixedValues` RDF serialized like application profiles instead of JSON (`"fixedValues": {"type":"...", "content":"..."}`). It seems like some form of JSON-LD anyway.
##### `resources/{resourceId}`
* :bulb: Add property `"projects":[{"id":"...", "displayName":"..."}]` to this endpoint to allow a user to navigate to the "real" endpoint.https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/22[APIv2] Project Invitation Controller2023-09-26T18:41:58+02:00Petar Hristov[APIv2] Project Invitation Controller# Project Invitation Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes wil...# Project Invitation Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `projects/{projectId}/invitations/resolve`:
* :bulb: Return the project that the user was invited to, so that the UI can directly navigate there.https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/23[APIv2] Project Controller2023-09-27T09:42:00+02:00Petar Hristov[APIv2] Project Controller# Project Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announ...# Project Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `ProjectDto`:
* :bulb: Add `"userRole":{"id":"..."}` property to have a quick access to the current users' role in the project. For public projects this should be `null` if the user is not in the project.
##### `projects`:
* :bulb: add query parameter `?withRoles` that gets only project where the user has one of the given roles.
* :bulb: add query parameter `?withVisibilities` to get only projects that have one of the given visibilities.
##### `ProjectRoleForProjectCreationDto`
* :bulb:/:question: Not sure if the name makes sense, suggest renaming to `ProjectRoleForCreationDto`
* :warning:️ Use pattern`"project": {"id":"..."}` instead of `projectId` and `roleId`.
##### `ProjectRoleForProjectManipulationDto`
* :bulb:/:question: Not sure if the name makes sense, I suggest renaming to `ProjectRoleForManipulationDto`
* :warning:️ Use pattern `"role": {"id":"..."}` instead of `roleId`.https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/24[APIv2] Pid Controller2023-09-27T09:41:13+02:00Petar Hristov[APIv2] Pid Controller# Pid Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced ...# Pid Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `PidValidationDto`:
* :bulb: Could be extended with: `href` to project/resource page using GUIDs, `visibiliy` and `userRole` of the current user if a token is supplied.
##### `PidRequestDto`:
* :warning:️ remove `sendConfirmationEmail`
* :warning:️ add `"type"` property with values `email` and `email_confimation`
* :warning:️ "merge" properties `email` and `name` into intermediate object `"contact": {"name":"...", "email":"..."}`https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/25[APIv2] Organization Controller2023-09-26T18:42:44+02:00Petar Hristov[APIv2] Organization Controller# Organization Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be a...# Organization Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `organizations/{organizationsRorUrl}`:
* :bulb: I am missing endpoints (List, Get) to get sub-organizations (e.g. for RWTH: IT Center...) - did we discard this??https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/27[APIv2] License Controller2023-09-26T18:42:56+02:00Petar Hristov[APIv2] License Controller# License Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announ...# License Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `LicenseDto`:
* :bulb: should contain `uri`
##### `licenses/{licenseId}`:
* :bulb: should also accept `uri`https://git.rwth-aachen.de/coscine/collaboration/issues/-/issues/29[APIv2] Discipline Controller2023-09-26T18:43:07+02:00Petar Hristov[APIv2] Discipline Controller# Discipline Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be ann...# Discipline Controller
For this controller we will likely face some non-backward compatible changes. When relying on these features you can subscribe to notifications on this issue and/or engage into the discussion. Changes will be announced here.
Discussion points are classified as follows:
* :warning:️ May introduce breaking change.
* :bulb: Addition to existing interface
* :question: Open question, further discussion will be done in this thread
## Discussion
##### `DisciplineDto`:
* :warning:️ Language should be passed by header, only one attribute `displayName` should be returned.
##### `disciplines/{disciplineId}`:
* :bulb: should also accept `uri`https://git.rwth-aachen.de/coscine/research/metadataextractor/-/issues/12Allow Apache Tika to be hosted in a seperate container2023-07-05T15:23:42+02:00Benedikt HeinrichsAllow Apache Tika to be hosted in a seperate containerThis would allow less installation steps that are necessary for the metadata extraction.This would allow less installation steps that are necessary for the metadata extraction.https://git.rwth-aachen.de/coscine/research/metadataextractor/-/issues/8Harden this service2023-07-05T15:16:09+02:00Benedikt HeinrichsHarden this serviceTry to think of possible attack venues like DOS & DDOS attacks.
What would happen if a user pushes 2000 files to the service?Try to think of possible attack venues like DOS & DDOS attacks.
What would happen if a user pushes 2000 files to the service?https://git.rwth-aachen.de/coscine/research/metadataextractor/-/issues/7Per default: Do not communicate to the outside2023-12-21T13:08:12+01:00Benedikt HeinrichsPer default: Do not communicate to the outsideE.g. Pikes, Metadata Mapper, Google Cloud Speech Recognition
Do this for security reasons.E.g. Pikes, Metadata Mapper, Google Cloud Speech Recognition
Do this for security reasons.https://git.rwth-aachen.de/coscine/research/metadataextractor/-/issues/4Extractors should contain documentation about the responsible people/entities2023-10-20T15:50:09+02:00Benedikt HeinrichsExtractors should contain documentation about the responsible people/entitiesTo scale better with external merge requests, it is necessary to include author and organization information in the extractor so that it is clear who develops them.To scale better with external merge requests, it is necessary to include author and organization information in the extractor so that it is clear who develops them.https://git.rwth-aachen.de/coscine/research/metadataextractor/-/issues/3Improved Text to Knowledge Graph conversion2023-10-20T13:46:04+02:00Benedikt HeinrichsImproved Text to Knowledge Graph conversionCurrently, we are using [Pikes](https://pikes.fbk.eu/) ([Docker Build](https://git.rwth-aachen.de/coscine/research/pikesdocker)) to create a knowledge graph from text. This is pretty much our bottleneck right now, since running it takes ...Currently, we are using [Pikes](https://pikes.fbk.eu/) ([Docker Build](https://git.rwth-aachen.de/coscine/research/pikesdocker)) to create a knowledge graph from text. This is pretty much our bottleneck right now, since running it takes way longer than any other extractor. Therefore, the goal is to research what recent developments in this area are and figure out what current applications are that can do a similar job.
Hint: Check the citations of this paper: https://ieeexplore.ieee.org/abstract/document/7549111
Maybe see: https://aclanthology.org/2022.naacl-industry.33/