Lehrstuhl für Informations- und Automatisierungssysteme issueshttps://git.rwth-aachen.de/groups/acplt/-/issues2020-10-28T17:12:35+01:00https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/94aasx: Allow manual specification objects to be written to package2020-10-28T17:12:35+01:00Michael Thiesaasx: Allow manual specification objects to be written to packagehttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/81aasx: Fix handling of File objects which refer to external URLs2020-11-06T10:53:50+01:00Michael Thiesaasx: Fix handling of File objects which refer to external URLsIt's currently unclear, what kind of values a `File` object may contain and how they should be interpreted. Probably, they are allowed to hold a full URL which refers to some webserver etc. as an alternative to relative and absolute path...It's currently unclear, what kind of values a `File` object may contain and how they should be interpreted. Probably, they are allowed to hold a full URL which refers to some webserver etc. as an alternative to relative and absolute paths (`./some_file.pdf` resp. `/some/path/to/some_file.pdf`), which refer to a local file.
We currently assume that all `File` objects within an AASX package refer to a supplementary file within that package. Thus, reading an AASX package file fails when it contains a `File` object refering to an external file via URL.
To fix that, we should distinguish between local and external references. However, currently the semantics of the `File.value` attribute's values are not clear from the standard (DotAAS), so we can only guess that the existence of the URL schema is the correct criterion.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/107aasx: OPCPackageWriter.write_relationships() is called twice when submodel_sp...2020-11-02T15:02:36+01:00Leon Mauritz Mölleraasx: OPCPackageWriter.write_relationships() is called twice when submodel_split_parts is TrueThe following warnings are logged when running the AASX tests:
```
/usr/lib/python3.8/zipfile.py:1517: UserWarning: Duplicate name: 'aasx/https___acplt_org_Test_AssetAdministrationShell/_rels/https___acplt_org_Test_AssetAdministrationShe...The following warnings are logged when running the AASX tests:
```
/usr/lib/python3.8/zipfile.py:1517: UserWarning: Duplicate name: 'aasx/https___acplt_org_Test_AssetAdministrationShell/_rels/https___acplt_org_Test_AssetAdministrationShell.aas.xml.rels'
return self._open_to_write(zinfo, force_zip64=force_zip64)
/usr/lib/python3.8/zipfile.py:1517: UserWarning: Duplicate name: 'aasx/https___acplt_org_Test_AssetAdministrationShell/_rels/https___acplt_org_Test_AssetAdministrationShell.aas.json.rels'
return self._open_to_write(zinfo, force_zip64=force_zip64)
```
These are caused by `AASXWriter.write_aas()` calling `write_relationships()` by itself when `submodel_split_parts` is `True`. Since `write_aas()` also calls `write_aas_objects()`, which also writes relationships, this results in two calls to `write_relationships()` for the same AAS, which in turn results in duplicate names being written to the file.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/144AASX package explorer could not find submodels in example generated by test/a...2021-10-29T17:31:38+02:00Igor GarmaevAASX package explorer could not find submodels in example generated by test/adapter/aasx/test_aasx.pyI've generated an AASX-file with test/adapter/aasx/test_aasx.py und tried to load it to AASX package explorer. AASX package explorer opened the file, but it could not find submodels. [test.aasx](/uploads/927fcd07feb259bb9c6087f68e233162/...I've generated an AASX-file with test/adapter/aasx/test_aasx.py und tried to load it to AASX package explorer. AASX package explorer opened the file, but it could not find submodels. [test.aasx](/uploads/927fcd07feb259bb9c6087f68e233162/test.aasx)Leon Mauritz MöllerTorben MinyIgor GarmaevLeon Mauritz Möller2021-11-03https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/93aasx: Support AASX packages with XML + JSON parts (redundant serialization of...2020-10-28T11:52:35+01:00Michael Thiesaasx: Support AASX packages with XML + JSON parts (redundant serialization of same objects)https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/63adapter: Change JSON and XML parser interface to add objects directly into a ...2020-11-02T16:31:24+01:00Michael Thiesadapter: Change JSON and XML parser interface to add objects directly into a given AbstractObjectStoreThis allows to use a CouchDBObjectStore or other database-backed ObjectStores without collecting the objects in memory first.
The parser functions should return a set of Identifiers of the parsed objects instead.
See `aas.adapter.aasx....This allows to use a CouchDBObjectStore or other database-backed ObjectStores without collecting the objects in memory first.
The parser functions should return a set of Identifiers of the parsed objects instead.
See `aas.adapter.aasx.AASXReader.read_into()` [LINK](https://git.rwth-aachen.de/acplt/pyi40aas/-/blob/6278d03f6bbb5b22e707dc054382844f05794a3e/aas/adapter/aasx.py#L107), which already has a similar interface.
Progress:
- [x] JSON Deserialization
- [x] XML DeserializationStable library APIhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/38adapter: Create AASX file read- and write functionality2020-03-25T13:09:34+01:00Michael Thiesadapter: Create AASX file read- and write functionalityhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/61adapter._generic: Missing module docstring2020-04-21T09:37:35+02:00Sebastian Heppners.heppner@iat.rwth-aachen.deadapter._generic: Missing module docstringhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/65adapter: Re-publish reader/writer functions and relevant classes from adapter...2020-04-14T15:03:51+02:00Michael Thiesadapter: Re-publish reader/writer functions and relevant classes from adapter.json and adapter.xml modulesImports of the (de)serialization functions should look like
```python
from aas.adapter.json import write_aas_json_file, read_json_aas_file
```
instead of
```python
from aas.adapter.json.json_serialization import write_aas_json_file
from ...Imports of the (de)serialization functions should look like
```python
from aas.adapter.json import write_aas_json_file, read_json_aas_file
```
instead of
```python
from aas.adapter.json.json_serialization import write_aas_json_file
from aas.adapter.json.json_deserialization import read_json_aas_file
```
Thus, we should import all classes of the "public interface" in the `aas.adpater.json.__init__` and `aas.adapter.xml.__init__` modules.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/74adapter.xml: Apply customizing pattern with class methods of json_deserializa...2020-10-28T09:26:32+01:00Michael Thiesadapter.xml: Apply customizing pattern with class methods of json_deserialization to xml_deserializationIn the `aas.adapter.json.json_deserialization` we introduced an elegant pattern to allow customizing the parser behaviour by subclassing the `AASFromJsonDecoder` class and overriding its constructor methods. This is used by the CouchDB a...In the `aas.adapter.json.json_deserialization` we introduced an elegant pattern to allow customizing the parser behaviour by subclassing the `AASFromJsonDecoder` class and overriding its constructor methods. This is used by the CouchDB adapter for example, to construct subclasses of the normal AAS model classes.
We could apply the same pattern to the `xml_deserialization` module.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/72adapter.xml: Check serialization of `annotation` in `AnnotatedRelationshipEle...2020-05-07T14:04:40+02:00Sebastian Heppners.heppner@iat.rwth-aachen.deadapter.xml: Check serialization of `annotation` in `AnnotatedRelationshipElement`According to the metamodel, it should be of type `DataElement`, while we (de)-serialize as `Reference`. This is correct to the current XSD-Schema, since there is currently no `dataElement_t`, but it will probably get added with the new v...According to the metamodel, it should be of type `DataElement`, while we (de)-serialize as `Reference`. This is correct to the current XSD-Schema, since there is currently no `dataElement_t`, but it will probably get added with the new version of the schema, we should check it then.https://git.rwth-aachen.de/acplt/basys4.2/ccProfilesUA/-/issues/2Adapt to new ControlComponentProfile meta model and names2021-02-07T21:19:06+01:00Julian Grothoffj.grothoff@plt.rwth-aachen.deAdapt to new ControlComponentProfile meta model and namesAdapt names to https://wiki.eclipse.org/BaSyx_/_Documentation_/_API_/_ControlComponentProfiles:
* [x] Rename Profiles to FacetsAdapt names to https://wiki.eclipse.org/BaSyx_/_Documentation_/_API_/_ControlComponentProfiles:
* [x] Rename Profiles to FacetsBASYS Profilehttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/68Add AASX checks for compliance tool including tests2020-11-06T10:53:50+01:00Torben MinyAdd AASX checks for compliance tool including testshttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/23Add ID-Generator2019-12-03T17:35:10+01:00Torben MinyAdd ID-Generator* [x] Generator for random unique IDs
* [x] Generator with URL-parameter to create unique IDs in this namespace, e.g. "acplt.org/AAS/" and then create "acplt.org/AAS/AAS1"* [x] Generator for random unique IDs
* [x] Generator with URL-parameter to create unique IDs in this namespace, e.g. "acplt.org/AAS/" and then create "acplt.org/AAS/AAS1"https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/15add license2019-12-11T11:19:39+01:00Leon Mauritz Mölleradd licensehttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/24Add package and module docstrings explaining what is contained in each packag...2019-12-20T15:12:45+01:00Michael ThiesAdd package and module docstrings explaining what is contained in each package/module and should go there* Module Docstrings should contain a description of the functionality the module provides (in an abstract way) and a short overview, how this functionality is implemented (e.g. which functions/classes do I typically need to use the funct...* Module Docstrings should contain a description of the functionality the module provides (in an abstract way) and a short overview, how this functionality is implemented (e.g. which functions/classes do I typically need to use the functionality and when should I look at the other functions/classes). The latter part might not be sensible for AAS model modules.
* Package docstrings should be added for the `aas` and the `aas.model` package and provide a high-level overview over the functionality the structure of this package, including the purpose of the single child modules/packages. It should answer the question: “which functionality regarding the AAS is implemented in the package and which (abstract) part of it can be found in which module?”. The docstring of `aas` might be overlapping with the README.md file, which should also explain the project structure.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/123Add typehint to SubmodelElementCollection.ordered2021-11-09T12:37:27+01:00Igor GarmaevAdd typehint to SubmodelElementCollection.orderedAdd typehint to SubmodelElementCollection.orderedAdd typehint to SubmodelElementCollection.orderedhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/67Add XML checks for compliance tool including tests2020-04-30T11:03:33+02:00Torben MinyAdd XML checks for compliance tool including testsAlpha Release 0.1.0Torben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/39base.Referable.parent is of type: Optional[Namespace]. XSD-schema expects par...2020-01-16T16:45:48+01:00Sebastian Heppners.heppner@iat.rwth-aachen.debase.Referable.parent is of type: Optional[Namespace]. XSD-schema expects parent to be of type="aas:reference_t"How to serialize this parameter in compliance with the schema?How to serialize this parameter in compliance with the schema?https://git.rwth-aachen.de/acplt/rte-tools/rte/-/issues/1Build with OV_VALGRIND fails2021-03-18T23:01:03+01:00Michael ThiesBuild with OV_VALGRIND failsWhen enabling OV_VALGRIND, the OV build fails with the following error.
Compiler: gcc (Debian 8.3.0-6) 8.3.0
```txt
rte/core/ov/source/ov_vendortree.c:113:28: error: ‘ov_vendortree_getUseMalloc’ undeclared here (not in a function); did...When enabling OV_VALGRIND, the OV build fails with the following error.
Compiler: gcc (Debian 8.3.0-6) 8.3.0
```txt
rte/core/ov/source/ov_vendortree.c:113:28: error: ‘ov_vendortree_getUseMalloc’ undeclared here (not in a function); did you mean ‘ov_vendortree_getRTAlloc’?
{ "use_malloc", NULL, ov_vendortree_getUseMalloc, ov_vendortree_setUseMalloc },
^~~~~~~~~~~~~~~~~~~~~~~~~~
ov_vendortree_getRTAlloc
rte/core/ov/source/ov_vendortree.c:113:56: error: ‘ov_vendortree_setUseMalloc’ undeclared here (not in a function); did you mean ‘ov_vendortree_getRTAlloc’?
{ "use_malloc", NULL, ov_vendortree_getUseMalloc, ov_vendortree_setUseMalloc },
^~~~~~~~~~~~~~~~~~~~~~~~~~
ov_vendortree_getRTAlloc
```