Lehrstuhl für Informations- und Automatisierungssysteme issueshttps://git.rwth-aachen.de/groups/acplt/-/issues2020-02-03T15:56:23+01:00https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/40DataChecker: Add Test for correct storing of the `expecation`message and the ...2020-02-03T15:56:23+01:00Torben MinyDataChecker: Add Test for correct storing of the `expecation`message and the additional `kwargs` parameters.Torben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/39base.Referable.parent is of type: Optional[Namespace]. XSD-schema expects par...2020-01-16T16:45:48+01:00Sebastian Heppners.heppner@iat.rwth-aachen.debase.Referable.parent is of type: Optional[Namespace]. XSD-schema expects parent to be of type="aas:reference_t"How to serialize this parameter in compliance with the schema?How to serialize this parameter in compliance with the schema?https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/38adapter: Create AASX file read- and write functionality2020-03-25T13:09:34+01:00Michael Thiesadapter: Create AASX file read- and write functionalityhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/37model.base.HasDataSpecification has parameter data_specification of type Set[...2020-01-07T13:27:10+01:00Sebastian Heppners.heppner@iat.rwth-aachen.demodel.base.HasDataSpecification has parameter data_specification of type Set[Reference]. XML-Serialization expects this to be just a Reference.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/36model.submodel.SubmodelElementCollection: class seems to miss parameters "all...2019-12-28T17:13:21+01:00Sebastian Heppners.heppner@iat.rwth-aachen.demodel.submodel.SubmodelElementCollection: class seems to miss parameters "allow_duplicate"Or is this something the serialization should be able to read from the specific object instance?Or is this something the serialization should be able to read from the specific object instance?https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/35XSD-Schema: missing `minOccurs="0"` in element `value` of `file_t`2020-05-28T12:04:31+02:00Sebastian Heppners.heppner@iat.rwth-aachen.deXSD-Schema: missing `minOccurs="0"` in element `value` of `file_t`Class `File` has attribute `value` with cardinality `0..1`:
![File](/uploads/40386615c5291583360b796f9f51cf07/File.png)
Therefore, the XSD-Schema should have a `minOccurs="0"` in the element defintion of `value` to comply with this.
C...Class `File` has attribute `value` with cardinality `0..1`:
![File](/uploads/40386615c5291583360b796f9f51cf07/File.png)
Therefore, the XSD-Schema should have a `minOccurs="0"` in the element defintion of `value` to comply with this.
Current Version:
```
<complexType name="file_t">
<complexContent>
<extension base="aas:submodelElementAbstract_t">
<sequence>
<element name="mimeType" type="string"/>
<element name="value" type="aas:pathType_t"/>
</sequence>
</extension>
</complexContent>
</complexType>
```
Proposed Fix:
```
<complexType name="file_t">
<complexContent>
<extension base="aas:submodelElementAbstract_t">
<sequence>
<element name="mimeType" type="string"/>
<element minOccurs="0" name="value" type="aas:pathType_t"/>
</sequence>
</extension>
</complexContent>
</complexType>
```https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/34example: Add example for modifying an existing AAS2020-01-31T09:52:14+01:00Michael Thiesexample: Add example for modifying an existing AASTorben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/33example: Add example for deserializing and serializing an AAS2020-01-31T09:52:28+01:00Michael Thiesexample: Add example for deserializing and serializing an AASTorben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/32example: Move example data generators into package examples.data2020-01-21T12:24:27+01:00Michael Thiesexample: Move example data generators into package examples.datahttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/31example: Add example for creating a simple AAS by hand2020-01-31T09:52:23+01:00Michael Thiesexample: Add example for creating a simple AAS by handTorben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/30JSON: Fix deserialization of Constraints2019-12-19T17:08:42+01:00Torben MinyJSON: Fix deserialization of ConstraintsJob [#583039](https://git.rwth-aachen.de/acplt/pyaas/-/jobs/583039) failed for 20f66fd7ddbbb0d0bf72c68f9520ced39eac9c62:Job [#583039](https://git.rwth-aachen.de/acplt/pyaas/-/jobs/583039) failed for 20f66fd7ddbbb0d0bf72c68f9520ced39eac9c62:https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/29model: Rename instance attributes to not contain trailing underscores2020-01-28T15:33:51+01:00Michael Thiesmodel: Rename instance attributes to not contain trailing underscoresTrailing underscores are nice for function parameters (including initializer parameters) to avoid name conflicts with global denominators (like module names and builtins). However, instance attributes form an own namespace and don't conf...Trailing underscores are nice for function parameters (including initializer parameters) to avoid name conflicts with global denominators (like module names and builtins). However, instance attributes form an own namespace and don't conflict with global denominators. Thus, trailing underscores are not required for them and I would prefer removing them to have less confusing attribute names.
However this should not be changed, before we merged the `features/json_adapter` branch.Leon Mauritz MöllerLeon Mauritz Möllerhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/28model: Operation should be a Namespace with three NameSpaceSets for its Opera...2021-01-12T13:42:15+01:00Michael Thiesmodel: Operation should be a Namespace with three NameSpaceSets for its OperationVariablesThis implementation has been reverted in https://git.rwth-aachen.de/acplt/pyi40aas/-/commit/0fee9b12537ed7b49ce3586d870bbc9cca93f636. We are currently awaiting feedback on this.
If this class stays in the metamodel, we could remove `Ope...This implementation has been reverted in https://git.rwth-aachen.de/acplt/pyi40aas/-/commit/0fee9b12537ed7b49ce3586d870bbc9cca93f636. We are currently awaiting feedback on this.
If this class stays in the metamodel, we could remove `OperationVariable` in our implementation and attach `SubmodelElement`s to the `Operation` directly, so we can make `Operation` a `Namespace`.
Adapters would then just "emulate" `OperationVariable`s.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/27model: View does not inherit from HasDataSpecification, HasSemantics, Referable2019-12-16T10:53:23+01:00Michael Thiesmodel: View does not inherit from HasDataSpecification, HasSemantics, Referablehttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/26model/adapter: Represent ValueDataType as native Python type2020-01-28T14:59:07+01:00Michael Thiesmodel/adapter: Represent ValueDataType as native Python typeProposal: Use native Python types for values (of Property, Qualifier, etc.) for easier programmatic handling of those values. We can choose the correct type at deserialization using the `valueType` attribute of those objects and re-creat...Proposal: Use native Python types for values (of Property, Qualifier, etc.) for easier programmatic handling of those values. We can choose the correct type at deserialization using the `valueType` attribute of those objects and re-create the `valueType` at serialization depending on the value's `type()`.
Then, we can throw away the `valueType` attribute (which is redundant to the `value` attribute's type) and probably replace it with a property, which would just return the `value`'s `xsd_name`.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/25model: Implement DataSpecificationIEC613602020-01-21T12:26:05+01:00Michael Thiesmodel: Implement DataSpecificationIEC61360https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/24Add package and module docstrings explaining what is contained in each packag...2019-12-20T15:12:45+01:00Michael ThiesAdd package and module docstrings explaining what is contained in each package/module and should go there* Module Docstrings should contain a description of the functionality the module provides (in an abstract way) and a short overview, how this functionality is implemented (e.g. which functions/classes do I typically need to use the funct...* Module Docstrings should contain a description of the functionality the module provides (in an abstract way) and a short overview, how this functionality is implemented (e.g. which functions/classes do I typically need to use the functionality and when should I look at the other functions/classes). The latter part might not be sensible for AAS model modules.
* Package docstrings should be added for the `aas` and the `aas.model` package and provide a high-level overview over the functionality the structure of this package, including the purpose of the single child modules/packages. It should answer the question: “which functionality regarding the AAS is implemented in the package and which (abstract) part of it can be found in which module?”. The docstring of `aas` might be overlapping with the README.md file, which should also explain the project structure.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/23Add ID-Generator2019-12-03T17:35:10+01:00Torben MinyAdd ID-Generator* [x] Generator for random unique IDs
* [x] Generator with URL-parameter to create unique IDs in this namespace, e.g. "acplt.org/AAS/" and then create "acplt.org/AAS/AAS1"* [x] Generator for random unique IDs
* [x] Generator with URL-parameter to create unique IDs in this namespace, e.g. "acplt.org/AAS/" and then create "acplt.org/AAS/AAS1"https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/22model.adapter: Serialization for XML2020-03-25T13:08:58+01:00Torben Minymodel.adapter: Serialization for XMLSebastian Heppners.heppner@iat.rwth-aachen.deSebastian Heppners.heppner@iat.rwth-aachen.dehttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/21model.adapter: Serialization for JSON2019-12-20T14:50:44+01:00Torben Minymodel.adapter: Serialization for JSONTorben MinyTorben Miny