Lehrstuhl für Informations- und Automatisierungssysteme issueshttps://git.rwth-aachen.de/groups/acplt/-/issues2019-12-20T15:12:45+01:00https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/24Add package and module docstrings explaining what is contained in each packag...2019-12-20T15:12:45+01:00Michael ThiesAdd package and module docstrings explaining what is contained in each package/module and should go there* Module Docstrings should contain a description of the functionality the module provides (in an abstract way) and a short overview, how this functionality is implemented (e.g. which functions/classes do I typically need to use the funct...* Module Docstrings should contain a description of the functionality the module provides (in an abstract way) and a short overview, how this functionality is implemented (e.g. which functions/classes do I typically need to use the functionality and when should I look at the other functions/classes). The latter part might not be sensible for AAS model modules.
* Package docstrings should be added for the `aas` and the `aas.model` package and provide a high-level overview over the functionality the structure of this package, including the purpose of the single child modules/packages. It should answer the question: “which functionality regarding the AAS is implemented in the package and which (abstract) part of it can be found in which module?”. The docstring of `aas` might be overlapping with the README.md file, which should also explain the project structure.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/36model.submodel.SubmodelElementCollection: class seems to miss parameters "all...2019-12-28T17:13:21+01:00Sebastian Heppners.heppner@iat.rwth-aachen.demodel.submodel.SubmodelElementCollection: class seems to miss parameters "allow_duplicate"Or is this something the serialization should be able to read from the specific object instance?Or is this something the serialization should be able to read from the specific object instance?https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/37model.base.HasDataSpecification has parameter data_specification of type Set[...2020-01-07T13:27:10+01:00Sebastian Heppners.heppner@iat.rwth-aachen.demodel.base.HasDataSpecification has parameter data_specification of type Set[Reference]. XML-Serialization expects this to be just a Reference.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/39base.Referable.parent is of type: Optional[Namespace]. XSD-schema expects par...2020-01-16T16:45:48+01:00Sebastian Heppners.heppner@iat.rwth-aachen.debase.Referable.parent is of type: Optional[Namespace]. XSD-schema expects parent to be of type="aas:reference_t"How to serialize this parameter in compliance with the schema?How to serialize this parameter in compliance with the schema?https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/32example: Move example data generators into package examples.data2020-01-21T12:24:27+01:00Michael Thiesexample: Move example data generators into package examples.datahttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/25model: Implement DataSpecificationIEC613602020-01-21T12:26:05+01:00Michael Thiesmodel: Implement DataSpecificationIEC61360https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/26model/adapter: Represent ValueDataType as native Python type2020-01-28T14:59:07+01:00Michael Thiesmodel/adapter: Represent ValueDataType as native Python typeProposal: Use native Python types for values (of Property, Qualifier, etc.) for easier programmatic handling of those values. We can choose the correct type at deserialization using the `valueType` attribute of those objects and re-creat...Proposal: Use native Python types for values (of Property, Qualifier, etc.) for easier programmatic handling of those values. We can choose the correct type at deserialization using the `valueType` attribute of those objects and re-create the `valueType` at serialization depending on the value's `type()`.
Then, we can throw away the `valueType` attribute (which is redundant to the `value` attribute's type) and probably replace it with a property, which would just return the `value`'s `xsd_name`.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/29model: Rename instance attributes to not contain trailing underscores2020-01-28T15:33:51+01:00Michael Thiesmodel: Rename instance attributes to not contain trailing underscoresTrailing underscores are nice for function parameters (including initializer parameters) to avoid name conflicts with global denominators (like module names and builtins). However, instance attributes form an own namespace and don't conf...Trailing underscores are nice for function parameters (including initializer parameters) to avoid name conflicts with global denominators (like module names and builtins). However, instance attributes form an own namespace and don't conflict with global denominators. Thus, trailing underscores are not required for them and I would prefer removing them to have less confusing attribute names.
However this should not be changed, before we merged the `features/json_adapter` branch.Leon Mauritz MöllerLeon Mauritz Möllerhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/42Tests: Add tests for data.examples2020-01-30T09:56:53+01:00Torben MinyTests: Add tests for data.exampleshttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/41Make imports relative if possible2020-01-30T13:46:51+01:00Torben MinyMake imports relative if possiblehttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/34example: Add example for modifying an existing AAS2020-01-31T09:52:14+01:00Michael Thiesexample: Add example for modifying an existing AASTorben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/31example: Add example for creating a simple AAS by hand2020-01-31T09:52:23+01:00Michael Thiesexample: Add example for creating a simple AAS by handTorben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/33example: Add example for deserializing and serializing an AAS2020-01-31T09:52:28+01:00Michael Thiesexample: Add example for deserializing and serializing an AASTorben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/45NamespaceSet: It should be allowed to insert an Referable with the same id_sh...2020-02-03T15:15:11+01:00Torben MinyNamespaceSet: It should be allowed to insert an Referable with the same id_short in another NamespaceSet of the same objectAt the moment it is not possible to add a concept dictionary and a view with the same id_short to the asset administration shellAt the moment it is not possible to add a concept dictionary and a view with the same id_short to the asset administration shellhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/46Test: assertRaises should not only check ErrorType but also the message to be...2020-02-03T15:56:23+01:00Torben MinyTest: assertRaises should not only check ErrorType but also the message to be sure the right exepction is raisedhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/40DataChecker: Add Test for correct storing of the `expecation`message and the ...2020-02-03T15:56:23+01:00Torben MinyDataChecker: Add Test for correct storing of the `expecation`message and the additional `kwargs` parameters.Torben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/52XSD-Schema: missing minOccurs="0" of element `containedElements` in type `vie...2020-02-25T08:06:23+01:00Sebastian Heppners.heppner@iat.rwth-aachen.deXSD-Schema: missing minOccurs="0" of element `containedElements` in type `view_t`Class `view` has parameter `containedElements`:
![View](/uploads/0514057d047dd557cbf2dbceb92b0fec/View.png)
of cardinality 0..*
The XSD-Schema therefore needs a `minOccurs="0"`in element `<containedElements>`.
Current version:
```
<c...Class `view` has parameter `containedElements`:
![View](/uploads/0514057d047dd557cbf2dbceb92b0fec/View.png)
of cardinality 0..*
The XSD-Schema therefore needs a `minOccurs="0"`in element `<containedElements>`.
Current version:
```
<complexType name="view_t">
<sequence>
<group ref="aas:referable"/>
<group ref="aas:hasSemantics"/>
<group ref="aas:hasDataSpecification"/>
<element name="containedElements" type="aas:containedElements_t" ></element>
</sequence>
</complexType>
```
Proposed Fix:
```
<complexType name="view_t">
<sequence>
<group ref="aas:referable"/>
<group ref="aas:hasSemantics"/>
<group ref="aas:hasDataSpecification"/>
<element maxOccurs="unbounded" minOccurs="0" name="containedElements" type="aas:containedElements_t"/>
</sequence>
</complexType>
```https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/51XSD-Schema: missing minOccurs="0" of element "conceptDescriptionRefs" in type...2020-02-25T14:19:35+01:00Sebastian Heppners.heppner@iat.rwth-aachen.deXSD-Schema: missing minOccurs="0" of element "conceptDescriptionRefs" in type "conceptDictionary_t"Class `ConceptDictionary` has parameter `conceptDescription`: ![conceptDictionary](/uploads/a32d03ee11104052db45680c98650ea4/conceptDictionary.png) of cardinality 0..*.
The XSD-schema therefore needs a `minOccurs="0"`in element `<concep...Class `ConceptDictionary` has parameter `conceptDescription`: ![conceptDictionary](/uploads/a32d03ee11104052db45680c98650ea4/conceptDictionary.png) of cardinality 0..*.
The XSD-schema therefore needs a `minOccurs="0"`in element `<conceptDescriptionRefs>`.
Current Version:
```
<complexType name="conceptDictionary_t">
<sequence>
<group ref="aas:referable" />
<element name="conceptDescriptionRefs" type="aas:conceptDescriptionRefs_t"></element>
</sequence>
</complexType>
```
Suggested Fix:
```
<complexType name="conceptDictionary_t">
<sequence>
<group ref="aas:referable" />
<element maxOccurs="unbounded" minOccurs="0" name="conceptDescriptionRefs" type="aas:conceptDescriptionRefs_t"/>
</sequence>
</complexType>
```https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/43json package docstring: missing description of deserialization.py2020-02-28T15:06:05+01:00Torben Minyjson package docstring: missing description of deserialization.pyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/22model.adapter: Serialization for XML2020-03-25T13:08:58+01:00Torben Minymodel.adapter: Serialization for XMLSebastian Heppners.heppner@iat.rwth-aachen.deSebastian Heppners.heppner@iat.rwth-aachen.de