citygml-energy issueshttps://git.rwth-aachen.de/energyade/citygml-energy/-/issues2015-03-02T22:50:21+01:00https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/19Glazing should derive from AbstractMaterial and not LayerComponent2015-03-02T22:50:21+01:00Moritz Robert LausterGlazing should derive from AbstractMaterial and not LayerComponent*Created by: oliviertournaire*
*Created by: oliviertournaire*
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/10Usage of temporal data types2015-03-02T22:48:47+01:00Moritz Robert LausterUsage of temporal data types*Created by: oliviertournaire*
[Thanks to Joachim Benner for reporting this issue]
The UML model uses a lot of types for time instances (TM_ClockTime, TimePositionType) and time periods (TimePeriod, TimeIntervalLengthType). Some of them...*Created by: oliviertournaire*
[Thanks to Joachim Benner for reporting this issue]
The UML model uses a lot of types for time instances (TM_ClockTime, TimePositionType) and time periods (TimePeriod, TimeIntervalLengthType). Some of them may not be recognized by ShapeChange. We thus have to ensure that in the generated XSD schema, attributes using these types are correctly defined. The while model has to be checked.
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/9Missing attributes type2015-03-02T22:48:26+01:00Moritz Robert LausterMissing attributes type*Created by: oliviertournaire*
[Thanks to Joachim Benner for reporting this issue]
Some attributes have no type. This is due to a bad specification in the UML model. Can be fixed by correcting types in the UML model and / or by setting ...*Created by: oliviertournaire*
[Thanks to Joachim Benner for reporting this issue]
Some attributes have no type. This is due to a bad specification in the UML model. Can be fixed by correcting types in the UML model and / or by setting proper conversion rules in ShapeChange configuration files.
Here is a list (might not be exhaustive) of the types that have to be changed:
- MeasureType --> Measure
- LengthType --> Length
- AreaType --> Area
- VolumeType --> Volume
- boolean --> Boolean
- Int --> Integer
- ScaleType --> Scale
- UomIdentifier --> Measure
- AngleType --> Angle
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/16Use correct CityGML class names2015-03-02T22:46:03+01:00Moritz Robert LausterUse correct CityGML class names*Created by: oliviertournaire*
Some classes do not have a correct name. For instance `AbstractBuilding` should be `_AbstractBuilding`.
The easiest way is to change names of classes used in the model to their correct version.
*Created by: oliviertournaire*
Some classes do not have a correct name. For instance `AbstractBuilding` should be `_AbstractBuilding`.
The easiest way is to change names of classes used in the model to their correct version.
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/8The codeSpace attribute in code lists is 1.02015-03-02T22:44:22+01:00Moritz Robert LausterThe codeSpace attribute in code lists is 1.0*Created by: 900k*
The codelists still refere to codeSpace 1.0. Please ensure that the current version is injected in the codelists.
*Created by: 900k*
The codelists still refere to codeSpace 1.0. Please ensure that the current version is injected in the codelists.
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/11ADEElement _BoundarySurface2015-03-02T22:28:19+01:00Moritz Robert LausterADEElement _BoundarySurface*Created by: oliviertournaire*
In the current model, an abstract class `_BoudarySurface` with the stereotype `ADEElement` exists. It derives from `Building:AbstractBoundarySurface`.
Some clarification are required:
1. If we want to cre...*Created by: oliviertournaire*
In the current model, an abstract class `_BoudarySurface` with the stereotype `ADEElement` exists. It derives from `Building:AbstractBoundarySurface`.
Some clarification are required:
1. If we want to create a class (i.e. a type) in the ADE which derives from `Building:AbstractBoundarySurface`, it should be done in another way (see image below)
2. The name of the derived class, if it has the stereotype `ADEElement` must have the **same name as its base class** (i.e. `AbstractBoundarySurface`)
![ade1](https://cloud.githubusercontent.com/assets/1990302/6414473/01d57a3a-be98-11e4-9823-8c4382c6d9b0.png)
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/12ADEElement _Opening2015-03-02T22:27:59+01:00Moritz Robert LausterADEElement _Opening*Created by: oliviertournaire*
In the current model, an abstract class `_Opening` with the stereotype `ADEElement` exists. It derives from `Building:AbstractOpening`.
Some clarification are required:
1. If we want to create a class (i....*Created by: oliviertournaire*
In the current model, an abstract class `_Opening` with the stereotype `ADEElement` exists. It derives from `Building:AbstractOpening`.
Some clarification are required:
1. If we want to create a class (i.e. a type) in the ADE which derives from `Building:AbstractOpening`, it should be done in another way (see image below)
2. The name of the derived class, if it has the stereotype `ADEElement` must have the **same name as its base class** (i.e. `AbstractOpening`)
![ade1](https://cloud.githubusercontent.com/assets/1990302/6414473/01d57a3a-be98-11e4-9823-8c4382c6d9b0.png)
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/21Repair Materials ADE2015-03-02T22:23:57+01:00Moritz Robert LausterRepair Materials ADE*Created by: 900k*
Hi Olivier,
could you please change back some modifications of the Materials ADE which Romain introduced lately? Currently, the "Glazing" is a subclass of "LayerComponent", but it should be a subclass of "AbstractMat...*Created by: 900k*
Hi Olivier,
could you please change back some modifications of the Materials ADE which Romain introduced lately? Currently, the "Glazing" is a subclass of "LayerComponent", but it should be a subclass of "AbstractMaterial". Additionally, please change the class name of "SolidMaterial" back to "OpaqueMaterial".
Thank you very much!
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/13Why an ADEElement _CityObject is defined2015-03-02T22:21:09+01:00Moritz Robert LausterWhy an ADEElement _CityObject is defined*Created by: oliviertournaire*
I was wondering why we have defined a `_CityObject ADEElement` in the UML model. Why do not we use directly the `core:AbstractCityObject`? Can you explain?
Note that is issue is related to issues #11 and ...*Created by: oliviertournaire*
I was wondering why we have defined a `_CityObject ADEElement` in the UML model. Why do not we use directly the `core:AbstractCityObject`? Can you explain?
Note that is issue is related to issues #11 and #12
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/1Add a license file2015-02-18T23:20:08+01:00Moritz Robert LausterAdd a license file*Created by: oliviertournaire*
Is it necessary? CityGML does not provide any license file
*Created by: oliviertournaire*
Is it necessary? CityGML does not provide any license file
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/7Check cardinalities2015-02-05T13:40:34+01:00Moritz Robert LausterCheck cardinalities*Created by: oliviertournaire*
It seems that cardinalities on relationships are not well handled when converting from UML to XSD. They thus need to be checked carefully.
*Created by: oliviertournaire*
It seems that cardinalities on relationships are not well handled when converting from UML to XSD. They thus need to be checked carefully.
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/3Create references via xlinks2015-02-02T12:06:11+01:00Moritz Robert LausterCreate references via xlinks*Created by: oliviertournaire*
It seems that it is not possible to create references to existing elements via xlinks. Need to be fixed for first release
*Created by: oliviertournaire*
It seems that it is not possible to create references to existing elements via xlinks. Need to be fixed for first release
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/4Missing "boundedBy" role in ThermalZoneType2015-02-02T12:05:25+01:00Moritz Robert LausterMissing "boundedBy" role in ThermalZoneType*Created by: oliviertournaire*
From Marcel Bruse:
"I cannot create ThermalBoundarySurfaces underneath ThermalZones. The "boundedBy" role is missing in ThermalZoneType."
*Created by: oliviertournaire*
From Marcel Bruse:
"I cannot create ThermalBoundarySurfaces underneath ThermalZones. The "boundedBy" role is missing in ThermalZoneType."
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/6Add 'constructionOrientation' name to association between '<<ADEElement>> _Ci...2015-02-02T12:04:00+01:00Moritz Robert LausterAdd 'constructionOrientation' name to association between '<<ADEElement>> _CityObject' and 'ConstructionOrientation'*Created by: oliviertournaire*
From Marcel Bruse:
"I'm not able to create a construction or constructionOrientation underneath a roof surface (I suppose it doesn't work for any BoundarySurface). Please check if it works for buildings an...*Created by: oliviertournaire*
From Marcel Bruse:
"I'm not able to create a construction or constructionOrientation underneath a roof surface (I suppose it doesn't work for any BoundarySurface). Please check if it works for buildings and buildings parts, too."
v0.4.3