citygml-energy issueshttps://git.rwth-aachen.de/energyade/citygml-energy/-/issues2016-01-14T13:55:55+01:00https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/28Verbose definition of energy:values in RegularTimeSeries type2016-01-14T13:55:55+01:00Moritz Robert LausterVerbose definition of energy:values in RegularTimeSeries type*Created by: 900k*
While writing an updated sample file for v0.5 I find it superfluous to have an opening and closing tag for each value of a time series. For 12 monthly values you will end up with this ...
```
<energy:values>
66.5...*Created by: 900k*
While writing an updated sample file for v0.5 I find it superfluous to have an opening and closing tag for each value of a time series. For 12 monthly values you will end up with this ...
```
<energy:values>
66.5
</energy:values>
<energy:values>
66.5
</energy:values>
<energy:values>
39.9
</energy:values>
...
<energy:values>
66.5
</energy:values>
```
I suggest to define the values element in such a way so that instances of it look like this ...
```
<energy:values>
66.5 66.5 39.9 26.6 26.6 13.3 13.3 26.6 26.6 39.9 66.5 66.5
</energy:values>
```
v0.6.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/19Glazing should derive from AbstractMaterial and not LayerComponent2015-03-02T22:50:21+01:00Moritz Robert LausterGlazing should derive from AbstractMaterial and not LayerComponent*Created by: oliviertournaire*
*Created by: oliviertournaire*
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/14Cardinalities missing for Construction and ConstructionOrientation2015-03-03T00:51:28+01:00Moritz Robert LausterCardinalities missing for Construction and ConstructionOrientation*Created by: oliviertournaire*
*Created by: oliviertournaire*
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/29Concrete types EnergyConversionSystem and EnergyDistributionSystem?2015-10-23T13:33:16+02:00Moritz Robert LausterConcrete types EnergyConversionSystem and EnergyDistributionSystem?*Created by: 900k*
Shouldn't the types EnergyConversionSystem and EnergyDistributionSystem be abstract?
*Created by: 900k*
Shouldn't the types EnergyConversionSystem and EnergyDistributionSystem be abstract?
v0.6.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/16Use correct CityGML class names2015-03-02T22:46:03+01:00Moritz Robert LausterUse correct CityGML class names*Created by: oliviertournaire*
Some classes do not have a correct name. For instance `AbstractBuilding` should be `_AbstractBuilding`.
The easiest way is to change names of classes used in the model to their correct version.
*Created by: oliviertournaire*
Some classes do not have a correct name. For instance `AbstractBuilding` should be `_AbstractBuilding`.
The easiest way is to change names of classes used in the model to their correct version.
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/3Create references via xlinks2015-02-02T12:06:11+01:00Moritz Robert LausterCreate references via xlinks*Created by: oliviertournaire*
It seems that it is not possible to create references to existing elements via xlinks. Need to be fixed for first release
*Created by: oliviertournaire*
It seems that it is not possible to create references to existing elements via xlinks. Need to be fixed for first release
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/11ADEElement _BoundarySurface2015-03-02T22:28:19+01:00Moritz Robert LausterADEElement _BoundarySurface*Created by: oliviertournaire*
In the current model, an abstract class `_BoudarySurface` with the stereotype `ADEElement` exists. It derives from `Building:AbstractBoundarySurface`.
Some clarification are required:
1. If we want to cre...*Created by: oliviertournaire*
In the current model, an abstract class `_BoudarySurface` with the stereotype `ADEElement` exists. It derives from `Building:AbstractBoundarySurface`.
Some clarification are required:
1. If we want to create a class (i.e. a type) in the ADE which derives from `Building:AbstractBoundarySurface`, it should be done in another way (see image below)
2. The name of the derived class, if it has the stereotype `ADEElement` must have the **same name as its base class** (i.e. `AbstractBoundarySurface`)
![ade1](https://cloud.githubusercontent.com/assets/1990302/6414473/01d57a3a-be98-11e4-9823-8c4382c6d9b0.png)
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/8The codeSpace attribute in code lists is 1.02015-03-02T22:44:22+01:00Moritz Robert LausterThe codeSpace attribute in code lists is 1.0*Created by: 900k*
The codelists still refere to codeSpace 1.0. Please ensure that the current version is injected in the codelists.
*Created by: 900k*
The codelists still refere to codeSpace 1.0. Please ensure that the current version is injected in the codelists.
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/15Split diagram2016-01-14T14:05:39+01:00Moritz Robert LausterSplit diagram*Created by: oliviertournaire*
The diagram is pretty big and thus should be divided in several parts:
- Occupancy
- Material
- Energy systems
- Core
- ...
*Created by: oliviertournaire*
The diagram is pretty big and thus should be divided in several parts:
- Occupancy
- Material
- Energy systems
- Core
- ...
v0.6.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/10Usage of temporal data types2015-03-02T22:48:47+01:00Moritz Robert LausterUsage of temporal data types*Created by: oliviertournaire*
[Thanks to Joachim Benner for reporting this issue]
The UML model uses a lot of types for time instances (TM_ClockTime, TimePositionType) and time periods (TimePeriod, TimeIntervalLengthType). Some of them...*Created by: oliviertournaire*
[Thanks to Joachim Benner for reporting this issue]
The UML model uses a lot of types for time instances (TM_ClockTime, TimePositionType) and time periods (TimePeriod, TimeIntervalLengthType). Some of them may not be recognized by ShapeChange. We thus have to ensure that in the generated XSD schema, attributes using these types are correctly defined. The while model has to be checked.
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/9Missing attributes type2015-03-02T22:48:26+01:00Moritz Robert LausterMissing attributes type*Created by: oliviertournaire*
[Thanks to Joachim Benner for reporting this issue]
Some attributes have no type. This is due to a bad specification in the UML model. Can be fixed by correcting types in the UML model and / or by setting ...*Created by: oliviertournaire*
[Thanks to Joachim Benner for reporting this issue]
Some attributes have no type. This is due to a bad specification in the UML model. Can be fixed by correcting types in the UML model and / or by setting proper conversion rules in ShapeChange configuration files.
Here is a list (might not be exhaustive) of the types that have to be changed:
- MeasureType --> Measure
- LengthType --> Length
- AreaType --> Area
- VolumeType --> Volume
- boolean --> Boolean
- Int --> Integer
- ScaleType --> Scale
- UomIdentifier --> Measure
- AngleType --> Angle
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/12ADEElement _Opening2015-03-02T22:27:59+01:00Moritz Robert LausterADEElement _Opening*Created by: oliviertournaire*
In the current model, an abstract class `_Opening` with the stereotype `ADEElement` exists. It derives from `Building:AbstractOpening`.
Some clarification are required:
1. If we want to create a class (i....*Created by: oliviertournaire*
In the current model, an abstract class `_Opening` with the stereotype `ADEElement` exists. It derives from `Building:AbstractOpening`.
Some clarification are required:
1. If we want to create a class (i.e. a type) in the ADE which derives from `Building:AbstractOpening`, it should be done in another way (see image below)
2. The name of the derived class, if it has the stereotype `ADEElement` must have the **same name as its base class** (i.e. `AbstractOpening`)
![ade1](https://cloud.githubusercontent.com/assets/1990302/6414473/01d57a3a-be98-11e4-9823-8c4382c6d9b0.png)
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/7Check cardinalities2015-02-05T13:40:34+01:00Moritz Robert LausterCheck cardinalities*Created by: oliviertournaire*
It seems that cardinalities on relationships are not well handled when converting from UML to XSD. They thus need to be checked carefully.
*Created by: oliviertournaire*
It seems that cardinalities on relationships are not well handled when converting from UML to XSD. They thus need to be checked carefully.
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/5Glazing featureType bad inheritance2015-03-03T00:51:28+01:00Moritz Robert LausterGlazing featureType bad inheritance*Created by: oliviertournaire*
From Romain Nouvel:
"The featureType Glazing (which may have several glazes and gas gapes) is actually not a "Material" but a 'LayerComponent'. Then, it should not inherit from 'AbstractMaterial' but from ...*Created by: oliviertournaire*
From Romain Nouvel:
"The featureType Glazing (which may have several glazes and gas gapes) is actually not a "Material" but a 'LayerComponent'. Then, it should not inherit from 'AbstractMaterial' but from 'LayerComponent'. Following that, the 'OpaqueMaterial' object should be renamed as 'SolidMaterial' (with the same parameters, at less for the first release)."
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/1Add a license file2015-02-18T23:20:08+01:00Moritz Robert LausterAdd a license file*Created by: oliviertournaire*
Is it necessary? CityGML does not provide any license file
*Created by: oliviertournaire*
Is it necessary? CityGML does not provide any license file
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/6Add 'constructionOrientation' name to association between '<<ADEElement>> _Ci...2015-02-02T12:04:00+01:00Moritz Robert LausterAdd 'constructionOrientation' name to association between '<<ADEElement>> _CityObject' and 'ConstructionOrientation'*Created by: oliviertournaire*
From Marcel Bruse:
"I'm not able to create a construction or constructionOrientation underneath a roof surface (I suppose it doesn't work for any BoundarySurface). Please check if it works for buildings an...*Created by: oliviertournaire*
From Marcel Bruse:
"I'm not able to create a construction or constructionOrientation underneath a roof surface (I suppose it doesn't work for any BoundarySurface). Please check if it works for buildings and buildings parts, too."
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/4Missing "boundedBy" role in ThermalZoneType2015-02-02T12:05:25+01:00Moritz Robert LausterMissing "boundedBy" role in ThermalZoneType*Created by: oliviertournaire*
From Marcel Bruse:
"I cannot create ThermalBoundarySurfaces underneath ThermalZones. The "boundedBy" role is missing in ThermalZoneType."
*Created by: oliviertournaire*
From Marcel Bruse:
"I cannot create ThermalBoundarySurfaces underneath ThermalZones. The "boundedBy" role is missing in ThermalZoneType."
v0.4.3https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/2Update README.md2015-03-12T13:53:17+01:00Moritz Robert LausterUpdate README.md*Created by: oliviertournaire*
The current README.md file is incomplete
- Add authors
- Add description
*Created by: oliviertournaire*
The current README.md file is incomplete
- Add authors
- Add description
0.5.0https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/176windDirection as WeatherDataTypeValue2022-12-07T15:54:10+01:00Giuseppe PeronatowindDirection as WeatherDataTypeValueWind direction is crucial to calculate Heat Transfer Coefficients for each surface and is normally contained in weather files for Building Performance Simulations. However, this parameter is not part of the Enumeration **WeatherDataTypeV...Wind direction is crucial to calculate Heat Transfer Coefficients for each surface and is normally contained in weather files for Building Performance Simulations. However, this parameter is not part of the Enumeration **WeatherDataTypeValue**.
In my opinion, the arguments against a soilTemperature parameter (see https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/154) do not apply in this case, as the wind direction is a basic parameter in weather stations and does not need a specific model.
I would then propose to extend the Enumeration **WeatherDataTypeValue** with a new item **windDirection**.https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/175Missing Inclination and Azimuth attributes for SolarEnergySystems2021-06-17T16:05:04+02:00Giorgio AgugiaroMissing Inclination and Azimuth attributes for SolarEnergySystemsAs of Energy ADE v. 1.0, we can optionally store the geometry of the (solar/PV/...) panels. In that case, azimuth and tilting angles can be derived from geometry. But if we do not have geometry (which sometime happens...), we have no way...As of Energy ADE v. 1.0, we can optionally store the geometry of the (solar/PV/...) panels. In that case, azimuth and tilting angles can be derived from geometry. But if we do not have geometry (which sometime happens...), we have no way to store those attributes.
I'd propose to add them (back) again.
Any comments?