From 949191b3a98c20f2d0f35ef2845e6ad1aa9ed164 Mon Sep 17 00:00:00 2001
From: Markus Baumeister <markus.baumeister1@rwth-aachen.de>
Date: Mon, 20 Aug 2018 15:33:50 +0200
Subject: [PATCH] Remove RamifiedPolygonalSurface and RamifiedSimplicialSurface
---
Changelog | 3 ++-
gap/PolygonalComplexes/main.gi | 4 ----
gap/PolygonalComplexes/polygonal_hierarchy.gi | 12 ------------
gap/categories_families.gd | 6 ------
unit_tests/Test_BorderCases_PolygonalComplex.g | 2 --
5 files changed, 2 insertions(+), 25 deletions(-)
diff --git a/Changelog b/Changelog
index 3f0c6e31..23e0be9e 100644
--- a/Changelog
+++ b/Changelog
@@ -15,5 +15,6 @@ Changes from master to rewrite:
9) Rename IsIsomorphicPolygonalComplex to IsIsomorphic
10) Rename PolygonalComplexIsomorphismRepresentatives to
IsomorphismRepresentatives
-11)
+11) RamifiedPolygonalSurface and RamifiedSimplicialSurface are no longer
+ available. Please use IsNotEdgeRamified instead.
diff --git a/gap/PolygonalComplexes/main.gi b/gap/PolygonalComplexes/main.gi
index 7ff7e906..f572c10c 100644
--- a/gap/PolygonalComplexes/main.gi
+++ b/gap/PolygonalComplexes/main.gi
@@ -199,10 +199,6 @@ BindGlobal( "__SIMPLICIAL_PolygonalComplexName",
return nameList[1];
elif IsPolygonalSurface(complex) then
return nameList[2];
- elif IsRamifiedSimplicialSurface(complex) then
- return nameList[3];
- elif IsRamifiedPolygonalSurface(complex) then
- return nameList[4];
elif IsTriangularComplex(complex) then
return nameList[5];
else
diff --git a/gap/PolygonalComplexes/polygonal_hierarchy.gi b/gap/PolygonalComplexes/polygonal_hierarchy.gi
index fa749b2e..260f1697 100644
--- a/gap/PolygonalComplexes/polygonal_hierarchy.gi
+++ b/gap/PolygonalComplexes/polygonal_hierarchy.gi
@@ -33,8 +33,6 @@ BindGlobal( "BendPolygonalComplexType",
##
## All of the filters
## * IsTriangularComplex
-## * IsRamifiedPolygonalSurface
-## * IsRamifiedSimplicialSurface
## * IsPolygonalSurface
## * IsSimplicialSurface
## should act like categories
@@ -58,16 +56,6 @@ InstallOtherMethod( IsTriangularComplex, "for an object", [IsObject],
TryNextMethod();
end
);
-InstallOtherMethod( IsRamifiedPolygonalSurface, "for an object", [IsObject],
- function(obj)
- if not IsPolygonalComplex(obj) then
- return false;
- fi;
- # Since IsPolygonalComplex is a category, the above
- # check can't change anything
- TryNextMethod();
- end
-);
InstallOtherMethod( IsPolygonalSurface, "for an object", [IsObject],
function(obj)
if not IsPolygonalComplex(obj) then
diff --git a/gap/categories_families.gd b/gap/categories_families.gd
index 840e2c47..9370da69 100644
--- a/gap/categories_families.gd
+++ b/gap/categories_families.gd
@@ -59,12 +59,6 @@ DeclareSynonym( "IsTriangularComplex", IsPolygonalComplex and IsTriangular );
DeclareSynonym( "IsSimplicialSurface", IsPolygonalSurface and IsTriangular );
-DeclareProperty( "IsRamifiedPolygonalSurface", IsPolygonalComplex); #TODO replace by surface def
-InstallTrueMethod( IsPolygonalComplex, IsRamifiedPolygonalSurface );
-DeclareSynonym( "IsRamifiedSimplicialSurface",
- IsRamifiedPolygonalSurface and IsTriangularComplex);
-
-
#######################################
##
diff --git a/unit_tests/Test_BorderCases_PolygonalComplex.g b/unit_tests/Test_BorderCases_PolygonalComplex.g
index de6bbd10..138e990d 100644
--- a/unit_tests/Test_BorderCases_PolygonalComplex.g
+++ b/unit_tests/Test_BorderCases_PolygonalComplex.g
@@ -189,8 +189,6 @@ BindGlobal( "__SIMPLICIAL_Test_PolygonalHierarchy", function()
x := 5;
Assert(0, not IsPolygonalComplex(x));
Assert(0, not IsTriangularComplex(x));
- Assert(0, not IsRamifiedPolygonalSurface(x));
- Assert(0, not IsRamifiedSimplicialSurface(x));
Assert(0, not IsPolygonalSurface(x));
Assert(0, not IsSimplicialSurface(x));
end);
--
GitLab