astrotools issueshttps://git.rwth-aachen.de/astro/astrotools/-/issues2018-04-10T16:58:40+02:00https://git.rwth-aachen.de/astro/astrotools/-/issues/15Fix stupid gamale bug2018-04-10T16:58:40+02:00Marcus WirtzFix stupid gamale bugv1.0Martin UrbanMartin Urbanhttps://git.rwth-aachen.de/astro/astrotools/-/issues/11Astrotools lon / lat definition false documentation2018-04-10T16:58:53+02:00Marcus WirtzAstrotools lon / lat definition false documentationLatitude is defined in the astrotools as [0, pi] with 0 pointing in z-direction. This is wrongly defined in markdown and probably in WIKI.Latitude is defined in the astrotools as [0, pi] with 0 pointing in z-direction. This is wrongly defined in markdown and probably in WIKI.v1.0Martin UrbanMartin Urbanhttps://git.rwth-aachen.de/astro/astrotools/-/issues/12coord exposure_equatorial mixes degrees and radians2018-04-10T16:59:12+02:00Martin Urbancoord exposure_equatorial mixes degrees and radianscoord.exposure_equatorial() mixes degrees and radians although astrotools use radians internally.coord.exposure_equatorial() mixes degrees and radians although astrotools use radians internally.v1.0Marcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/10inconstistent return values for fisher_pdf and exposure_pdf2018-04-10T16:59:24+02:00Martin Urbaninconstistent return values for fisher_pdf and exposure_pdfthe fisher_pdf function returns a tuple consisting of pixels and corresponding values and the exposure pdf return an array of length npix with the corresponding values. returning the full array is the more intuitive behaviour. This issue...the fisher_pdf function returns a tuple consisting of pixels and corresponding values and the exposure pdf return an array of length npix with the corresponding values. returning the full array is the more intuitive behaviour. This issue relates to https://git.rwth-aachen.de/astro/astrotools/blob/dff13db83fb3453872befc8303904c4d19b3d726/astrotools/healpytools.py#L256-307v1.0Marcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/9Fix bug in Cosmic Ray class (ref unittest)2018-04-10T16:59:33+02:00Marcus WirtzFix bug in Cosmic Ray class (ref unittest)v1.0Martin UrbanMartin Urbanhttps://git.rwth-aachen.de/astro/astrotools/-/issues/6Unittest for 2pt auto correlation2018-04-10T16:59:43+02:00Marcus WirtzUnittest for 2pt auto correlationImplement unittest for 2pt auto correlation in module obs.pyImplement unittest for 2pt auto correlation in module obs.pyv1.0Marcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/7Linting for obs.py2018-04-10T16:59:53+02:00Martin UrbanLinting for obs.pyHere several things are to be done
* [x] Activate linting for obs.py in the pipeline. Already prepared in line 23 in gitlab-ci
* [x] Lint the file obs.py according to our linting rules. Before committing you should check that everythin...Here several things are to be done
* [x] Activate linting for obs.py in the pipeline. Already prepared in line 23 in gitlab-ci
* [x] Lint the file obs.py according to our linting rules. Before committing you should check that everything works with `pylint astrotools/obs.py` which should automatically use the `.pylintrc` in the repository.v1.0Paula BigalkePaula Bigalkehttps://git.rwth-aachen.de/astro/astrotools/-/issues/4Implement simple EEC unittest2018-04-10T17:00:07+02:00Marcus WirtzImplement simple EEC unittestv1.0Paula BigalkePaula Bigalke2018-02-28https://git.rwth-aachen.de/astro/astrotools/-/issues/5Think about: Join gamale_sparse and gamale2018-04-10T17:00:17+02:00Marcus WirtzThink about: Join gamale_sparse and gamalegamale speichert auch schon im csc Format. Was ist der Vorteil von gamale_sparse? Können wir beides geschickt zusammenbringen?gamale speichert auch schon im csc Format. Was ist der Vorteil von gamale_sparse? Können wir beides geschickt zusammenbringen?v1.0Martin UrbanMartin Urbanhttps://git.rwth-aachen.de/astro/astrotools/-/issues/1Unittest for gamale.py module is not working2018-04-10T17:00:35+02:00Marcus WirtzUnittest for gamale.py module is not workingUnittest for gamale.py module is not working. Fix it!Unittest for gamale.py module is not working. Fix it!v1.0Marcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/3Implement Unittest for gamale.py2018-04-10T17:01:20+02:00Marcus WirtzImplement Unittest for gamale.pyv1.0Marcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/14Implement function Mass2Charge.stable() in nucleitools2018-04-11T16:04:34+02:00Marcus WirtzImplement function Mass2Charge.stable() in nucleitoolsv1.0Teresa Karolin Bisterteresa.bister@gmail.comTeresa Karolin Bisterteresa.bister@gmail.comhttps://git.rwth-aachen.de/astro/astrotools/-/issues/2Feature request: Analytical composition which is energy dependent2018-04-11T16:04:44+02:00Marcus WirtzFeature request: Analytical composition which is energy dependentImplement a function in auger.py that sample charges for the cosmic rays as a function of the energy. I am thinking about 4 analytical fraction functions (H, He, CNO, Fe) as a function of energy, which is fitted to data. A similar approa...Implement a function in auger.py that sample charges for the cosmic rays as a function of the energy. I am thinking about 4 analytical fraction functions (H, He, CNO, Fe) as a function of energy, which is fitted to data. A similar approach was done in GAP2016_047 (Figure 5).![Screenshot_20180213_201739](/uploads/9ca6e57964c68fc34884a11dc2d33d4e/Screenshot_20180213_201739.png)v1.0Teresa Karolin Bisterteresa.bister@gmail.comTeresa Karolin Bisterteresa.bister@gmail.com2018-03-31https://git.rwth-aachen.de/astro/astrotools/-/issues/16Increase coverage for coord.py2018-04-13T12:34:53+02:00Marcus WirtzIncrease coverage for coord.pyv1.0Marcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/13Partly inconsistent usage of degrees and radians and theta definitions in coo...2018-04-13T12:35:03+02:00Martin UrbanPartly inconsistent usage of degrees and radians and theta definitions in coord.pyThis issue is related to #11 and #12
* [x] Zenith in range $`(0, \pi)`$ but altitude in range $`(\pi/2, -\pi/2)`$.
* [x] Some functions use degrees others radians, see subtickets
* [x] Think about moving auger specific things to augerThis issue is related to #11 and #12
* [x] Zenith in range $`(0, \pi)`$ but altitude in range $`(\pi/2, -\pi/2)`$.
* [x] Some functions use degrees others radians, see subtickets
* [x] Think about moving auger specific things to augerv1.0https://git.rwth-aachen.de/astro/astrotools/-/issues/17Colored output when using setup.py2018-04-16T16:42:24+02:00Marcus WirtzColored output when using setup.pyMartin UrbanMartin Urbanhttps://git.rwth-aachen.de/astro/astrotools/-/issues/18Fix failing unittest in obs2018-04-18T10:30:23+02:00Martin UrbanFix failing unittest in obstest_02_isotropy_peak_90 failstest_02_isotropy_peak_90 failsMarcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/19Missleading ang2vec in healpytools2018-04-23T12:12:46+02:00Paula BigalkeMissleading ang2vec in healpytoolsThe import `ang2vec` from healpytools uses `healpy.pixelfunc` not `astrotools.coord`The import `ang2vec` from healpytools uses `healpy.pixelfunc` not `astrotools.coord`https://git.rwth-aachen.de/astro/astrotools/-/issues/20Energy energy correlation uses keyword "ref_mode" which is not described in d...2018-04-24T16:43:58+02:00Marcus WirtzEnergy energy correlation uses keyword "ref_mode" which is not described in doctringPaula BigalkePaula Bigalkehttps://git.rwth-aachen.de/astro/astrotools/-/issues/21Slicing of CosmicRaysBase is not returning a CosmicRaysBase object but an np....2018-04-30T14:13:12+02:00Marcus WirtzSlicing of CosmicRaysBase is not returning a CosmicRaysBase object but an np.ndarrayMartin UrbanMartin Urban