astrotools issueshttps://git.rwth-aachen.de/astro/astrotools/-/issues2019-11-21T23:30:16+01:00https://git.rwth-aachen.de/astro/astrotools/-/issues/8Implement GalacticBound() Simulation in simulation class2019-11-21T23:30:16+01:00Marcus WirtzImplement GalacticBound() Simulation in simulation class* [ ] Think about implementing the galactic bound simulation part that consider an extragalactic energy / composition and propagates corresponding to fluxes of galactic magnetic field lenses to Earth
* [ ] Implement this class* [ ] Think about implementing the galactic bound simulation part that consider an extragalactic energy / composition and propagates corresponding to fluxes of galactic magnetic field lenses to Earth
* [ ] Implement this classastrotools v2.0.0Marcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/32Extend tutorial to show workflow for all modules2019-10-21T10:29:28+02:00Marcus WirtzExtend tutorial to show workflow for all modules* [x] coord
* [x] cosmic_rays
* [x] gamale
* [x] healpytools
* [ ] obs
* [x] simulations
* [x] skymap* [x] coord
* [x] cosmic_rays
* [x] gamale
* [x] healpytools
* [ ] obs
* [x] simulations
* [x] skymapastrotools v2.0.0https://git.rwth-aachen.de/astro/astrotools/-/issues/33DeprecationWarning for matplotlibs 'collections' in python 3.72019-05-09T15:58:47+02:00Marcus WirtzDeprecationWarning for matplotlibs 'collections' in python 3.7When executing the unittest "/test/test_cosmic_rays.py" with python 3.7, you get a deprecation warning for python 3.8:
test_16_plotting (__main__.TestCosmicRays) ... /home/marcus/.local/lib/python3.7/site-packages/matplotlib/cbook/__ini...When executing the unittest "/test/test_cosmic_rays.py" with python 3.7, you get a deprecation warning for python 3.8:
test_16_plotting (__main__.TestCosmicRays) ... /home/marcus/.local/lib/python3.7/site-packages/matplotlib/cbook/__init__.py:2349: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
if isinstance(obj, collections.Iterator):
/home/marcus/.local/lib/python3.7/site-packages/matplotlib/cbook/__init__.py:2366: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
return list(data) if isinstance(data, collections.MappingView) else dataastrotools v2.0.0https://git.rwth-aachen.de/astro/astrotools/-/issues/34Pending DeprecationWarning for matrix subclass2019-11-21T21:25:03+01:00Marcus WirtzPending DeprecationWarning for matrix subclassWhen executing test/test_gamale.py you get a pending deprecation warning:
test_01_load_and_dimensions (__main__.TestLens)
Test raw mldat matrices with simple load function ... /home/marcus/.local/lib/python3.7/site-packages/numpy/matrix...When executing test/test_gamale.py you get a pending deprecation warning:
test_01_load_and_dimensions (__main__.TestLens)
Test raw mldat matrices with simple load function ... /home/marcus/.local/lib/python3.7/site-packages/numpy/matrixlib/defmatrix.py:68: PendingDeprecationWarning: the matrix subclass is not the recommended way to represent matrices or deal with linear algebra (see https://docs.scipy.org/doc/numpy/user/numpy-for-matlab-users.html). Please adjust your code to use regular ndarray.
return matrix(data, dtype=dtype, copy=False)astrotools v2.0.0https://git.rwth-aachen.de/astro/astrotools/-/issues/35Create access function when setting keywords ('vecs', 'pixel', ('lon', 'lat))...2019-04-17T14:39:18+02:00Marcus WirtzCreate access function when setting keywords ('vecs', 'pixel', ('lon', 'lat)) for CosmicRaysBase()- Create access functions for the respective other keywords (e.g. when setting 'vecs', create access functions for 'pixel', 'lon', 'lat')
- however, don't store the values in cosmic ray container (converting on demand)- Create access functions for the respective other keywords (e.g. when setting 'vecs', create access functions for 'pixel', 'lon', 'lat')
- however, don't store the values in cosmic ray container (converting on demand)astrotools v2.0.0Teresa Karolin Bisterteresa.bister@gmail.comTeresa Karolin Bisterteresa.bister@gmail.comhttps://git.rwth-aachen.de/astro/astrotools/-/issues/36Check astrotools tutorial2019-05-09T15:59:05+02:00Marcus WirtzCheck astrotools tutorialplease read one time over the tutorial page and correct / improve stuffplease read one time over the tutorial page and correct / improve stuffastrotools v2.0.0Niklas Uwe LangnerNiklas Uwe Langnerhttps://git.rwth-aachen.de/astro/astrotools/-/issues/40Bring coverage over 95%2018-09-14T11:24:43+02:00Marcus WirtzBring coverage over 95%astrotools v2.0.0https://git.rwth-aachen.de/astro/astrotools/-/issues/46Unwanted behavior in cosmic_ray class?2019-05-29T09:48:41+02:00Marcus WirtzUnwanted behavior in cosmic_ray class?When initializing a CosmicRaysBase object with a saved CosmicRaysSets object, it will not complain and just merge all nsets*ncrs together in one big set. However, the self.shape keyword is still (nsets, ncrs). That can not be wanted...?When initializing a CosmicRaysBase object with a saved CosmicRaysSets object, it will not complain and just merge all nsets*ncrs together in one big set. However, the self.shape keyword is still (nsets, ncrs). That can not be wanted...?astrotools v2.0.0Martin UrbanMartin Urbanhttps://git.rwth-aachen.de/astro/astrotools/-/issues/50Implement __eq__(), __ne__() __cmp__() compare functions to CosmicRays Class ...2019-09-25T11:08:44+02:00Marcus WirtzImplement __eq__(), __ne__() __cmp__() compare functions to CosmicRays Class instancesSee,
https://stackoverflow.com/questions/1227121/compare-object-instances-for-equality-by-their-attributes-in-pythonSee,
https://stackoverflow.com/questions/1227121/compare-object-instances-for-equality-by-their-attributes-in-pythonastrotools v2.0.0https://git.rwth-aachen.de/astro/astrotools/-/issues/53Weird behaviour of crs['vecs'] if the key doesn't exist2019-10-16T14:29:00+02:00Niklas Uwe LangnerWeird behaviour of crs['vecs'] if the key doesn't existUsing crs['vecs'] without the key 'vecs' existing **sometimes** uses crs['pixels'] to calculate the vectors instead of crs['lon'] and crs['lat'] even though those exist. This might result in undesired outputs if changes to lon and lat we...Using crs['vecs'] without the key 'vecs' existing **sometimes** uses crs['pixels'] to calculate the vectors instead of crs['lon'] and crs['lat'] even though those exist. This might result in undesired outputs if changes to lon and lat were not also applied to pixels.astrotools v2.0.0Teresa Karolin Bisterteresa.bister@gmail.comTeresa Karolin Bisterteresa.bister@gmail.comhttps://git.rwth-aachen.de/astro/astrotools/-/issues/54Effective storing and calling of directions2019-10-17T21:54:50+02:00Teresa Karolin Bisterteresa.bister@gmail.comEffective storing and calling of directions* [ ] Internal conversion of vecs to x, y, z in order to efficiently store inside shape_array? -> better smaller size than fast calling of vecs?
* [x] remove convert_all in simulations
* [ ] raise Warning only if someone stores diff...* [ ] Internal conversion of vecs to x, y, z in order to efficiently store inside shape_array? -> better smaller size than fast calling of vecs?
* [x] remove convert_all in simulations
* [ ] raise Warning only if someone stores different info in a similar direction key, no warning for same info (enables faster calling)
- How to treat pixels regarding the conversion?astrotools v2.0.0Marcus WirtzTeresa Karolin Bisterteresa.bister@gmail.comMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/56Consistency of the 'charge' value after simulation2019-11-05T17:23:58+01:00Niklas Uwe LangnerConsistency of the 'charge' value after simulationWhen simulating with simulations.ObservedBound and setting the charge to a constant value (like 2), the "charge" value of the resulting CosmicRaysSets is only the set integer. When using a setup of multiple charges (like "mixed"), the "c...When simulating with simulations.ObservedBound and setting the charge to a constant value (like 2), the "charge" value of the resulting CosmicRaysSets is only the set integer. When using a setup of multiple charges (like "mixed"), the "charge" value is an array containing the individual charge of each cosmic ray. I think it would be better if the output was consistent (always the individual value of each cosmic ray) so that the same code can work when only changing the charge composition without the need to check the type of the "charge" value each time.astrotools v2.0.0Marcus WirtzNiklas Uwe LangnerMarcus Wirtz