astrotools issueshttps://git.rwth-aachen.de/astro/astrotools/-/issues2019-06-28T12:43:57+02:00https://git.rwth-aachen.de/astro/astrotools/-/issues/52Fit correctly J0 from ICRC17 energy spectrum2019-06-28T12:43:57+02:00Marcus WirtzFit correctly J0 from ICRC17 energy spectrumDSPECTRUM_ANALYTIC_15 = np.array([3.3e-19, 4.82e18, 42.09e18, 3.29, 2.6, 3.14])
DSPECTRUM_ANALYTIC_17 = np.array([1, 5.08e18, 39e18, 3.293, 2.53, 2.5])
# publication does not state J0 -> if needed could be fitted with data from:
# https:...DSPECTRUM_ANALYTIC_15 = np.array([3.3e-19, 4.82e18, 42.09e18, 3.29, 2.6, 3.14])
DSPECTRUM_ANALYTIC_17 = np.array([1, 5.08e18, 39e18, 3.293, 2.53, 2.5])
# publication does not state J0 -> if needed could be fitted with data from:
# https://www.auger.unam.mx/AugerWiki/SpectrumICRC2017
# does not matter for rand_energy_from_auger, just scaling factor
Should be of the order of 3.3e-19https://git.rwth-aachen.de/astro/astrotools/-/issues/51Implement __add__() function to support crs = crs1 + crs22019-06-17T15:05:50+02:00Marcus WirtzImplement __add__() function to support crs = crs1 + crs2See e.g.,
http://www.marinamele.com/2014/04/modifying-add-method-of-python-class.htmlSee e.g.,
http://www.marinamele.com/2014/04/modifying-add-method-of-python-class.htmlNiklas Uwe LangnerNiklas Uwe Langnerhttps://git.rwth-aachen.de/astro/astrotools/-/issues/50Implement __eq__(), __ne__() __cmp__() compare functions to CosmicRays Class ...2019-09-25T11:08:44+02:00Marcus WirtzImplement __eq__(), __ne__() __cmp__() compare functions to CosmicRays Class instancesSee,
https://stackoverflow.com/questions/1227121/compare-object-instances-for-equality-by-their-attributes-in-pythonSee,
https://stackoverflow.com/questions/1227121/compare-object-instances-for-equality-by-their-attributes-in-pythonastrotools v2.0.0https://git.rwth-aachen.de/astro/astrotools/-/issues/45Remove astrotools. in the WIKI deploy of the stat module2019-09-25T11:07:41+02:00Marcus WirtzRemove astrotools. in the WIKI deploy of the stat moduleIn the stat module there is the astrotools.module.function format everywhere, which comes from the .rst file:
```
.. automodule:: astrotools.stat
:members:
:undoc-members:
:show-inheritance:
```
Removing the astrotools. will cau...In the stat module there is the astrotools.module.function format everywhere, which comes from the .rst file:
```
.. automodule:: astrotools.stat
:members:
:undoc-members:
:show-inheritance:
```
Removing the astrotools. will cause the WIKI to deploy the os.stat module instead...
See:
https://astro.pages.rwth-aachen.de/astrotools/stat.htmlMarcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/36Check astrotools tutorial2019-05-09T15:59:05+02:00Marcus WirtzCheck astrotools tutorialplease read one time over the tutorial page and correct / improve stuffplease read one time over the tutorial page and correct / improve stuffastrotools v2.0.0Niklas Uwe LangnerNiklas Uwe Langnerhttps://git.rwth-aachen.de/astro/astrotools/-/issues/34Pending DeprecationWarning for matrix subclass2019-11-21T21:25:03+01:00Marcus WirtzPending DeprecationWarning for matrix subclassWhen executing test/test_gamale.py you get a pending deprecation warning:
test_01_load_and_dimensions (__main__.TestLens)
Test raw mldat matrices with simple load function ... /home/marcus/.local/lib/python3.7/site-packages/numpy/matrix...When executing test/test_gamale.py you get a pending deprecation warning:
test_01_load_and_dimensions (__main__.TestLens)
Test raw mldat matrices with simple load function ... /home/marcus/.local/lib/python3.7/site-packages/numpy/matrixlib/defmatrix.py:68: PendingDeprecationWarning: the matrix subclass is not the recommended way to represent matrices or deal with linear algebra (see https://docs.scipy.org/doc/numpy/user/numpy-for-matlab-users.html). Please adjust your code to use regular ndarray.
return matrix(data, dtype=dtype, copy=False)astrotools v2.0.0https://git.rwth-aachen.de/astro/astrotools/-/issues/33DeprecationWarning for matplotlibs 'collections' in python 3.72019-05-09T15:58:47+02:00Marcus WirtzDeprecationWarning for matplotlibs 'collections' in python 3.7When executing the unittest "/test/test_cosmic_rays.py" with python 3.7, you get a deprecation warning for python 3.8:
test_16_plotting (__main__.TestCosmicRays) ... /home/marcus/.local/lib/python3.7/site-packages/matplotlib/cbook/__ini...When executing the unittest "/test/test_cosmic_rays.py" with python 3.7, you get a deprecation warning for python 3.8:
test_16_plotting (__main__.TestCosmicRays) ... /home/marcus/.local/lib/python3.7/site-packages/matplotlib/cbook/__init__.py:2349: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
if isinstance(obj, collections.Iterator):
/home/marcus/.local/lib/python3.7/site-packages/matplotlib/cbook/__init__.py:2366: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
return list(data) if isinstance(data, collections.MappingView) else dataastrotools v2.0.0https://git.rwth-aachen.de/astro/astrotools/-/issues/22Set unfortunate length of string to CosmicRaysBase will fail2018-05-02T12:20:14+02:00Marcus WirtzSet unfortunate length of string to CosmicRaysBase will failIf length of set string is the same as number of cosmic rays, the setting will fail
-> see unittest TestCosmicRaysBase.test_26_set_unfortunate_length_of_string()If length of set string is the same as number of cosmic rays, the setting will fail
-> see unittest TestCosmicRaysBase.test_26_set_unfortunate_length_of_string()Martin UrbanMartin Urbanhttps://git.rwth-aachen.de/astro/astrotools/-/issues/13Partly inconsistent usage of degrees and radians and theta definitions in coo...2018-04-13T12:35:03+02:00Martin UrbanPartly inconsistent usage of degrees and radians and theta definitions in coord.pyThis issue is related to #11 and #12
* [x] Zenith in range $`(0, \pi)`$ but altitude in range $`(\pi/2, -\pi/2)`$.
* [x] Some functions use degrees others radians, see subtickets
* [x] Think about moving auger specific things to augerThis issue is related to #11 and #12
* [x] Zenith in range $`(0, \pi)`$ but altitude in range $`(\pi/2, -\pi/2)`$.
* [x] Some functions use degrees others radians, see subtickets
* [x] Think about moving auger specific things to augerv1.0https://git.rwth-aachen.de/astro/astrotools/-/issues/12coord exposure_equatorial mixes degrees and radians2018-04-10T16:59:12+02:00Martin Urbancoord exposure_equatorial mixes degrees and radianscoord.exposure_equatorial() mixes degrees and radians although astrotools use radians internally.coord.exposure_equatorial() mixes degrees and radians although astrotools use radians internally.v1.0Marcus WirtzMarcus Wirtzhttps://git.rwth-aachen.de/astro/astrotools/-/issues/11Astrotools lon / lat definition false documentation2018-04-10T16:58:53+02:00Marcus WirtzAstrotools lon / lat definition false documentationLatitude is defined in the astrotools as [0, pi] with 0 pointing in z-direction. This is wrongly defined in markdown and probably in WIKI.Latitude is defined in the astrotools as [0, pi] with 0 pointing in z-direction. This is wrongly defined in markdown and probably in WIKI.v1.0Martin UrbanMartin Urban