Commit ca5b7170 authored by Sonja Happ's avatar Sonja Happ
Browse files

change version of node image 8.6; work around for href warnings with button

parent 897e9497
FROM node:8.2 AS builder
FROM node:8.6 AS builder
RUN apt-get install -y \
git
......
......@@ -21,7 +21,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import { FormControl } from 'react-bootstrap';
import { FormControl, Button } from 'react-bootstrap';
import Icon from './icon';
class EditableHeader extends React.Component {
......@@ -85,8 +85,8 @@ class EditableHeader extends React.Component {
<FormControl type='text' bsSize='large' value={this.state.title} onChange={this.onChange} style={editStyle} autoFocus />
</form>
<a href={'#'} onClick={this.save}><Icon icon='check' style={iconStyle} /></a>
<a href={'#'} onClick={this.cancel}><Icon icon='times' style={iconStyle} /></a>
<Button onClick={this.save}><Icon icon='check' style={iconStyle} /></Button>
<Button onClick={this.cancel}><Icon icon='times' style={iconStyle} /></Button>
</div>;
}
......@@ -95,7 +95,7 @@ class EditableHeader extends React.Component {
{this.state.title}
</h1>
<a href={'#'} onClick={this.edit}><Icon icon='edit' style={iconStyle} /></a>
<Button onClick={this.edit}><Icon icon='edit' style={iconStyle} /></Button>
</div>;
}
}
......
......@@ -74,7 +74,7 @@ class CustomTable extends Component {
if (linkKey && data[linkKey] != null) {
cell.push(<Link to={child.props.link + data[linkKey]}>{content}</Link>);
} else if (child.props.clickable) {
cell.push(<a href={'#'} onClick={() => child.props.onClick(index)}>{content}</a>);
cell.push(<Button onClick={() => child.props.onClick(index)}>{content}</Button>);
} else {
cell.push(content);
}
......
  • Oh, I did the same fix here: 3fcb30bd

    I guess we should use the bsStyle=link attribute as well?

  • Author Maintainer

    Haha... I didn't see that. 😄 I have merged your solution in the new-api branch to avoid conflicts in the future. Thanks.

Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment