PyI40AAS issueshttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues2020-04-14T15:03:51+02:00https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/65adapter: Re-publish reader/writer functions and relevant classes from adapter...2020-04-14T15:03:51+02:00Michael Thiesadapter: Re-publish reader/writer functions and relevant classes from adapter.json and adapter.xml modulesImports of the (de)serialization functions should look like
```python
from aas.adapter.json import write_aas_json_file, read_json_aas_file
```
instead of
```python
from aas.adapter.json.json_serialization import write_aas_json_file
from ...Imports of the (de)serialization functions should look like
```python
from aas.adapter.json import write_aas_json_file, read_json_aas_file
```
instead of
```python
from aas.adapter.json.json_serialization import write_aas_json_file
from aas.adapter.json.json_deserialization import read_json_aas_file
```
Thus, we should import all classes of the "public interface" in the `aas.adpater.json.__init__` and `aas.adapter.xml.__init__` modules.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/66test: cover serialization and deserialization of formulas2020-04-20T09:17:53+02:00Leon Mauritz Möllertest: cover serialization and deserialization of formulasThe serialization and deserialization of [`Formula`](https://git.rwth-aachen.de/acplt/pyaas/-/blob/fbe3f911a5d0c7acd8cc4c5114c0c499b4ba0eca/aas/model/base.py#L712)s is not tested by the current examples.
Thus lines 481-495 of the `json_d...The serialization and deserialization of [`Formula`](https://git.rwth-aachen.de/acplt/pyaas/-/blob/fbe3f911a5d0c7acd8cc4c5114c0c499b4ba0eca/aas/model/base.py#L712)s is not tested by the current examples.
Thus lines 481-495 of the `json_deserilization`, lines 169-173 of the `json_serialization` and lines 213-219 of the `xml_serialization` are not covered.https://git.rwth-aachen.de/acplt/pyi40aas/-/issues/92compliance_tool: Use pretty-printing in example files2020-10-07T10:45:28+02:00Michael Thiescompliance_tool: Use pretty-printing in example filesThe compliance_tool should use the `pretty_print=True` resp. `indent=4` for the XML/JSON serializers when creating example files.
This way, it's easier to manually inspect the resulting files and a possible deserializer errors are easie...The compliance_tool should use the `pretty_print=True` resp. `indent=4` for the XML/JSON serializers when creating example files.
This way, it's easier to manually inspect the resulting files and a possible deserializer errors are easier to locate by their line numbers.Torben MinyTorben Minyhttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/94aasx: Allow manual specification objects to be written to package2020-10-28T17:12:35+01:00Michael Thiesaasx: Allow manual specification objects to be written to packagehttps://git.rwth-aachen.de/acplt/pyi40aas/-/issues/110make `Namespace` iterable2020-11-25T10:42:59+01:00Leon Mauritz Möllermake `Namespace` iterable@zrgt suggested on Zulip, that classes like `Submodel` and `SubmodelElementCollection` should be iterable.
@mhthies suggested to make Namespaces iterable with an implementation similar to the following:
```py
class Namespace:
[…]
...@zrgt suggested on Zulip, that classes like `Submodel` and `SubmodelElementCollection` should be iterable.
@mhthies suggested to make Namespaces iterable with an implementation similar to the following:
```py
class Namespace:
[…]
def __iter__(self):
return itertools.chain.from_iterable(self.namespace_element_sets)
```
This would make all classes which inherit from `Namespace` iterable over their contained `NamespaceSet`s, namely `AssetAdministrationShell`, `Submodel`, `SubmodelElementCollection`, `AnnotatedRelationshipElement` and `Entity`.